)]}'
{"nova/virt/hyperv/vmutils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f9693c4e67f7ab3afe4e88f32849e3bbb6d40700","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                err_sum_desc \u003d job.ErrorSummaryDescription"},{"line_number":70,"context_line":"                err_desc \u003d job.ErrorDescription"},{"line_number":71,"context_line":"                err_code \u003d job.ErrorCode"},{"line_number":72,"context_line":"                LOG.debug(_(\"WMI job failed with status %(job_state)d. \""},{"line_number":73,"context_line":"                    \"Error details: %(err_sum_desc)s - %(err_desc)s - \""},{"line_number":74,"context_line":"                    \"Error code: %(err_code)d\") % locals())"},{"line_number":75,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F5dg%3D","line":72,"updated":"2012-11-16 16:12:24.000000000","message":"Should this (and the one below) not be LOG.error()? Meaning, are these soft failures really only of interest for debugging?","commit_id":"e0a25b83c63feac4752f623bb2715fffc825478b"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"a4782bb3ddafe1aceec1f2c1da97bb1327de25da","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                err_sum_desc \u003d job.ErrorSummaryDescription"},{"line_number":70,"context_line":"                err_desc \u003d job.ErrorDescription"},{"line_number":71,"context_line":"                err_code \u003d job.ErrorCode"},{"line_number":72,"context_line":"                LOG.debug(_(\"WMI job failed with status %(job_state)d. \""},{"line_number":73,"context_line":"                    \"Error details: %(err_sum_desc)s - %(err_desc)s - \""},{"line_number":74,"context_line":"                    \"Error code: %(err_code)d\") % locals())"},{"line_number":75,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F21E%3D","line":72,"in_reply_to":"AAAAMH%2F%2F5cY%3D","updated":"2012-11-19 22:18:44.000000000","message":"The error rised by the caller carries enough context not to require an Log.error() here, but in some cases troubleshooting is necessary and the details logged here can be really useful.  \n\nThis is unfortunately an implementation that goes back to \u003c\u003d Essex code and will go away with the forthcoming V2 version of the driver. This function should definitely rise an exception instead of returning a value. This requires unfortunately more than a bit of refactoring that we\u0027d like to postpone if possible.","commit_id":"e0a25b83c63feac4752f623bb2715fffc825478b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b3068297b054165f9fa3f1dff6c847bfad098d6f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                err_sum_desc \u003d job.ErrorSummaryDescription"},{"line_number":70,"context_line":"                err_desc \u003d job.ErrorDescription"},{"line_number":71,"context_line":"                err_code \u003d job.ErrorCode"},{"line_number":72,"context_line":"                LOG.debug(_(\"WMI job failed with status %(job_state)d. \""},{"line_number":73,"context_line":"                    \"Error details: %(err_sum_desc)s - %(err_desc)s - \""},{"line_number":74,"context_line":"                    \"Error code: %(err_code)d\") % locals())"},{"line_number":75,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F5cY%3D","line":72,"in_reply_to":"AAAAMH%2F%2F5cs%3D","updated":"2012-11-16 16:25:18.000000000","message":"sure, but it seems like if someone isn\u0027t capturing debug messages, they might miss the actual source of the failure in this case. Is the *actual* reason for the failure reported elsewhere as well? (or is the reason not really important?)","commit_id":"e0a25b83c63feac4752f623bb2715fffc825478b"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"16bc96aecb111681b0c959652bcd6163cbcd2d04","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                err_sum_desc \u003d job.ErrorSummaryDescription"},{"line_number":70,"context_line":"                err_desc \u003d job.ErrorDescription"},{"line_number":71,"context_line":"                err_code \u003d job.ErrorCode"},{"line_number":72,"context_line":"                LOG.debug(_(\"WMI job failed with status %(job_state)d. \""},{"line_number":73,"context_line":"                    \"Error details: %(err_sum_desc)s - %(err_desc)s - \""},{"line_number":74,"context_line":"                    \"Error code: %(err_code)d\") % locals())"},{"line_number":75,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F5cs%3D","line":72,"in_reply_to":"AAAAMH%2F%2F5dg%3D","updated":"2012-11-16 16:20:31.000000000","message":"a specific domain related exception is raised by the caller of this method (when appropriate)","commit_id":"e0a25b83c63feac4752f623bb2715fffc825478b"}]}