)]}'
{"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ea9493079ed7db21f84eab0d92f5fd64c3d27f93","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"def is_virt_type_valid(virt_type):"},{"line_number":215,"context_line":"    supported_virt_types \u003d {\u0027qemu\u0027, \u0027kvm\u0027, \u0027xen\u0027, \u0027uml\u0027, \u0027lxc\u0027, \u0027parallels\u0027}"},{"line_number":216,"context_line":"    return virt_type in supported_virt_types"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_bd162047","line":215,"updated":"2015-03-15 15:01:41.000000000","message":"Rather than redefine this again, I\u0027d rather see the dict in is_disk_bus_valid_for_virt pulled out as a constant and then check for virt_type in the keys of that dict.","commit_id":"a40ececc50218b77469ba554cfc5cd0b53052252"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ea9493079ed7db21f84eab0d92f5fd64c3d27f93","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    key \u003d \"hw_\" + device_type + \"_bus\""},{"line_number":241,"context_line":"    disk_bus \u003d image_meta.get(\u0027properties\u0027, {}).get(key)"},{"line_number":242,"context_line":"    if disk_bus is not None:"},{"line_number":243,"context_line":"        if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":244,"context_line":"            raise exception.UnsupportedHardware(model\u003ddisk_bus,"},{"line_number":245,"context_line":"                                                virt\u003dvirt_type)"},{"line_number":246,"context_line":"        return disk_bus"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_3d0b1025","line":243,"updated":"2015-03-15 15:01:41.000000000","message":"Don\u0027t we already hit it here?","commit_id":"a40ececc50218b77469ba554cfc5cd0b53052252"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ea9493079ed7db21f84eab0d92f5fd64c3d27f93","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    elif virt_type \u003d\u003d \"parallels\":"},{"line_number":274,"context_line":"        if device_type \u003d\u003d \"cdrom\":"},{"line_number":275,"context_line":"            return \"ide\""},{"line_number":276,"context_line":"        elif device_type \u003d\u003d \"disk\":"},{"line_number":277,"context_line":"            return \"sata\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_3d2230a3","line":276,"updated":"2015-03-15 15:01:41.000000000","message":"Rather than add a new validation method, why not just have an else here that raises UnsupportedVirtType?","commit_id":"a40ececc50218b77469ba554cfc5cd0b53052252"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ea9493079ed7db21f84eab0d92f5fd64c3d27f93","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            return \"ide\""},{"line_number":276,"context_line":"        elif device_type \u003d\u003d \"disk\":"},{"line_number":277,"context_line":"            return \"sata\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    return None"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1d1f2c5c","line":278,"updated":"2015-03-15 15:01:41.000000000","message":"I guess if disk_bus was None we\u0027d get here and eventually that returns None and we get the different (unhelpful) error.","commit_id":"a40ececc50218b77469ba554cfc5cd0b53052252"}]}