)]}'
{"nova/api/openstack/compute/contrib/quotas.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"fabde6dd840b9ebcd87625973557072db78091ef","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            if not force_update:"},{"line_number":179,"context_line":"                minimum \u003d settable_quotas[key][\u0027minimum\u0027]"},{"line_number":180,"context_line":"                maximum \u003d settable_quotas[key][\u0027maximum\u0027]"},{"line_number":181,"context_line":"                self._validate_quota_limit(key, value, minimum, maximum)"},{"line_number":182,"context_line":"            valid_quotas[key] \u003d value"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        for key, value in valid_quotas.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e095a333","line":181,"range":{"start_line":181,"start_character":21,"end_line":181,"end_character":42},"updated":"2015-03-12 21:29:33.000000000","message":"I\u0027m not sure how this helps, _validate_quota_limit still raises an exception so you\u0027ll still get a 400. I think that has to be inside the try block, right?","commit_id":"3464d89c9542215d674fa1f1b1b1633ef92c9e8e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b307ba6049541769718f4acbf34204fdff6401df","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            if not force_update:"},{"line_number":179,"context_line":"                minimum \u003d settable_quotas[key][\u0027minimum\u0027]"},{"line_number":180,"context_line":"                maximum \u003d settable_quotas[key][\u0027maximum\u0027]"},{"line_number":181,"context_line":"                self._validate_quota_limit(key, value, minimum, maximum)"},{"line_number":182,"context_line":"            valid_quotas[key] \u003d value"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        for key, value in valid_quotas.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_600a9327","line":181,"in_reply_to":"9a80dd14_e095a333","updated":"2015-03-12 21:41:40.000000000","message":"I think the purpose here is to raise 400 without qutoa create from line 184 .....\neither do all or do nothing,","commit_id":"3464d89c9542215d674fa1f1b1b1633ef92c9e8e"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"534e02538dee5fdfb8b32fba32564526120c2a0e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            if not force_update:"},{"line_number":186,"context_line":"                minimum \u003d settable_quotas[key][\u0027minimum\u0027]"},{"line_number":187,"context_line":"                maximum \u003d settable_quotas[key][\u0027maximum\u0027]"},{"line_number":188,"context_line":"                self._validate_quota_limit(key, value, minimum, maximum)"},{"line_number":189,"context_line":"            valid_quotas[key] \u003d value"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # NOTE(dims): Pass #3 - At this point we know that all the keys and"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8700b467","line":188,"updated":"2015-03-18 02:26:01.000000000","message":"Note, I think there is a race condition here, if another API call changes things at the same time. But I am ok with that. Maybe worth adding a comment though?","commit_id":"a16fa20d84ccded13880a9cef74732e7f2776b87"}],"nova/api/openstack/compute/plugins/v3/quota_sets.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"708996f488a849ec2842e4efe127f3912f880421","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        except exception.Forbidden:"},{"line_number":135,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        valid_quotas \u003d {}"},{"line_number":138,"context_line":"        for key, value in body[\u0027quota_set\u0027].iteritems():"},{"line_number":139,"context_line":"            if key \u003d\u003d \u0027force\u0027 or (not value and value !\u003d 0):"},{"line_number":140,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_61a8c3db","line":137,"updated":"2015-03-13 08:20:43.000000000","message":"since you add the comments on v2\nand v2 code will deprecate in the future, can you\ncopy some comments from v2 to v2.1?","commit_id":"d62ace05140d5524495fce8082b34b698a36fb8e"}]}