)]}'
{"nova/api/openstack/common.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"934395a2871519d608a0db7c0c7311ea9ab13817","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def raise_http_not_implemented_error():"},{"line_number":546,"context_line":"    msg \u003d _(\"The requested functionality is not supported.\")"},{"line_number":547,"context_line":"    raise webob.exc.HTTPNotImplemented(explanation\u003dmsg)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"def check_cells_enabled(function):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_44389ca0","line":547,"updated":"2015-05-07 11:02:32.000000000","message":"so, honestly the use of 501 here is definitively wrong, so we should not call this raise_feature_not_found() or something, then later change this to be a 400 instead of 501.","commit_id":"6db1ed5a47023e74e8269ba54a2e22bf92479685"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3c7f1ae7959ad7bf3804ec24220f32388385685b","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def raise_http_not_implemented_error():"},{"line_number":546,"context_line":"    msg \u003d _(\"The requested functionality is not supported.\")"},{"line_number":547,"context_line":"    raise webob.exc.HTTPNotImplemented(explanation\u003dmsg)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"def check_cells_enabled(function):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_191d47bd","line":547,"in_reply_to":"1aca2d91_44389ca0","updated":"2015-05-08 02:57:50.000000000","message":"@Sean\n\nThis patch doesn\u0027t change http status codes from current codes at all.\nIf we want to change them, on api-wg we need to discuss what is valid code for this situation.\nI posted https://review.openstack.org/#/c/181283/ for this to api-wg.\nI\u0027m happy if you join to the review.","commit_id":"6db1ed5a47023e74e8269ba54a2e22bf92479685"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cb8d821b88b0b52e5fc6183f3eb676e3a45fbf6d","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    if msg is None:"},{"line_number":541,"context_line":"        msg \u003d _(\"The requested functionality is not supported.\")"},{"line_number":542,"context_line":"    # NOTE: We are discussing what status code is more accurate"},{"line_number":543,"context_line":"    # for this case on https://review.openstack.org/#/c/181283/"},{"line_number":544,"context_line":"    # but we cannot still build a consensus. Anyway even if we need"},{"line_number":545,"context_line":"    # to change this status code, some microversion will be necessary."},{"line_number":546,"context_line":"    raise webob.exc.HTTPNotImplemented(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_ab1f6d5a","line":543,"updated":"2015-06-01 16:17:45.000000000","message":"I think we need to add a dependency to that patch\nthis is a ongoing patch , so when this patch is merged, in any case we won\u0027t need the NOTE here","commit_id":"def20dadb892541a816540501c9438e2108fdc78"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3ef78d4e65c481dcb57ff32dced4234aed93d848","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    if msg is None:"},{"line_number":541,"context_line":"        msg \u003d _(\"The requested functionality is not supported.\")"},{"line_number":542,"context_line":"    # NOTE: We are discussing what status code is more accurate"},{"line_number":543,"context_line":"    # for this case on https://review.openstack.org/#/c/181283/"},{"line_number":544,"context_line":"    # but we cannot still build a consensus. Anyway even if we need"},{"line_number":545,"context_line":"    # to change this status code, some microversion will be necessary."},{"line_number":546,"context_line":"    raise webob.exc.HTTPNotImplemented(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_1630dc55","line":543,"in_reply_to":"5afe65bd_ab1f6d5a","updated":"2015-06-01 23:34:29.000000000","message":"@jichenjc\n\nThe dependency seems wrong, because the patch scope will leak. As the following mentioned, if status code needs to be changed, microversion will be necessary.\nI don\u0027t think we should implement both microversion and this cleanup in a single patch. That would be difficult to be reviewed and the scope would be unclear.\n\nMaybe this NOTE misleads now. So I will remove this NOTE.","commit_id":"def20dadb892541a816540501c9438e2108fdc78"}],"nova/api/openstack/compute/plugins/v3/admin_password.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b86bafbc90945da227645cea3160427d8760709a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            raise common.raise_http_conflict_for_instance_invalid_state("},{"line_number":56,"context_line":"                e, \u0027changePassword\u0027, id)"},{"line_number":57,"context_line":"        except NotImplementedError:"},{"line_number":58,"context_line":"            msg \u003d _(\"Unable to set password on instance\")"},{"line_number":59,"context_line":"            raise exc.HTTPNotImplemented(explanation\u003dmsg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e4496e61","side":"PARENT","line":58,"updated":"2015-03-18 01:37:47.000000000","message":"So where the error message is fairly vague and only differs for no reason at all I\u0027ve no problem with this sort of cleanup. But in this case saying that changing the password on this type of vm is not supported I think is a useful distinction and we should keep it\n\nWhere we can actually give more detail I think we should rather than keep it generic, but happy to see those sort of fixes for the future","commit_id":"05f3049ebb6f14361996328900f0f9bba6cdbe29"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8bd6b67d5a6440aff842efc353063ad5344492d4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            raise common.raise_http_conflict_for_instance_invalid_state("},{"line_number":56,"context_line":"                e, \u0027changePassword\u0027, id)"},{"line_number":57,"context_line":"        except NotImplementedError:"},{"line_number":58,"context_line":"            msg \u003d _(\"Unable to set password on instance\")"},{"line_number":59,"context_line":"            raise exc.HTTPNotImplemented(explanation\u003dmsg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_025b6954","side":"PARENT","line":58,"in_reply_to":"9a80dd14_e4496e61","updated":"2015-03-19 22:11:12.000000000","message":"OK, I see.\nwill remove this change from the next patch.","commit_id":"05f3049ebb6f14361996328900f0f9bba6cdbe29"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"51bc632c079cad564eb1994e3e3a97d8f5317cb4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                e, \u0027changePassword\u0027, id)"},{"line_number":57,"context_line":"        except NotImplementedError:"},{"line_number":58,"context_line":"            msg \u003d _(\"Unable to set password on instance\")"},{"line_number":59,"context_line":"            common.raise_feature_not_supported(msg\u003dmsg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class AdminPassword(extensions.V3APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_5d0c1f94","line":59,"updated":"2015-06-02 12:17:47.000000000","message":"Generally, you\u0027re not passing the message through to the exception any more. So I wonder why this one is different?","commit_id":"56565d071c070fdd7b703a4e17a85a4a87b5aeb7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7151ffa734dc855750c2fd338137c6117f149c12","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                e, \u0027changePassword\u0027, id)"},{"line_number":57,"context_line":"        except NotImplementedError:"},{"line_number":58,"context_line":"            msg \u003d _(\"Unable to set password on instance\")"},{"line_number":59,"context_line":"            common.raise_feature_not_supported(msg\u003dmsg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class AdminPassword(extensions.V3APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_8b48085d","line":59,"in_reply_to":"5afe65bd_5d0c1f94","updated":"2015-06-02 14:28:12.000000000","message":"Hi Matthew,\n\nThanks for your review, and that is very nice point.\n\nOn PS3 review(https://review.openstack.org/#/c/163697/3/nova/api/openstack/compute/plugins/v3/admin_password.py), cyeoh asked me that this message is kept. I felt the other messages don\u0027t contain the detail and we can use generic message instead. but this case contain the detail. So that was a reason why cyeoh asked it I feel now.\nI am a little sentimental anyway..","commit_id":"56565d071c070fdd7b703a4e17a85a4a87b5aeb7"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"87769bc0f9448d17ca927139bb4498f25aa9530f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                e, \u0027changePassword\u0027, id)"},{"line_number":57,"context_line":"        except NotImplementedError:"},{"line_number":58,"context_line":"            msg \u003d _(\"Unable to set password on instance\")"},{"line_number":59,"context_line":"            common.raise_feature_not_supported(msg\u003dmsg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class AdminPassword(extensions.V3APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_cb74c0d0","line":59,"in_reply_to":"5afe65bd_8b48085d","updated":"2015-06-02 14:38:24.000000000","message":"It\u0027s fine. I put +1 overall anyway as this query is only a small matter which you have added a TODO for.","commit_id":"56565d071c070fdd7b703a4e17a85a4a87b5aeb7"}]}