)]}'
{"nova/image/glance.py":[{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"187d9567f25d87e67bef32f825946e8761ba7c53","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                for chunk in image_chunks:"},{"line_number":364,"context_line":"                    data.write(chunk)"},{"line_number":365,"context_line":"            except Exception, ex:"},{"line_number":366,"context_line":"                error_msg \u003d (_(\"Error writing to %(path)s: %(exception)\") %"},{"line_number":367,"context_line":"                        {\u0027path\u0027: dst_path, \u0027exception\u0027: ex})"},{"line_number":368,"context_line":"                LOG.exception(error_msg)"},{"line_number":369,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_db7c65b8","line":366,"updated":"2015-03-17 14:55:22.000000000","message":"Please use _LE here for log translation.\n\nRef: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"3b83b515eeece49e5056846d6f4372dc3b283e81"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1203520d092fd6a1c0764a0b3df61e9e62cd1716","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            except Exception as ex:"},{"line_number":366,"context_line":"                error_msg \u003d (_LE(\"Error writing to %(path)s: %(exception)\") %"},{"line_number":367,"context_line":"                        {\u0027path\u0027: dst_path, \u0027exception\u0027: ex})"},{"line_number":368,"context_line":"                LOG.exception(error_msg)"},{"line_number":369,"context_line":"            finally:"},{"line_number":370,"context_line":"                if close_file:"},{"line_number":371,"context_line":"                    data.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f1a03ca7","line":368,"updated":"2015-03-18 11:23:19.000000000","message":"do we need the error_msg variable?\n\nWhy do we need LOG.exception here - that will show the whole trace. Would LOG.error or warning suffice?","commit_id":"0a395dbe505d0f78ac06ed3a20212de9dce8bd6c"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"4bd873173ce7e57e27c21e40fa0cd61c4f72e57b","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                    data.write(chunk)"},{"line_number":367,"context_line":"            except Exception as ex:"},{"line_number":368,"context_line":"                LOG.error(_LE(\"Error writing to %(path)s: %(exception)\"),"},{"line_number":369,"context_line":"                          {\u0027path\u0027: dst_path, \u0027exception\u0027: ex})"},{"line_number":370,"context_line":"            finally:"},{"line_number":371,"context_line":"                if close_file:"},{"line_number":372,"context_line":"                    data.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_46a65811","line":369,"updated":"2015-07-01 03:16:55.000000000","message":"This seems to lead the caller to believe that no error has occurred, I think we should reraise the exception.","commit_id":"d73bc9dd267d0940938ce195f3f966028212cb68"}]}