)]}'
{"nova/compute/api.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"60becb4dd7de68680d62b1e15e518def581991cd","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"    def instance_get_all_by_host(self, context, host_name):"},{"line_number":3466,"context_line":"        \"\"\"Return all instances on the given host.\"\"\""},{"line_number":3467,"context_line":"        #return self.db.instance_get_all_by_host(context, host_name)"},{"line_number":3468,"context_line":"        return objects.InstanceList.get_by_host(context, host_name)"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"    def task_log_get_all(self, context, task_name, period_beginning,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_79e4f3df","line":3467,"updated":"2015-03-13 10:50:21.000000000","message":"please remove the commented line","commit_id":"2d55fb89d4c9d043c5776498d202e3c9cfa7af0a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"df18ae06c0470c705d1ab5f77f2945a1846141ec","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"    def instance_get_all_by_host(self, context, host_name):"},{"line_number":3466,"context_line":"        \"\"\"Return all instances on the given host.\"\"\""},{"line_number":3467,"context_line":"        #return self.db.instance_get_all_by_host(context, host_name)"},{"line_number":3468,"context_line":"        return objects.InstanceList.get_by_host(context, host_name)"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"    def task_log_get_all(self, context, task_name, period_beginning,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1c6685bb","line":3467,"in_reply_to":"9a80dd14_79e4f3df","updated":"2015-03-13 11:06:41.000000000","message":"yes, I comment because of test purpose, forgot to remove it, thanks","commit_id":"2d55fb89d4c9d043c5776498d202e3c9cfa7af0a"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"ad8c9e0ba1f439ef053237baf0d5e253a253a215","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"    def instance_get_all_by_host(self, context, host_name):"},{"line_number":3466,"context_line":"        \"\"\"Return all instances on the given host.\"\"\""},{"line_number":3467,"context_line":"        return objects.InstanceList.get_by_host(context, host_name)"},{"line_number":3468,"context_line":""},{"line_number":3469,"context_line":"    def task_log_get_all(self, context, task_name, period_beginning,"},{"line_number":3470,"context_line":"                         period_ending, host\u003dNone, state\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_ac099a97","line":3467,"updated":"2015-03-27 19:38:43.000000000","message":"With this change it would be good to update calling code to use dot notation.","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bfbfb40f869ecb629dc8acbda7575251d58312c1","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"    def instance_get_all_by_host(self, context, host_name):"},{"line_number":3466,"context_line":"        \"\"\"Return all instances on the given host.\"\"\""},{"line_number":3467,"context_line":"        return objects.InstanceList.get_by_host(context, host_name)"},{"line_number":3468,"context_line":""},{"line_number":3469,"context_line":"    def task_log_get_all(self, context, task_name, period_beginning,"},{"line_number":3470,"context_line":"                         period_ending, host\u003dNone, state\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_4349f0cf","line":3467,"in_reply_to":"fa963961_ac099a97","updated":"2015-04-29 21:16:51.000000000","message":"the code calls are similar like:\nself._manager.instance_get_all_by_host(context, host, node,\n\ncan you please let me know where to change? thanks a lot","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"}],"nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"943922ab09e1238d93ac8034246310bacb3e7ad9","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":336,"context_line":"    def test_servers(self, mock_get):"},{"line_number":337,"context_line":"        mock_get.side_effect \u003d fake_instance_get_all_by_host"},{"line_number":338,"context_line":"        req \u003d self._get_request(True)"},{"line_number":339,"context_line":"        result \u003d self.controller.servers(req, \u0027hyper\u0027)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_b5444874","line":337,"updated":"2015-03-27 16:25:55.000000000","message":"Suggestion: include the side effect with the patch annotation -- e.g.,\n\n  @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027,\n                     side_efect\u003dfake_instance_get_all_by_host)","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"ad8c9e0ba1f439ef053237baf0d5e253a253a215","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":336,"context_line":"    def test_servers(self, mock_get):"},{"line_number":337,"context_line":"        mock_get.side_effect \u003d fake_instance_get_all_by_host"},{"line_number":338,"context_line":"        req \u003d self._get_request(True)"},{"line_number":339,"context_line":"        result \u003d self.controller.servers(req, \u0027hyper\u0027)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_2c7a2a25","line":337,"updated":"2015-03-27 19:38:43.000000000","message":"fake_instance_get_all_by_host still returns a list of dicts. It should return a full-blown InstanceList object or else this isn\u0027t testing the correct thing.\n\nSame applies for the other test changes you have made.","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bfbfb40f869ecb629dc8acbda7575251d58312c1","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":336,"context_line":"    def test_servers(self, mock_get):"},{"line_number":337,"context_line":"        mock_get.side_effect \u003d fake_instance_get_all_by_host"},{"line_number":338,"context_line":"        req \u003d self._get_request(True)"},{"line_number":339,"context_line":"        result \u003d self.controller.servers(req, \u0027hyper\u0027)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_ef9d735a","line":337,"in_reply_to":"fa963961_2c7a2a25","updated":"2015-04-29 21:16:51.000000000","message":"I changed part of the test\nfor some test , I think we can let it be since the unit test itself will focus on whether the code path was successfully executed.\nthanks a lot for the comments","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"943922ab09e1238d93ac8034246310bacb3e7ad9","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":382,"context_line":"    def test_servers_with_no_server(self, mock_get):"},{"line_number":383,"context_line":"        mock_get.return_value \u003d []"},{"line_number":384,"context_line":"        req \u003d self._get_request(True)"},{"line_number":385,"context_line":"        result \u003d self.controller.servers(req, \u00271\u0027)"},{"line_number":386,"context_line":"        self.assertEqual(result, dict(hypervisors\u003dself.NO_SERVER_HYPER_DICTS))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_f531b00c","line":383,"updated":"2015-03-27 16:25:55.000000000","message":"Ditto. Include return value in patch annotation.","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"}],"nova/tests/unit/compute/test_host_api.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"943922ab09e1238d93ac8034246310bacb3e7ad9","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":293,"context_line":"    def test_instance_get_all_by_host(self, mock_get):"},{"line_number":294,"context_line":"        mock_get.return_value \u003d [\u0027fake-responses\u0027]"},{"line_number":295,"context_line":"        result \u003d self.host_api.instance_get_all_by_host(self.ctxt,"},{"line_number":296,"context_line":"                                                        \u0027fake-host\u0027)"},{"line_number":297,"context_line":"        self.assertEqual([\u0027fake-responses\u0027], result)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_b53b28eb","line":294,"updated":"2015-03-27 16:25:55.000000000","message":"Ditto.","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"943922ab09e1238d93ac8034246310bacb3e7ad9","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                     dict(id\u003d2, cell_name\u003d\u0027cell2\u0027, host\u003d\u0027host1\u0027),"},{"line_number":465,"context_line":"                     dict(id\u003d3, cell_name\u003d\u0027cell1\u0027, host\u003d\u0027host2\u0027)]"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        mock_get.return_value \u003d instances"},{"line_number":468,"context_line":"        expected_result \u003d [instances[0], instances[2]]"},{"line_number":469,"context_line":"        cell_and_host \u003d cells_utils.cell_with_item(\u0027cell1\u0027, \u0027fake-host\u0027)"},{"line_number":470,"context_line":"        result \u003d self.host_api.instance_get_all_by_host(self.ctxt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_5523bcbd","line":467,"updated":"2015-03-27 16:25:55.000000000","message":"Ditto.","commit_id":"abc6076115b6e67ff47ba4c7547c33b64e94bf1c"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"39d95d3967757713c0def6dcfc520fd1bf00dcc6","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                     dict(id\u003d2, cell_name\u003d\u0027cell2\u0027, host\u003d\u0027host1\u0027),"},{"line_number":449,"context_line":"                     dict(id\u003d3, cell_name\u003d\u0027cell1\u0027, host\u003d\u0027host2\u0027)]"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        mock_get.return_value \u003d instances"},{"line_number":452,"context_line":"        expected_result \u003d [instances[0], instances[2]]"},{"line_number":453,"context_line":"        cell_and_host \u003d cells_utils.cell_with_item(\u0027cell1\u0027, \u0027fake-host\u0027)"},{"line_number":454,"context_line":"        result \u003d self.host_api.instance_get_all_by_host(self.ctxt,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_19fad675","line":451,"updated":"2015-05-04 16:06:15.000000000","message":"Suggestion: embed in annotation rather than separate line.","commit_id":"dc0d75aa31761bafaff4ecf2dd5f9e3dcb016a66"}]}