)]}'
{"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b3733997144bbc93b861605c733565a53b0be961","unresolved":false,"context_lines":[{"line_number":2789,"context_line":"        self.assertIsNotNone(service[\u0027id\u0027])"},{"line_number":2790,"context_line":"        for key, value in self._get_base_values().iteritems():"},{"line_number":2791,"context_line":"            self.assertEqual(value, service[key])"},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5ad7efbe","line":2792,"updated":"2015-03-20 12:25:41.000000000","message":"Actually I think this test is unnecessary because it is covered by the above test.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"1a528579cf1217c9e39acfde9723def214c3939d","unresolved":false,"context_lines":[{"line_number":2789,"context_line":"        self.assertIsNotNone(service[\u0027id\u0027])"},{"line_number":2790,"context_line":"        for key, value in self._get_base_values().iteritems():"},{"line_number":2791,"context_line":"            self.assertEqual(value, service[key])"},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_c9af632a","line":2792,"in_reply_to":"1a6ced46_bb17cd50","updated":"2015-03-23 09:26:21.000000000","message":"But this is my only point really. The create call will do the fetch for you won\u0027t it? This is proved by the srv[\u0027id\u0027] having been set, which it otherwise wouldn\u0027t have been.\n\nThis is really just tiny optimizations so I\u0027m not going to block on this if you disagree. I do support the overall change to move those tests here.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3ed6aed86ef998458d0909581ab3972792b619fa","unresolved":false,"context_lines":[{"line_number":2789,"context_line":"        self.assertIsNotNone(service[\u0027id\u0027])"},{"line_number":2790,"context_line":"        for key, value in self._get_base_values().iteritems():"},{"line_number":2791,"context_line":"            self.assertEqual(value, service[key])"},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_2f95bb86","line":2792,"in_reply_to":"1a6ced46_c9af632a","updated":"2015-03-26 11:41:39.000000000","message":"Hum.. yes this make sense, let me verify that point.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c8aeb35cab62736dc46fa63adca214d47722c745","unresolved":false,"context_lines":[{"line_number":2789,"context_line":"        self.assertIsNotNone(service[\u0027id\u0027])"},{"line_number":2790,"context_line":"        for key, value in self._get_base_values().iteritems():"},{"line_number":2791,"context_line":"            self.assertEqual(value, service[key])"},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_bb17cd50","line":2792,"in_reply_to":"9a80dd14_5ad7efbe","updated":"2015-03-23 08:42:47.000000000","message":"The tests are doing a little bit more, they create a service in database then fetch and verify that the service is considered enable or disable which is something important since other services are looking into the database to check that condition.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b3733997144bbc93b861605c733565a53b0be961","unresolved":false,"context_lines":[{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2796,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2797,"context_line":"        self.assertFalse(ref[\u0027disabled\u0027])"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3a6ebb2f","line":2796,"updated":"2015-03-20 12:25:41.000000000","message":"Why this extra call? The create call already return the result so could as well do the assert on that.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c8aeb35cab62736dc46fa63adca214d47722c745","unresolved":false,"context_lines":[{"line_number":2793,"context_line":"    def test_service_create_enable_new_services_true(self):"},{"line_number":2794,"context_line":"        self.flags(enable_new_services\u003dTrue)"},{"line_number":2795,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2796,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2797,"context_line":"        self.assertFalse(ref[\u0027disabled\u0027])"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_1b2f01a3","line":2796,"in_reply_to":"9a80dd14_3a6ebb2f","updated":"2015-03-23 08:42:47.000000000","message":"We want to be sure when we retrieve data the service is well enable or  disable.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"23b2699d1a5a9fe8e8c61ed8aa3a809f955f3681","unresolved":false,"context_lines":[{"line_number":2796,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2797,"context_line":"        self.assertFalse(ref[\u0027disabled\u0027])"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"},{"line_number":2800,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":2801,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2802,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_50b644dd","line":2799,"updated":"2015-04-20 09:06:32.000000000","message":"@Hans I see, so you addressed this on 19455514d. sometimes is better to rebase work on top of something else instead of just pick part of code from other contributors.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"0b542c06d2e0f48ece30bbb0bfbe9a3f3a6a571e","unresolved":false,"context_lines":[{"line_number":2796,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2797,"context_line":"        self.assertFalse(ref[\u0027disabled\u0027])"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"},{"line_number":2800,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":2801,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2802,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_bbdb41ed","line":2799,"in_reply_to":"dac4157f_50b644dd","updated":"2015-04-20 09:45:43.000000000","message":"I\u0027m truly sorry about that, but my patch actually predates yours by several months so it wasn\u0027t like I picked anything from your patch. I would have been more than happy to rebase had this merged before mine.\n\nIn retrospect, I should have rebased no matter what when you uploaded your patch, because it probably should have been in its own patch to begin with.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f3de6e7add727d891a2d3d11d076a56146efa7e9","unresolved":false,"context_lines":[{"line_number":2796,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2797,"context_line":"        self.assertFalse(ref[\u0027disabled\u0027])"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"},{"line_number":2800,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":2801,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2802,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_9173b94d","line":2799,"in_reply_to":"dac4157f_bbdb41ed","updated":"2015-04-23 07:15:56.000000000","message":"No worries","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b3733997144bbc93b861605c733565a53b0be961","unresolved":false,"context_lines":[{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"},{"line_number":2800,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":2801,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2802,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2803,"context_line":"        self.assertTrue(ref[\u0027disabled\u0027])"},{"line_number":2804,"context_line":""},{"line_number":2805,"context_line":"    def test_service_destroy(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ba61cb3a","line":2802,"updated":"2015-03-20 12:25:41.000000000","message":"Same here about the extra call.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c8aeb35cab62736dc46fa63adca214d47722c745","unresolved":false,"context_lines":[{"line_number":2799,"context_line":"    def test_service_create_enable_new_services_false(self):"},{"line_number":2800,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":2801,"context_line":"        srv \u003d self._create_service({})"},{"line_number":2802,"context_line":"        ref \u003d db.service_get(context.get_admin_context(), srv[\u0027id\u0027])"},{"line_number":2803,"context_line":"        self.assertTrue(ref[\u0027disabled\u0027])"},{"line_number":2804,"context_line":""},{"line_number":2805,"context_line":"    def test_service_destroy(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_bb498d8d","line":2802,"in_reply_to":"9a80dd14_ba61cb3a","updated":"2015-03-23 08:42:47.000000000","message":"Same response here.","commit_id":"0d71cc54b2dcb2ca4463f1e738399acfb4f239f5"}],"nova/tests/unit/test_service.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"e2cef7e894defd46014a7d46c3052328225ff4da","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual(25, CONF.service_down_time)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class ServiceTestCase(test.TestCase):"},{"line_number":94,"context_line":"    \"\"\"Test cases for Services.\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_6f302857","line":93,"updated":"2015-05-06 21:21:08.000000000","message":"How does this change reflect the commit message?","commit_id":"0903962e4eb23cf9bfc38992668409a3022286f1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f8fcfa3880a154277d3fe1a5d4b901dc56003872","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual(25, CONF.service_down_time)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class ServiceTestCase(test.TestCase):"},{"line_number":94,"context_line":"    \"\"\"Test cases for Services.\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_3dbecad4","line":93,"in_reply_to":"1aca2d91_6f302857","updated":"2015-05-07 14:01:30.000000000","message":"Well with the time it looks all of what i have changed has been introduced by other commits","commit_id":"0903962e4eb23cf9bfc38992668409a3022286f1"}]}