)]}'
{"doc/source/devref/api_microversions.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c19b845287b95d2637e38522cfe41246c2059861","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def show(self, req, id):"},{"line_number":93,"context_line":"    .... stuff ...."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if req.ver_obj.matches(start_version, end_version):"},{"line_number":96,"context_line":"      .... Do version specific stuff ...."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ....  stuff ...."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_d30ad31e","line":95,"updated":"2015-03-16 11:27:05.000000000","message":"Actually I think this is similar to use decorator for inner method. The decorator is also used to declaration. We should declare each version explictly.\n\nAnd this is similar to https://review.openstack.org/156450","commit_id":"a9fcb55c2bd9110df1636f5ecf2455d6a3d107db"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"22d84099a7aa1d43ea898d84c88b233b9c8b54ed","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def show(self, req, id):"},{"line_number":93,"context_line":"    .... stuff ...."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if req.ver_obj.matches(start_version, end_version):"},{"line_number":96,"context_line":"      .... Do version specific stuff ...."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ....  stuff ...."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_3e81c64d","line":95,"in_reply_to":"9a80dd14_805b9184","updated":"2015-03-18 09:00:18.000000000","message":"I don\u0027t think there\u0027s any bad side-effects to worry about. It\u0027s just a question of which style people prefer. I\u0027d be happy to say either inline checks or decorated private methods are fine, depending on the situation one or other might be more appropriate.\n\nSo, I\u0027m -1 on this patch, and +1 on https://review.openstack.org/156450","commit_id":"a9fcb55c2bd9110df1636f5ecf2455d6a3d107db"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5b29d301488d4246834535b07542091ca3fea5ed","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def show(self, req, id):"},{"line_number":93,"context_line":"    .... stuff ...."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if req.ver_obj.matches(start_version, end_version):"},{"line_number":96,"context_line":"      .... Do version specific stuff ...."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ....  stuff ...."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_805b9184","line":95,"in_reply_to":"9a80dd14_d30ad31e","updated":"2015-03-16 16:39:27.000000000","message":"yes, but this will introduce very complex code management effort if we keep evoluation\n\nif we create a internal-function and compare the version inside it\nwhat\u0027s the side effect it can lead to from microversion perspective?","commit_id":"a9fcb55c2bd9110df1636f5ecf2455d6a3d107db"}]}