)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"cd0078cf8d1000325904b36402c4a100506e8853","unresolved":false,"context_lines":[{"line_number":16,"context_line":"alert. However, context is not _actually_ part of the on-the-wire API,"},{"line_number":17,"context_line":"as it is stripped out on the caller side, and re-added on the callee side"},{"line_number":18,"context_line":"(hence why we\u0027re making this change in the first place). If the test had"},{"line_number":19,"context_line":"been uuber-pedantic to exclude context from consideration, then the hashes"},{"line_number":20,"context_line":"would not be changing here, but alas."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In short, the hash changes are false alarms and do not mean we need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_7777053c","line":19,"updated":"2015-03-17 17:05:26.000000000","message":"Like *really* uber","commit_id":"82d8a0d06469716b22d78ff018b4ae2263b00961"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d408a6db506650e6024bc6225b3e896bd213d80","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        self.assertIsInstance(thing2[\u0027foo\u0027], base.NovaObject)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"# NOTE(danms): The hashes in this list should only be changed if"},{"line_number":1175,"context_line":"# they come with a corresponding version bump in the affected"},{"line_number":1176,"context_line":"# objects"},{"line_number":1177,"context_line":"object_data \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_bb9171f3","line":1174,"updated":"2015-03-17 14:54:29.000000000","message":"Given this, why are all of the hashes being updated w/o a version bump?","commit_id":"45ca336670fea8e788e15aec679523cac1f4c5af"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f481fd33d870b70b9e5c0ce68c25612dde9b035","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        self.assertIsInstance(thing2[\u0027foo\u0027], base.NovaObject)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"# NOTE(danms): The hashes in this list should only be changed if"},{"line_number":1175,"context_line":"# they come with a corresponding version bump in the affected"},{"line_number":1176,"context_line":"# objects"},{"line_number":1177,"context_line":"object_data \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5e0dc336","line":1174,"in_reply_to":"9a80dd14_bb9171f3","updated":"2015-03-17 14:57:12.000000000","message":"Well, because the hashing algorithm just hashes all the arguments to the functions. It does this to detect if you add or remove a parameter and are in need of a bump. However, it doesn\u0027t exclude context from that list, even though it\u0027s not part of the actual on-the-wire API. If it did, then we wouldn\u0027t need to change these hashes.\n\nI can put something like the above in the commit message if you think it\u0027s warranted. Probably is.","commit_id":"45ca336670fea8e788e15aec679523cac1f4c5af"}]}