)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9c49815a4998d8de71ceb04373530e94575e27d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Nikitin \u003csnikitin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-24 14:16:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removed unused variables, methods and classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Author: Pavel Kholkin \u003cpkholkin@mirantis.com\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab921fb_1e0650ce","line":7,"updated":"2015-04-24 11:27:06.000000000","message":"This is a little confusing. In most of the cases the variable are used, just not in the scope that they are declared.\nIn other cases there may be a variable that is declared twice (inline comment)\nIt would be easier to break this into smaller tasks\n\nIf you are using a tool to determine this then why not have that run as part of the pep8","commit_id":"e9fcf43b6f311cdb9f8d3cbe171c75eafea3978b"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"d31476304f8b11fd91190e88788b13d374a09bdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Nikitin \u003csnikitin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-24 14:16:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removed unused variables, methods and classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Author: Pavel Kholkin \u003cpkholkin@mirantis.com\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab921fb_7ef42c86","line":7,"in_reply_to":"bab921fb_1e0650ce","updated":"2015-04-24 11:34:01.000000000","message":"Thank you, garyk! I\u0027ll split the patch.\n\nTo find these variables, I used PyCharm\u0027s code inspector, so I don\u0027t think it could be a part the pep8","commit_id":"e9fcf43b6f311cdb9f8d3cbe171c75eafea3978b"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"b8c89204c430dd784540dd81b7c795c60237c41d","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _extract_bdm(self, server_dict):"},{"line_number":387,"context_line":"        legacy_bdm \u003d True"},{"line_number":388,"context_line":"        block_device_mapping \u003d None"},{"line_number":389,"context_line":"        block_device_mapping_v2 \u003d None"},{"line_number":390,"context_line":"        if not self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":391,"context_line":"            return legacy_bdm, None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_afd70fed","line":388,"updated":"2015-03-19 08:25:06.000000000","message":"Nice catch!\nI agree with you that I should remove \u0027block_device_mapping\u0027 but I disagree with you that I should remove \u0027block_device_mapping_v2\u0027 because...","commit_id":"9795991ac5ae79aa232cf33fe4cb5a6428cc1c47"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"f9a4b928130ce36ce865ce3cd75e1697094c666e","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _extract_bdm(self, server_dict):"},{"line_number":387,"context_line":"        legacy_bdm \u003d True"},{"line_number":388,"context_line":"        block_device_mapping \u003d None"},{"line_number":389,"context_line":"        block_device_mapping_v2 \u003d None"},{"line_number":390,"context_line":"        if not self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":391,"context_line":"            return legacy_bdm, None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5a291d36","line":388,"updated":"2015-03-18 12:40:28.000000000","message":"This and below assignments also should be removed","commit_id":"9795991ac5ae79aa232cf33fe4cb5a6428cc1c47"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"e1dd0691939fac1f5d7b0877cf5d1dc0e486a637","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _extract_bdm(self, server_dict):"},{"line_number":387,"context_line":"        legacy_bdm \u003d True"},{"line_number":388,"context_line":"        block_device_mapping \u003d None"},{"line_number":389,"context_line":"        block_device_mapping_v2 \u003d None"},{"line_number":390,"context_line":"        if not self.ext_mgr.is_loaded(\u0027os-volumes\u0027):"},{"line_number":391,"context_line":"            return legacy_bdm, None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b84e7336","line":388,"in_reply_to":"9a80dd14_afd70fed","updated":"2015-03-19 09:20:30.000000000","message":"Sure, you are right","commit_id":"9795991ac5ae79aa232cf33fe4cb5a6428cc1c47"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"b8c89204c430dd784540dd81b7c795c60237c41d","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        if self.ext_mgr.is_loaded(\u0027os-block-device-mapping-v2-boot\u0027):"},{"line_number":408,"context_line":"            # Consider the new data format for block device mapping"},{"line_number":409,"context_line":"            block_device_mapping_v2 \u003d server_dict.get("},{"line_number":410,"context_line":"                \u0027block_device_mapping_v2\u0027, [])"},{"line_number":411,"context_line":"            # NOTE (ndipanov):  Disable usage of both legacy and new"},{"line_number":412,"context_line":"            #                   block device format in the same request"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6fdb57ed","line":409,"updated":"2015-03-19 08:25:06.000000000","message":"... this is the only line when \u0027block_device_mapping_v2\u0027 is getting a value.","commit_id":"9795991ac5ae79aa232cf33fe4cb5a6428cc1c47"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"b8c89204c430dd784540dd81b7c795c60237c41d","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    for bdm_dict in block_device_mapping_v2]"},{"line_number":429,"context_line":"            except exception.InvalidBDMFormat as e:"},{"line_number":430,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        bdm \u003d (block_device_mapping or block_device_mapping_v2)"},{"line_number":433,"context_line":"        return legacy_bdm, bdm"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_4fd3f3d4","line":431,"updated":"2015-03-19 08:25:06.000000000","message":"But we use this variable here. and if \"if\" condition will be False, block_device_mapping_v2 will be unassigned here","commit_id":"9795991ac5ae79aa232cf33fe4cb5a6428cc1c47"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9c49815a4998d8de71ceb04373530e94575e27d","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    vmdk_controller_key \u003d None"},{"line_number":543,"context_line":"    disk_type \u003d None"},{"line_number":544,"context_line":"    capacity_in_bytes \u003d 0"},{"line_number":545,"context_line":"    vmdk_device \u003d None"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    # Determine if we need to get the details of the root disk"},{"line_number":548,"context_line":"    root_disk \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab921fb_9edee06b","side":"PARENT","line":545,"updated":"2015-04-24 11:27:06.000000000","message":"this is actually not an unused variable it is a duplicate one. can you please add that to the commit message","commit_id":"f1d215315a63afd813b7ae7623027fbf39017fb5"}]}