)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"521de4d1000fb4601c01b70364734d161e7e49b8","unresolved":false,"context_lines":[{"line_number":3145,"context_line":"            self.driver.snapshot(context, instance, image_id,"},{"line_number":3146,"context_line":"                                 update_task_state)"},{"line_number":3147,"context_line":""},{"line_number":3148,"context_line":"            instance.task_state \u003d None"},{"line_number":3149,"context_line":"            instance.save(expected_task_state\u003dtask_states.IMAGE_UPLOADING)"},{"line_number":3150,"context_line":""},{"line_number":3151,"context_line":"            self._notify_about_instance_usage(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_48826d50","side":"PARENT","line":3148,"updated":"2015-03-23 20:38:38.000000000","message":"I don\u0027t see anything wrong with this.","commit_id":"78184463ba30b842687d52e824e9c203e9822d90"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"27605585283e17f3c34de31e0dcc54f0adeafcbf","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"                                 update_task_state)"},{"line_number":3147,"context_line":""},{"line_number":3148,"context_line":"            instance.task_state \u003d None"},{"line_number":3149,"context_line":"            instance.save(expected_task_state\u003dtask_states.IMAGE_UPLOADING)"},{"line_number":3150,"context_line":""},{"line_number":3151,"context_line":"            self._notify_about_instance_usage(context, instance,"},{"line_number":3152,"context_line":"                                              \"snapshot.end\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ec5a5e29","side":"PARENT","line":3149,"updated":"2015-03-17 11:43:41.000000000","message":"I actually prefer this over the proposed change.","commit_id":"78184463ba30b842687d52e824e9c203e9822d90"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"27605585283e17f3c34de31e0dcc54f0adeafcbf","unresolved":false,"context_lines":[{"line_number":3137,"context_line":"            self._notify_about_instance_usage("},{"line_number":3138,"context_line":"                context, instance, \"snapshot.start\")"},{"line_number":3139,"context_line":""},{"line_number":3140,"context_line":"            def update_task_state(task_state,"},{"line_number":3141,"context_line":"                                  expected_state\u003dexpected_task_state):"},{"line_number":3142,"context_line":"                instance.task_state \u003d task_state"},{"line_number":3143,"context_line":"                instance.save(expected_task_state\u003dexpected_state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_8cfd620b","line":3140,"updated":"2015-03-17 11:43:41.000000000","message":"I don\u0027t see this currently being used outside of this change. I would propose instead we remove it and save 4 lines of code.","commit_id":"9740603813be3a0c6408a83c056b0b6d8a193117"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d40524a9cce526e356921586ac64fce0e6ec17dd","unresolved":false,"context_lines":[{"line_number":3137,"context_line":"            self._notify_about_instance_usage("},{"line_number":3138,"context_line":"                context, instance, \"snapshot.start\")"},{"line_number":3139,"context_line":""},{"line_number":3140,"context_line":"            def update_task_state(task_state,"},{"line_number":3141,"context_line":"                                  expected_state\u003dexpected_task_state):"},{"line_number":3142,"context_line":"                instance.task_state \u003d task_state"},{"line_number":3143,"context_line":"                instance.save(expected_task_state\u003dexpected_state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ff81e34d","line":3140,"in_reply_to":"9a80dd14_8cfd620b","updated":"2015-03-18 12:09:06.000000000","message":"in fact, we pass this to all drivers at L3146.","commit_id":"9740603813be3a0c6408a83c056b0b6d8a193117"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"e83168bbe7106bdb31957e97bc696566aa5c184f","unresolved":false,"context_lines":[{"line_number":3137,"context_line":"            self._notify_about_instance_usage("},{"line_number":3138,"context_line":"                context, instance, \"snapshot.start\")"},{"line_number":3139,"context_line":""},{"line_number":3140,"context_line":"            def update_task_state(task_state,"},{"line_number":3141,"context_line":"                                  expected_state\u003dexpected_task_state):"},{"line_number":3142,"context_line":"                instance.task_state \u003d task_state"},{"line_number":3143,"context_line":"                instance.save(expected_task_state\u003dexpected_state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_adcb85a2","line":3140,"in_reply_to":"9a80dd14_ff81e34d","updated":"2015-03-19 14:37:27.000000000","message":"Sorry, missed that one. Still, I don\u0027t think this makes the code read any clearer. You will see most of the object updates look like the existing one. This inline method has a special purpose as it is being passed to the driver and I don\u0027t think we should overload its usage.","commit_id":"9740603813be3a0c6408a83c056b0b6d8a193117"}]}