)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6385b0f3653a833bd3ddda8606635a541c235fea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger than 2**31 -1,"},{"line_number":10,"context_line":"there will be a DBError. The maximum limit needs to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idf890c57342378d0a71f6b18eb42425d463b13ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_2f17d052","line":9,"updated":"2015-05-06 21:34:47.000000000","message":"Is this true for both mysql and postgres?","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"30f34c7c3c8a55972046c97f4decbe4125b93488","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger than 2**31 -1,"},{"line_number":10,"context_line":"there will be a DBError. The maximum limit needs to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idf890c57342378d0a71f6b18eb42425d463b13ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa32b979_d7ad8deb","line":9,"in_reply_to":"1aca2d91_2f17d052","updated":"2015-06-26 08:29:58.000000000","message":"Yes","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"65df2c3bab9ddbe3e67e5a837fb0ce313e79f3f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger than 2**31 -1,"},{"line_number":10,"context_line":"there will be a DBError. The maximum limit needs to be validated."},{"line_number":11,"context_line":"And the maximum value is defined by SQL integer type INT, which"},{"line_number":12,"context_line":"is a general value:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba3cc151_9b965c93","line":9,"updated":"2015-06-29 08:40:25.000000000","message":"my only concern with this is that if someone is using a different backend for the DB - that is pluggable as we all know. But I think that this is a something that addresses the issue well","commit_id":"cee0247a06e29ca959772509c043866c6cd3313a"}],"nova/api/openstack/compute/contrib/quotas.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0d19a9b25cac91047974d4f1d8e7495340912edb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":70,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":71,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."},{"line_number":72,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":75,"context_line":"                     \"must be in the range of -1 to %(max)s.\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_6823b706","line":72,"updated":"2015-03-26 14:14:10.000000000","message":"It makes sense to have a max value in all cases. thanks","commit_id":"f2ce3a4b4ecf74b1fb61ca24696f3fabf8a961b8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d07b830e24c649675f36da85fd56b8b17f34d900","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":75,"context_line":"                     \"must be in the range of -1 to %(max)s.\") %"},{"line_number":76,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"},{"line_number":77,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_7b180c85","line":75,"updated":"2015-03-30 05:38:56.000000000","message":"i am not sure what the policy is with changing strings but I was asked to defer changing of messages to L.\nSo can you please may consider not changing this.","commit_id":"f2ce3a4b4ecf74b1fb61ca24696f3fabf8a961b8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"956d8d284b9d94a9db2af3a81166ec1599c38608","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":75,"context_line":"                     \"must be in the range of -1 to %(max)s.\") %"},{"line_number":76,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"},{"line_number":77,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_9dc5dc3d","line":75,"in_reply_to":"da9b358b_7b180c85","updated":"2015-04-14 07:03:17.000000000","message":"Done","commit_id":"f2ce3a4b4ecf74b1fb61ca24696f3fabf8a961b8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1eeb7cd04451050bd8d7e70b9077ae6149eca72e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":68,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":69,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":70,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":71,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_c0d7f7bd","line":68,"updated":"2015-04-14 07:44:38.000000000","message":"It\u0027s not necessary to use the prefix NOTE so you can probably remove it since you are updating the code.","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"30f34c7c3c8a55972046c97f4decbe4125b93488","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":68,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":69,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":70,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":71,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_173f7588","line":68,"in_reply_to":"7aaa499b_c0d7f7bd","updated":"2015-06-26 08:29:58.000000000","message":"Done","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"79a3016fae08d7379606caab78176d3bede0feb3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":72,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":73,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":74,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":75,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":76,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":77,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_6b92984d","line":74,"updated":"2015-06-26 09:57:22.000000000","message":"Can we use DB \u0027MAX_INT\u0027 value here? https://github.com/openstack/nova/blob/master/nova/db/api.py#L61","commit_id":"b1a363874719692e143095010b52dbf4ac5b5aea"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c561822674b0879269d77f484d712413beb21b8c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":72,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":73,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":74,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":75,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":76,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":77,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_66f8aa7d","line":74,"in_reply_to":"fa32b979_6b92984d","updated":"2015-06-29 01:43:26.000000000","message":"Done","commit_id":"b1a363874719692e143095010b52dbf4ac5b5aea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"caf053f7309248125f068d8b584e777711ca0d84","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":75,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":76,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":77,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":78,"context_line":"                     \"must be -1 or greater.\") %"},{"line_number":79,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource})"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c008732b","line":77,"updated":"2015-06-29 08:05:46.000000000","message":"the message needs to be updated here. say I have a number that is greater than db.MAX_INT then the message will certainly be confusing","commit_id":"2fb3a59c0995543fdd3b7ac4260c5b063dea9b84"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ca646a410a75e2c272b99756e296e5d2f2d553c1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":75,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":76,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":77,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":78,"context_line":"                     \"must be -1 or greater.\") %"},{"line_number":79,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource})"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_fb0d2838","line":77,"in_reply_to":"ba3cc151_c008732b","updated":"2015-06-29 08:38:17.000000000","message":"Done","commit_id":"2fb3a59c0995543fdd3b7ac4260c5b063dea9b84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9be7d021f7857b0aadb8b097660f3b74f7b5b587","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":68,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":69,"context_line":"        if limit \u003c -1:"},{"line_number":70,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":71,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_a768dabb","side":"PARENT","line":68,"updated":"2015-06-29 13:38:47.000000000","message":"nit: you don\u0027t need to remove the NOTE prefix.","commit_id":"6969f270c5035325c603ce7a98b1647b72bf5eaa"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3f19bf15602a7a2a6906d57034ae914a2c24f603","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":68,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":69,"context_line":"        if limit \u003c -1:"},{"line_number":70,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":71,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_5904527d","side":"PARENT","line":68,"in_reply_to":"ba3cc151_a768dabb","updated":"2015-06-29 14:03:40.000000000","message":"Done","commit_id":"6969f270c5035325c603ce7a98b1647b72bf5eaa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9be7d021f7857b0aadb8b097660f3b74f7b5b587","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":73,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":74,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":75,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":76,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":77,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":78,"context_line":"                     \"must be in the range of -1 and %(max)s.\") %"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_47a0eef4","line":75,"updated":"2015-06-29 13:38:47.000000000","message":"nit: you probably don\u0027t need a separate variable for maxvalue given db.MAX_INT is a constant.","commit_id":"992df34f9a2d7d6330698c513005ddf6740383fd"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3f19bf15602a7a2a6906d57034ae914a2c24f603","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":73,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":74,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":75,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":76,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":77,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":78,"context_line":"                     \"must be in the range of -1 and %(max)s.\") %"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_b9d8fe1e","line":75,"in_reply_to":"ba3cc151_47a0eef4","updated":"2015-06-29 14:03:40.000000000","message":"Done","commit_id":"992df34f9a2d7d6330698c513005ddf6740383fd"}],"nova/api/openstack/compute/plugins/v3/quota_sets.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d07b830e24c649675f36da85fd56b8b17f34d900","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":64,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":65,"context_line":"                     \"must be in the range of -1 to %(max)s.\") %"},{"line_number":66,"context_line":"                     {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"},{"line_number":67,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        def conv_inf(value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_1b17c052","line":66,"updated":"2015-03-30 05:38:56.000000000","message":"same point as before","commit_id":"f2ce3a4b4ecf74b1fb61ca24696f3fabf8a961b8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"956d8d284b9d94a9db2af3a81166ec1599c38608","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":64,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":65,"context_line":"                     \"must be in the range of -1 to %(max)s.\") %"},{"line_number":66,"context_line":"                     {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"},{"line_number":67,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        def conv_inf(value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_dd4004a8","line":66,"in_reply_to":"da9b358b_1b17c052","updated":"2015-04-14 07:03:17.000000000","message":"Done","commit_id":"f2ce3a4b4ecf74b1fb61ca24696f3fabf8a961b8"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6385b0f3653a833bd3ddda8606635a541c235fea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":53,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":54,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."},{"line_number":55,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":56,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":57,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":58,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_ca1dea67","line":55,"updated":"2015-05-06 21:34:47.000000000","message":"Calculating this value here sounds like it will be a problem down the road, since it is DB specific but not in the db code.","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"30f34c7c3c8a55972046c97f4decbe4125b93488","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":53,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":54,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."},{"line_number":55,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":56,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":57,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":58,"context_line":"                     \"must be -1 or greater.\") %"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_5735fda5","line":55,"in_reply_to":"1aca2d91_ca1dea67","updated":"2015-06-26 08:29:58.000000000","message":"It is defined by INT, so this value will not change only if we change the db model to other integer type like BIGINT.","commit_id":"be29363b7196060f767505a621c83af986cab487"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"caf053f7309248125f068d8b584e777711ca0d84","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":58,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":59,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":60,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":61,"context_line":"                     \"must be -1 or greater.\") %"},{"line_number":62,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource})"},{"line_number":63,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e00d7738","line":60,"updated":"2015-06-29 08:05:46.000000000","message":"ditto","commit_id":"2fb3a59c0995543fdd3b7ac4260c5b063dea9b84"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ca646a410a75e2c272b99756e296e5d2f2d553c1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":58,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":59,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":60,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":61,"context_line":"                     \"must be -1 or greater.\") %"},{"line_number":62,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource})"},{"line_number":63,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_bb37a0e2","line":60,"in_reply_to":"ba3cc151_e00d7738","updated":"2015-06-29 08:38:17.000000000","message":"Done","commit_id":"2fb3a59c0995543fdd3b7ac4260c5b063dea9b84"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5b440de3f9f8ab2d1db0ce5fe443474b4808e4c3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":57,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":58,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":59,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":60,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":61,"context_line":"                     \"must be in the range of -1 and %(max)s.\") %"},{"line_number":62,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_794fd692","line":59,"updated":"2015-06-29 14:09:30.000000000","message":"I think this check is useless for v2.1 API. Because it already done by JSON-Schema","commit_id":"439d121e00544914dfc232be2251bd6a8fe39f6a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"39e4cab6638396f943676f4c7e71c3df9bb5f707","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":57,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":58,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":59,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":60,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":61,"context_line":"                     \"must be in the range of -1 and %(max)s.\") %"},{"line_number":62,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_3273a3b3","line":59,"in_reply_to":"ba3cc151_2faa60d5","updated":"2015-06-29 14:48:37.000000000","message":"Done","commit_id":"439d121e00544914dfc232be2251bd6a8fe39f6a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d325e09a3e6bc266639802933bfa550227511add","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":57,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":58,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":59,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":60,"context_line":"            msg \u003d (_(\"Quota limit %(limit)s for %(resource)s \""},{"line_number":61,"context_line":"                     \"must be in the range of -1 and %(max)s.\") %"},{"line_number":62,"context_line":"                   {\u0027limit\u0027: limit, \u0027resource\u0027: resource, \u0027max\u0027: maxvalue})"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_2faa60d5","line":59,"in_reply_to":"ba3cc151_794fd692","updated":"2015-06-29 14:29:49.000000000","message":"+1, I was just about to comment the same.  I\u0027d think we could remove this method altogether right?","commit_id":"439d121e00544914dfc232be2251bd6a8fe39f6a"}],"nova/api/openstack/compute/schemas/v3/quota_sets.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"16b52be235540e315ddba0eaec460013503c9870","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0027pattern\u0027: \u0027^-?[0-9]+$\u0027,"},{"line_number":23,"context_line":"    # -1 is a flag value for unlimited"},{"line_number":24,"context_line":"    \u0027minimum\u0027: -1,"},{"line_number":25,"context_line":"    \u0027maximum\u0027: db.MAX_INT"},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"quota_resources \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_6bb5cc2f","line":25,"updated":"2015-07-16 16:20:29.000000000","message":"How is this not a merge conflict with this?\n\nhttps://review.openstack.org/#/c/193132/1/nova/api/openstack/compute/schemas/v3/quota_sets.py","commit_id":"19c01509ca261c1153fefb447305c0a31740b712"}],"nova/tests/unit/api/openstack/compute/contrib/test_quotas.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9be7d021f7857b0aadb8b097660f3b74f7b5b587","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # Invalid - limit is larger than 2147483647"},{"line_number":171,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":172,"context_line":"                          self.controller._validate_quota_limit,"},{"line_number":173,"context_line":"                          resource, 2147483648, -1, -1)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def test_quotas_defaults(self):"},{"line_number":176,"context_line":"        uri \u003d \u0027/v2/fake_tenant/os-quota-sets/fake_tenant/defaults\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_2705aac1","line":173,"updated":"2015-06-29 13:38:47.000000000","message":"I\u0027d just do db.MAX_INT + 1.","commit_id":"992df34f9a2d7d6330698c513005ddf6740383fd"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3f19bf15602a7a2a6906d57034ae914a2c24f603","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # Invalid - limit is larger than 2147483647"},{"line_number":171,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":172,"context_line":"                          self.controller._validate_quota_limit,"},{"line_number":173,"context_line":"                          resource, 2147483648, -1, -1)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def test_quotas_defaults(self):"},{"line_number":176,"context_line":"        uri \u003d \u0027/v2/fake_tenant/os-quota-sets/fake_tenant/defaults\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_b946bebd","line":173,"in_reply_to":"ba3cc151_2705aac1","updated":"2015-06-29 14:03:40.000000000","message":"Done","commit_id":"992df34f9a2d7d6330698c513005ddf6740383fd"}]}