)]}'
{"id":"openstack%2Fnova~16507","triplet_id":"openstack%2Fnova~master~I73bb2905577fb6f727c0a805df2654ad1bb4ad72","project":"openstack/nova","branch":"master","topic":"bug/1080284","hashtags":[],"change_id":"I73bb2905577fb6f727c0a805df2654ad1bb4ad72","subject":"Map cinder snapshot statuses to ec2.","status":"MERGED","created":"2012-11-20 06:11:34.000000000","updated":"2012-12-11 17:58:18.000000000","submitted":"2012-12-11 17:58:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8ad78db14091a8217e977e8e186becb2a51bb31e","_number":16507,"virtual_id_number":16507,"owner":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2012-12-11 17:58:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-12-11 17:22:08.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-12-11 00:13:54.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-12-11 17:22:08.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-12-11 00:13:54.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-07 22:06:53.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-12-08 05:10:09.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2012-12-08 20:06:40.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2012-12-10 16:09:55.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2012-12-11 00:13:54.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-12-11 17:22:08.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-12-11 17:58:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4c05c5576076f3b48c71d087145afcacc670feb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-20 06:32:42.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/1/check/gate-nova-merge/12495 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-nova-docs/8226 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-nova-pep8/13536 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-nova-python26/9676 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-nova-python27/9746 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-tempest-devstack-vm/19259 : SUCCESS\n- http://logs.openstack.org/16507/1/check/gate-nova-pylint/3241 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"12aee107b1dbef85c3f2fbb29f4e83b16c0aa649","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-20 06:41:22.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/48906\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/48904\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/48905\n","accounts_in_message":[],"_revision_number":1},{"id":"cab1aa0c40840619a526213760da08e3005eb81e","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-20 08:06:51.000000000","message":"Patch Set 1: (2 inline comments)\n\nI have some concerns.","accounts_in_message":[],"_revision_number":1},{"id":"9883e7b7e8059038dc9867a15cd1c7c0a75a4bf8","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-20 08:23:24.000000000","message":"Patch Set 1: (1 inline comment)\n\n\"exclude them from the listing\" I refereed to the whole record. Pretend it does not exists.\n\nThe \u0027pending\u0027 looks correct behavior if the cinder counts the deleted snapshots into the quota.\n\nProbably the excluding is the correct behavior otherwise.","accounts_in_message":[],"_revision_number":1},{"id":"17e5ef2edb62c26858743c66f61e77e13d8365b1","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-20 20:45:27.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"5303e5ebb61a79bfcc6e84d1cac918d651cdc726","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-20 23:22:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5b610388fcdd8bdc3c887f19fa29cc77c902fdb4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-20 23:50:42.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/2/check/gate-nova-merge/12555 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-nova-docs/8286 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-nova-pep8/13596 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-nova-python26/9736 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-nova-python27/9806 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-tempest-devstack-vm/19395 : SUCCESS\n- http://logs.openstack.org/16507/2/check/gate-nova-pylint/3285 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"9a0446c2348e25e71bea851fdba0cf46e93dbf66","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-21 00:26:35.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/49184\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/49182\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/49183\n","accounts_in_message":[],"_revision_number":2},{"id":"74a54b7d0110fef4f0b157d19c0b1d6e59e1061a","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-11-21 17:24:28.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"211197ed75b91307b13233dd6fc16e6dc8744156","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-11-21 23:56:47.000000000","message":"Patch Set 2:\n\nIs it possible to add some unit tests for this?","accounts_in_message":[],"_revision_number":2},{"id":"75511911bd9c6912dcdb555c73978ba974c89af7","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-22 05:02:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2e559df54c774c40b42a2ba8949dc62051f2aee8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-22 05:25:20.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/3/check/gate-nova-merge/12763 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-nova-docs/8494 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-nova-pep8/13804 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-nova-python26/9944 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-nova-python27/10014 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-tempest-devstack-vm/19697 : SUCCESS\n- http://logs.openstack.org/16507/3/check/gate-nova-pylint/3463 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"279fe17da742fedc6fa69ea5887df5a40e888bfa","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-22 05:38:07.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/49752\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/49750\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/49751\n","accounts_in_message":[],"_revision_number":3},{"id":"61ca5896a3e5cfaeca02faf18cf8a0aad984da3b","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-22 10:02:49.000000000","message":"Patch Set 3: (1 inline comment)\n\nThank you. \nLooks like it will work.\nCan you update the NOTE ?","accounts_in_message":[],"_revision_number":3},{"id":"d72b28ae584883dc82061bc5a4a4a5431c8c708b","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-22 20:08:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"fdf5c0fdaf30d40da4e289928b77235ebb591d97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-22 20:31:21.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/4/check/gate-nova-merge/12802 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-nova-docs/8532 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-nova-pep8/13842 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-nova-python26/9982 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-nova-python27/10052 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-tempest-devstack-vm/19780 : SUCCESS\n- http://logs.openstack.org/16507/4/check/gate-nova-pylint/3486 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"bc4793888077923e38d2682e5fd91468db5a8643","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-22 20:38:50.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/49897\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/49895\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/49896\n","accounts_in_message":[],"_revision_number":4},{"id":"c125cea0d19bb4a410a4f804116c37fdd0e880bf","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-11-26 23:06:01.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"9f71101faac0f05a996b50bdecbd1d93e454cd5a","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-27 15:57:20.000000000","message":"Patch Set 4:\n\nI almost forget about volume delete ability.\n\nFor consider the exclude as good mapping, the related volume must be delete able.","accounts_in_message":[],"_revision_number":4},{"id":"a138f79e702077aa7e884cc7a7f8d112fa4591a9","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-27 16:31:09.000000000","message":"Patch Set 4:\n\nAs I read:\n\nThe \u0027deleting\u0027 status calculated into the quota, and prevents volume deletion.\n\nThe \u0027deleted\u0027 not in the Quota or Volume deletion check.","accounts_in_message":[],"_revision_number":4},{"id":"f08d102d23a5e13483a5be55ef92a6c6955bd075","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-27 17:42:37.000000000","message":"Patch Set 4:\n\nLooks like the  handling \u0027deleted\u0027 is a bit confusing.\nThere is the \u0027deleted\u0027 attribute on the table, and the records excluded by cinder filtered by this. Probably when it set to true, the deleted_at attribute also got a value.\n \nThe \u0027deleted\u0027 status not excluded in most cases, just the records has the deleted\u003dtrue.","accounts_in_message":[],"_revision_number":4},{"id":"39bf4401b3916d47b5cd0b977dc92cd7e1277cea","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-11-28 09:01:53.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThe exclude is only good behavior, if in the specific state the resource does not consumes quote AND does not prevent deleting dependent resources. (I am investigating a similar case now)","accounts_in_message":[],"_revision_number":4},{"id":"8fbfc528d7424532d70d912aecbb0a496523d0f6","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-12-04 02:57:03.000000000","message":"Patch Set 4:\n\nI am confused. What do you want the two deleted states mapped to?","accounts_in_message":[],"_revision_number":4},{"id":"6c319b08c6935e5f3d5bb5783002f32bce8fc311","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-12-06 01:23:38.000000000","message":"Patch Set 4:\n\n\u0027deleting\u0027 --\u003e \u0027pending\u0027 - MUST\n\u0027deleted\u0027  I accept both \u0027pending\u0027 and exclude.\n\nDB records has a logical delete flag.\nIn cinder case it sets this flag at the same time as the status.\nThe snapshot listing as I remember not listing logically deleted ones.\n\nIn the in-line comment I described Why the \u0027pending\u0027 is the expected for deleting, and generally what is my expectations for ec2 snapshot status.\n\nI did not checked what does the cinder shows as status when snapshot is used for volume creation. And what its reaction when I try a concurrent delete. Now it is out of scope.","accounts_in_message":[],"_revision_number":4},{"id":"25dcdcf4c8978c9d9636ee623f3c24e363992e11","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-12-06 01:25:25.000000000","message":"Patch Set 4:\n\n\u0027deleting\u0027 --\u003e \u0027pending\u0027 \n------------------------------------\n\n\n\u0027deleted\u0027 I accept both \u0027pending\u0027 and exclude.\n----------------------------------------------","accounts_in_message":[],"_revision_number":4},{"id":"8625493045a6fed27287f2b71e7baf2481b0d747","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-12-07 21:39:21.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"08b261faa2e46ac160d6d86b6279895260e2f240","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-12-07 21:47:00.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"890bb477f56b89febb09bae6382a494ab807d091","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-07 22:06:53.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/53559\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/53557\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/53558\n","accounts_in_message":[],"_revision_number":5},{"id":"918de36cb27dd0f9c6509312a23107b3e831475a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-07 22:24:58.000000000","message":"Patch Set 5: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/5/check/gate-nova-merge/13588 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-nova-docs/9306 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-nova-pep8/14616 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-nova-python26/10754 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-nova-python27/10826 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-tempest-devstack-vm/21455 : SUCCESS\n- http://logs.openstack.org/16507/5/check/gate-nova-pylint/4025 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"db93fa57d4c6fdfbd289f7586be5b7057d86c003","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2012-12-08 05:10:09.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"f614c6431a2a88932584fc9a8c0aced8a17bf8e0","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2012-12-08 20:06:40.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":5},{"id":"134f4924c5f9a7ef428be12b338d0977563c1cb3","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-12-10 16:09:55.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\nLGTM,  except this should have a docImpact flag in the commit message, as the state mapping is relevant for users.","accounts_in_message":[],"_revision_number":5},{"id":"59ace00c3a0703e5cd80e2fc417f2ad63c9117f7","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-12-10 20:58:04.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ecea1fc24be5090911b0e485459e3ddddb4a59db","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-12-10 20:58:17.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"bd3f4f6fc1f0e855cf7440b415991ca03e2eadc7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-10 21:25:14.000000000","message":"Patch Set 6: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16507/6/check/gate-nova-merge/13682 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-nova-docs/9400 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-nova-pep8/14710 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-nova-python26/10848 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-nova-python27/10920 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-tempest-devstack-vm/21638 : SUCCESS\n- http://logs.openstack.org/16507/6/check/gate-nova-pylint/4096 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"92f5fb3aaa72995e67451115b82af9f68b751cfb","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-12-11 00:13:54.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"2694fe3cb5bfc5f1aae12566631465e27bc9f0a4","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-12-11 17:22:08.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"c2c8282125e115a80f88d925909d4c9ccb4be647","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-11 17:22:25.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":6},{"id":"e6a9a6f6c1bc5d19a107e3c57e8bae6885ff28b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-11 17:58:16.000000000","message":"Patch Set 6: Verified\n\nBuild successful\n\n- http://logs.openstack.org/16507/6/gate/gate-nova-merge/13775 : SUCCESS\n- http://logs.openstack.org/16507/6/gate/gate-nova-docs/9493 : SUCCESS\n- http://logs.openstack.org/16507/6/gate/gate-nova-pep8/14803 : SUCCESS\n- http://logs.openstack.org/16507/6/gate/gate-nova-python26/10941 : SUCCESS\n- http://logs.openstack.org/16507/6/gate/gate-nova-python27/11013 : SUCCESS\n- http://logs.openstack.org/16507/6/gate/gate-tempest-devstack-vm/21794 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"faa7eb3fa0f580d6b623578e935608e5745f2178","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-11 17:58:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"eed626753c23bb82453bc5176193831fbb9e538c","revisions":{"d33235ef074572d799cd9a08fc57b547ad01b3a5":{"kind":"REWORK","_number":1,"created":"2012-11-20 06:11:34.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/1"}}},"commit":{"parents":[{"commit":"98032e804aa442e1aad17723cab2ed163ee0c810","subject":"Merge \"Move db lookup for block device mappings.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/98032e804aa442e1aad17723cab2ed163ee0c810"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d33235ef074572d799cd9a08fc57b547ad01b3a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d33235ef074572d799cd9a08fc57b547ad01b3a5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"98032e804aa442e1aad17723cab2ed163ee0c810","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"4635118f7fc716e4d5b3230a6c9427cb89333fac":{"kind":"REWORK","_number":2,"created":"2012-11-20 23:22:44.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/2"}}},"commit":{"parents":[{"commit":"28b98725800378b41685c5b32965624ab1138f2b","subject":"Merge \"Fix os-hosts extension can\u0027t return xml response correctly.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/28b98725800378b41685c5b32965624ab1138f2b"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 23:22:22.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4635118f7fc716e4d5b3230a6c9427cb89333fac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4635118f7fc716e4d5b3230a6c9427cb89333fac"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"28b98725800378b41685c5b32965624ab1138f2b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d7ba7cade9c1ccd45e5447a2bdcb90c691780ab8":{"kind":"REWORK","_number":3,"created":"2012-11-22 05:02:19.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/3"}}},"commit":{"parents":[{"commit":"fac5c9d0d33c2b115230fdc62ce6a3df85dc4bc0","subject":"Merge \"Imported Translations from Transifex\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fac5c9d0d33c2b115230fdc62ce6a3df85dc4bc0"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"michael.still@canonical.com","date":"2012-11-22 05:01:40.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d7ba7cade9c1ccd45e5447a2bdcb90c691780ab8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d7ba7cade9c1ccd45e5447a2bdcb90c691780ab8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fac5c9d0d33c2b115230fdc62ce6a3df85dc4bc0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"416b986e243aa97d47fbf20a9c3581deb5dc3713":{"kind":"REWORK","_number":4,"created":"2012-11-22 20:08:51.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/4"}}},"commit":{"parents":[{"commit":"2d6abe49c35ab5c6200164455631a259eefe7457","subject":"Merge \"Compute doesn\u0027t set the \u0027host\u0027 field in instance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d6abe49c35ab5c6200164455631a259eefe7457"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"michael.still@canonical.com","date":"2012-11-22 20:08:31.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/416b986e243aa97d47fbf20a9c3581deb5dc3713"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/416b986e243aa97d47fbf20a9c3581deb5dc3713"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2d6abe49c35ab5c6200164455631a259eefe7457","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"1af18c68a7fcc7bb1b1438f6b4fbe0656c6ab56a":{"kind":"REWORK","_number":5,"created":"2012-12-07 21:47:00.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/5"}}},"commit":{"parents":[{"commit":"86cc905734f81c5363c1dc86ea2bba662bb18892","subject":"Merge \"Prevent creation of extraneous resource trackers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/86cc905734f81c5363c1dc86ea2bba662bb18892"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"michael.still@canonical.com","date":"2012-12-07 21:46:26.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1af18c68a7fcc7bb1b1438f6b4fbe0656c6ab56a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1af18c68a7fcc7bb1b1438f6b4fbe0656c6ab56a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"86cc905734f81c5363c1dc86ea2bba662bb18892","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"eed626753c23bb82453bc5176193831fbb9e538c":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2012-12-10 20:58:04.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/16507/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/16507/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/16507/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/16507/6"}}},"commit":{"parents":[{"commit":"2f962f50e472505a86782d0fc44a0b6cfd67813d","subject":"Merge \"Use conductor for bw_usage operations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2f962f50e472505a86782d0fc44a0b6cfd67813d"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-20 05:51:40.000000000","tz":660},"committer":{"name":"Michael Still","email":"michael.still@canonical.com","date":"2012-12-10 20:57:17.000000000","tz":660},"subject":"Map cinder snapshot statuses to ec2.","message":"Map cinder snapshot statuses to ec2.\n\nEC2 has way fewer statuses than cinder does, so we need to map them\nto valid entries. Resolves bug 1080284.\n\nDocImpact.\n\nChange-Id: I73bb2905577fb6f727c0a805df2654ad1bb4ad72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eed626753c23bb82453bc5176193831fbb9e538c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eed626753c23bb82453bc5176193831fbb9e538c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2f962f50e472505a86782d0fc44a0b6cfd67813d","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}