)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"1854dc7403757fc5404d595de1cc5c673b1c9d6b","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"                          network, gateway)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        if CONF.share_dhcp_address:"},{"line_number":1104,"context_line":"            isolate_dhcp_address(iface, network[\u0027dhcp_server\u0027])"},{"line_number":1105,"context_line":"        # NOTE(vish): applying here so we don\u0027t get a lock conflict"},{"line_number":1106,"context_line":"        iptables_manager.apply()"},{"line_number":1107,"context_line":"        return network[\u0027bridge\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fy9o%3D","line":1104,"updated":"2012-11-22 14:51:32.000000000","message":"In VLAN mode, attribute \u0027iface\u0027 should be set to the VLAN interface name (ie. vlan1000) instead of the \u0027vlan_interface\u0027 flag (ie. eth0).","commit_id":"bd3e444c144a53d5f68929d0bbd3cf7569ccf74e"},{"author":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"change_message_id":"1a32cd6f70adb590d37b044c477c72d0eaf2ffc7","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"                          network, gateway)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        if CONF.share_dhcp_address:"},{"line_number":1104,"context_line":"            isolate_dhcp_address(network.get(\u0027vlan\u0027) or iface,"},{"line_number":1105,"context_line":"                                 network[\u0027dhcp_server\u0027])"},{"line_number":1106,"context_line":"        # NOTE(vish): applying here so we don\u0027t get a lock conflict"},{"line_number":1107,"context_line":"        iptables_manager.apply()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2Fwks%3D","line":1104,"updated":"2012-11-26 23:10:52.000000000","message":"Doesn\u0027t network.get(\u0027vlan\u0027) only return the vlan number (i.e. \"100\") not the vlan device (i.e. \"vlan100\") which is what I would expect ebtables/iptables needs for creating the rules?","commit_id":"3869f46deed00a603cd4d84e9b33038849a01152"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b13e0c6a5dd144e3e6f76ba6d26412e608886417","unresolved":false,"context_lines":[{"line_number":1241,"context_line":""},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"def isolate_dhcp_address(interface, address):"},{"line_number":1244,"context_line":"    # block arp traffic to address accross the interface"},{"line_number":1245,"context_line":"    rules \u003d []"},{"line_number":1246,"context_line":"    rules.append(\u0027INPUT -p ARP -i %s --arp-ip-dst %s -j DROP\u0027"},{"line_number":1247,"context_line":"                 % (interface, address))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2FwEw%3D","line":1244,"updated":"2012-11-27 09:34:48.000000000","message":"Typo, but whatevers.","commit_id":"5b21ba723a4fe8076022dcafef0a55de3a99b35e"}],"nova/network/manager.py":[{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"1854dc7403757fc5404d595de1cc5c673b1c9d6b","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        \"\"\"Get the proper dhcp address to listen on.\"\"\""},{"line_number":900,"context_line":"        # NOTE(vish): this is for compatibility"},{"line_number":901,"context_line":"        if not network_ref.get(\u0027multi_host\u0027) or CONF.share_dhcp_address:"},{"line_number":902,"context_line":"            return network_ref[\u0027gateway\u0027]"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        if not host:"},{"line_number":905,"context_line":"            host \u003d self.host"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fy%2BE%3D","line":902,"updated":"2012-11-22 14:51:32.000000000","message":"In a multi_host mode with flag share_dhcp_address, we return gateway IP directly and we never call fixed_ip_associate_pool \n\nImplying, host haven\u0027t any fixed IP associated. And consequently host haven\u0027t network associated. When we\u0027ll call db method \u0027db.network_get_all_by_host\u0027, it will return an empty list.","commit_id":"bd3e444c144a53d5f68929d0bbd3cf7569ccf74e"}]}