)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"2e3fe3c61aed67e66265d6939c3b5f7d99987423","unresolved":false,"context_lines":[{"line_number":2624,"context_line":"        self.network_api.migrate_instance_finish(context, instance, migration)"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"        network_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":2627,"context_line":"        block_device_info \u003d self._get_instance_volume_block_device_info("},{"line_number":2628,"context_line":"                            context, instance[\u0027uuid\u0027])"},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"        self.driver.post_live_migration_at_destination(context, instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMH%2F%2FtoI%3D","line":2627,"updated":"2012-11-29 01:27:49.000000000","message":"This is adding a database read, which we\u0027re actively working to get rid of in nova-compute.  I think this method should be updated to take the bdms as an argument over rpc.","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"38857d352926d04245e93238fb5cf08f0eb0be41","unresolved":false,"context_lines":[{"line_number":2624,"context_line":"        self.network_api.migrate_instance_finish(context, instance, migration)"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"        network_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":2627,"context_line":"        block_device_info \u003d self._get_instance_volume_block_device_info("},{"line_number":2628,"context_line":"                            context, instance[\u0027uuid\u0027])"},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"        self.driver.post_live_migration_at_destination(context, instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FfiA%3D","line":2627,"in_reply_to":"AAAAMH%2F%2FtoI%3D","updated":"2013-01-18 17:56:51.000000000","message":"We have since done a lot of work in this area.  There are probably already conductor APIs you can use for this.","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"2163655cabdd48a2d9b7b5297babbeaaef445801","unresolved":false,"context_lines":[{"line_number":2391,"context_line":"            instance,"},{"line_number":2392,"context_line":"            fake_net_info,"},{"line_number":2393,"context_line":"            False,"},{"line_number":2394,"context_line":"            fake_block_dev_info)"},{"line_number":2395,"context_line":"        self.compute.network_api.setup_networks_on_host(admin_ctxt, instance,"},{"line_number":2396,"context_line":"                                                        self.compute.host)"},{"line_number":2397,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F0Dc%3D","line":2394,"updated":"2012-11-21 19:05:23.000000000","message":"minor nit: this actually should be double indented if you aren\u0027t aligning with the (","commit_id":"47217746a6a6212cec9e584a7a90d0a3776b3e85"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2da440d75a4e2e242b605c26bc52c44ddd704552","unresolved":false,"context_lines":[{"line_number":2388,"context_line":"        fake_net_info \u003d []"},{"line_number":2389,"context_line":"        fake_block_dev_info \u003d {\u0027foo\u0027: \u0027bar\u0027}"},{"line_number":2390,"context_line":"        self.compute.driver.post_live_migration_at_destination(admin_ctxt,"},{"line_number":2391,"context_line":"                instance,"},{"line_number":2392,"context_line":"                fake_net_info,"},{"line_number":2393,"context_line":"                False,"},{"line_number":2394,"context_line":"                fake_block_dev_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMH%2F%2FuRs%3D","line":2391,"updated":"2012-11-28 17:52:44.000000000","message":"Just curious: Why the re-indent here?","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ecdec9f62bb2cba19b911022033f101f6a6df099","unresolved":false,"context_lines":[{"line_number":2388,"context_line":"        fake_net_info \u003d []"},{"line_number":2389,"context_line":"        fake_block_dev_info \u003d {\u0027foo\u0027: \u0027bar\u0027}"},{"line_number":2390,"context_line":"        self.compute.driver.post_live_migration_at_destination(admin_ctxt,"},{"line_number":2391,"context_line":"                instance,"},{"line_number":2392,"context_line":"                fake_net_info,"},{"line_number":2393,"context_line":"                False,"},{"line_number":2394,"context_line":"                fake_block_dev_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMH%2F%2Ft3E%3D","line":2391,"in_reply_to":"AAAAMH%2F%2FuOE%3D","updated":"2012-11-28 22:43:32.000000000","message":"*shrug* OK…","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"1086b77ff3eaf4f80d4b0a4c800cf859873e0b07","unresolved":false,"context_lines":[{"line_number":2388,"context_line":"        fake_net_info \u003d []"},{"line_number":2389,"context_line":"        fake_block_dev_info \u003d {\u0027foo\u0027: \u0027bar\u0027}"},{"line_number":2390,"context_line":"        self.compute.driver.post_live_migration_at_destination(admin_ctxt,"},{"line_number":2391,"context_line":"                instance,"},{"line_number":2392,"context_line":"                fake_net_info,"},{"line_number":2393,"context_line":"                False,"},{"line_number":2394,"context_line":"                fake_block_dev_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMH%2F%2FuOE%3D","line":2391,"in_reply_to":"AAAAMH%2F%2FuRs%3D","updated":"2012-11-28 18:26:35.000000000","message":"I think we\u0027re double indenting any method args which cannot be lined up.  I originally had it single indented specifically in this file and Vish asked that I update to double indent.","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"2163655cabdd48a2d9b7b5297babbeaaef445801","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"    def resume_state_on_host_boot(self, context, instance, network_info,"},{"line_number":1006,"context_line":"                                  block_device_info\u003dNone):"},{"line_number":1007,"context_line":"        \"\"\"resume guest state when a host is booted\"\"\""},{"line_number":1008,"context_line":"        self._destroy(instance)"},{"line_number":1009,"context_line":"        xml \u003d self.to_xml(instance, network_info,"},{"line_number":1010,"context_line":"                          block_device_info\u003dblock_device_info,"},{"line_number":1011,"context_line":"                          write_to_disk\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F0DA%3D","line":1008,"updated":"2012-11-21 19:05:23.000000000","message":"I don\u0027t think this is safe. This will cause every instance to be destroyed and recreated when nova-compute is restarted if\n\nCONF.start_guests_on_host_boot is True","commit_id":"47217746a6a6212cec9e584a7a90d0a3776b3e85"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"0c9d0721a2684e2c9ac5c586995dc64b3df6f30a","unresolved":false,"context_lines":[{"line_number":946,"context_line":"        \"\"\""},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        self._destroy(instance)"},{"line_number":949,"context_line":"        self._undefine_domain(instance)"},{"line_number":950,"context_line":"        xml \u003d self.to_xml(instance, network_info,"},{"line_number":951,"context_line":"                          block_device_info\u003dblock_device_info,"},{"line_number":952,"context_line":"                          write_to_disk\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Ffgg%3D","line":949,"updated":"2013-01-18 18:10:15.000000000","message":"why add the undefine? Create will just overwrite it anyway.","commit_id":"9d7b3806e2e4cbe695e64abded5c0e50582885c5"}]}