)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b69653b8ed80a49997f0c03253f83c276be64a21","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            port_ids\u003dports_in_requested_order,"},{"line_number":580,"context_line":"            admin_client\u003dadmin_client,"},{"line_number":581,"context_line":"            preexisting_port_ids\u003dpreexisting_port_ids)"},{"line_number":582,"context_line":"        # NOTE(danms): Only return info about ports we created in this run."},{"line_number":583,"context_line":"        # In the initial allocation case, this will be everything we created,"},{"line_number":584,"context_line":"        # and in later runs will only be what was created that time. Thus,"},{"line_number":585,"context_line":"        # this only affects the attach case, not the original use for this"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_f8500d34","side":"PARENT","line":582,"updated":"2015-04-25 12:46:02.000000000","message":"This was added in commit 394c693e359ed4f19cc2f7d975b1f9ee5500b7f6.\n\nThe attach_interface code in the compute manager is still checking for exactly one port returned so the point of the comment hasn\u0027t changed:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5019\n\nI think the confusion here is when this was originally added we didn\u0027t have the preexisting_port_ids list, so it looks like we\u0027re returning more than just the ports we created (in the allocate case).\n\nThe functionality hasn\u0027t changed though.  In the attach case, created_port_ids is empty and preexisting_port_ids will be size 1 since it has the requested port in it (that we attach).  If that had changed, the attach_interface code in the compute manager would be broken.\n\nSo I\u0027m -1 on removing this comment since it\u0027s describing what the code is doing.  If you feel the need to clarify it somehow, that is a change that would be worth reviewing.","commit_id":"3f448c148b64d9c0aa8f919d12fed8d99f95d0ff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"33f969bca299ea4851224b61c5a7fe3e586012eb","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            port_ids\u003dports_in_requested_order,"},{"line_number":580,"context_line":"            admin_client\u003dadmin_client,"},{"line_number":581,"context_line":"            preexisting_port_ids\u003dpreexisting_port_ids)"},{"line_number":582,"context_line":"        # NOTE(danms): Only return info about ports we created in this run."},{"line_number":583,"context_line":"        # In the initial allocation case, this will be everything we created,"},{"line_number":584,"context_line":"        # and in later runs will only be what was created that time. Thus,"},{"line_number":585,"context_line":"        # this only affects the attach case, not the original use for this"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad0253b_3e204df7","side":"PARENT","line":582,"in_reply_to":"bab921fb_f8500d34","updated":"2015-04-28 16:56:48.000000000","message":"Agreed.","commit_id":"3f448c148b64d9c0aa8f919d12fed8d99f95d0ff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d1eb4d4ee07adf3eb2dbd5a84230a774b15b91e0","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # In the initial allocation case, this will be everything we attached,"},{"line_number":675,"context_line":"        # and in later runs will only be what was attached that time. Thus,"},{"line_number":676,"context_line":"        # this only affects the interface-attach call, not the original use"},{"line_number":677,"context_line":"        # for this method."},{"line_number":678,"context_line":"        return network_model.NetworkInfo([vif for vif in nw_info"},{"line_number":679,"context_line":"                                          if vif[\u0027id\u0027] in created_port_ids +"},{"line_number":680,"context_line":"                                          preexisting_port_ids])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_6faded30","line":677,"updated":"2015-04-28 18:16:26.000000000","message":"I don\u0027t think this is an improvement. It\u0027s not what we attached at all, it\u0027s what we created in neutron. Simply \"port create\" -- that\u0027s all. Right?","commit_id":"5233493c533850ce5acb0cc78a962f8420c3930f"},{"author":{"_account_id":10583,"name":"Praveen Yalagandula","email":"ypraveen@gmail.com","username":"ypraveen"},"change_message_id":"bbdd535390fe48d43d33c477e16a172f800720d0","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # In the initial allocation case, this will be everything we attached,"},{"line_number":675,"context_line":"        # and in later runs will only be what was attached that time. Thus,"},{"line_number":676,"context_line":"        # this only affects the interface-attach call, not the original use"},{"line_number":677,"context_line":"        # for this method."},{"line_number":678,"context_line":"        return network_model.NetworkInfo([vif for vif in nw_info"},{"line_number":679,"context_line":"                                          if vif[\u0027id\u0027] in created_port_ids +"},{"line_number":680,"context_line":"                                          preexisting_port_ids])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_ca574fc9","line":677,"in_reply_to":"5ad0253b_6faded30","updated":"2015-04-28 18:28:49.000000000","message":"Hi Dan,\nThe port could have been already created in Neutron and both nova boot and attach-interface can be invoked with an existing port. Further, a pre-created port can be moved from one VM to another VM too -- one of the use cases I am interested in. From what I understand, \"preexisting_port_ids\" is tracking those precreated ports.","commit_id":"5233493c533850ce5acb0cc78a962f8420c3930f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"000c7c609f394e8e1de858c80685dcf514801e52","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # In the initial allocation case, this will be everything we attached,"},{"line_number":675,"context_line":"        # and in later runs will only be what was attached that time. Thus,"},{"line_number":676,"context_line":"        # this only affects the interface-attach call, not the original use"},{"line_number":677,"context_line":"        # for this method."},{"line_number":678,"context_line":"        return network_model.NetworkInfo([vif for vif in nw_info"},{"line_number":679,"context_line":"                                          if vif[\u0027id\u0027] in created_port_ids +"},{"line_number":680,"context_line":"                                          preexisting_port_ids])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_ca986f6d","line":677,"in_reply_to":"5ad0253b_ca574fc9","updated":"2015-04-28 18:34:51.000000000","message":"Yeah, unfortunately that change really confused things. However, I don\u0027t think \"attach\" is the right word here at all.","commit_id":"5233493c533850ce5acb0cc78a962f8420c3930f"},{"author":{"_account_id":10583,"name":"Praveen Yalagandula","email":"ypraveen@gmail.com","username":"ypraveen"},"change_message_id":"6b9b324b3f02f74e7b3a33f13a0c72f65378469a","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # In the initial allocation case, this will be everything we attached,"},{"line_number":675,"context_line":"        # and in later runs will only be what was attached that time. Thus,"},{"line_number":676,"context_line":"        # this only affects the interface-attach call, not the original use"},{"line_number":677,"context_line":"        # for this method."},{"line_number":678,"context_line":"        return network_model.NetworkInfo([vif for vif in nw_info"},{"line_number":679,"context_line":"                                          if vif[\u0027id\u0027] in created_port_ids +"},{"line_number":680,"context_line":"                                          preexisting_port_ids])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_aabad36c","line":677,"in_reply_to":"5ad0253b_ca986f6d","updated":"2015-04-28 18:43:19.000000000","message":"Do you feel \"attach\" is not the right word because it does not cover the case when the ports are created? or something else?\n\nHow about \"ports we ALLOCATED TO THIS INSTANCE in this run\"?","commit_id":"5233493c533850ce5acb0cc78a962f8420c3930f"}]}