)]}'
{"nova/exception.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae520db77b5939b0dfa7804fd0782d7712e2fcc","unresolved":false,"context_lines":[{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"class BMNodeInUse(NovaException):"},{"line_number":1038,"context_line":"    message \u003d _(\"Baremetal node %(id) already registered with uuid %(uuid)\")"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"class BMNodeNotSpecified(NovaException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0Zg%3D","line":1038,"updated":"2012-11-21 14:54:06.000000000","message":"This is not used in this patch. Is it going to be used in the patch that follows?","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae520db77b5939b0dfa7804fd0782d7712e2fcc","unresolved":false,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"class BMNodeNotSpecified(NovaException):"},{"line_number":1042,"context_line":"    message \u003d _(\"Baremetal node id not specified\")"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"class BMInterfaceInUse(NovaException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0Zc%3D","line":1042,"updated":"2012-11-21 14:54:06.000000000","message":"This one too","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae520db77b5939b0dfa7804fd0782d7712e2fcc","unresolved":false,"context_lines":[{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"class BMWrongServiceHost(NovaException):"},{"line_number":1058,"context_line":"    message \u003d _(\"Requested instance %(id)s not found on baremetal\""},{"line_number":1059,"context_line":"                \"service host %(host)s\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"def get_context_from_function_and_args(function, args, kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0ZY%3D","line":1059,"updated":"2012-11-21 14:54:06.000000000","message":"And this one","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae520db77b5939b0dfa7804fd0782d7712e2fcc","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"class BMWrongServiceHost(NovaException):"},{"line_number":1058,"context_line":"    message \u003d _(\"Requested instance %(id)s not found on baremetal\""},{"line_number":1059,"context_line":"                \"service host %(host)s\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"def get_context_from_function_and_args(function, args, kwargs):"},{"line_number":1063,"context_line":"    \"\"\"Find an arg of type RequestContext and return it."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0ZE%3D","line":1060,"updated":"2012-11-21 14:54:06.000000000","message":"Are all of these going to be bubbled up past the driver? They seem to all look very BM-specific, and like things that should be caught in the driver and transformed into something generic like the other drivers.\n\nPerhaps I should wait until you refresh the following patch to see what you have planned? :)","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ce295a39bdf020631e8a209f8fb913566b1d3207","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"class BMWrongServiceHost(NovaException):"},{"line_number":1058,"context_line":"    message \u003d _(\"Requested instance %(id)s not found on baremetal\""},{"line_number":1059,"context_line":"                \"service host %(host)s\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"def get_context_from_function_and_args(function, args, kwargs):"},{"line_number":1063,"context_line":"    \"\"\"Find an arg of type RequestContext and return it."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fz%2Bw%3D","line":1060,"in_reply_to":"AAAAMH%2F%2F0ZE%3D","updated":"2012-11-21 19:36:10.000000000","message":"After reviewing nova/compute/manager.py, I\u0027ve consolidated these a bit and made more places raise InstanceNotFound (there is special handling for that exception in manager, as you pointed out).","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"}],"nova/virt/baremetal/db/sqlalchemy/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae520db77b5939b0dfa7804fd0782d7712e2fcc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    elif read_deleted \u003d\u003d \u0027only\u0027:"},{"line_number":65,"context_line":"        query \u003d query.filter_by(deleted\u003dTrue)"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        raise Exception("},{"line_number":68,"context_line":"                _(\"Unrecognized read_deleted value \u0027%s\u0027\") % read_deleted)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    if project_only and is_user_context(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0Zk%3D","line":67,"updated":"2012-11-21 14:54:06.000000000","message":"This raise Exception() should probably be addressed in this patch, even though it\u0027s already in.","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ce295a39bdf020631e8a209f8fb913566b1d3207","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    elif read_deleted \u003d\u003d \u0027only\u0027:"},{"line_number":65,"context_line":"        query \u003d query.filter_by(deleted\u003dTrue)"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        raise Exception("},{"line_number":68,"context_line":"                _(\"Unrecognized read_deleted value \u0027%s\u0027\") % read_deleted)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    if project_only and is_user_context(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F0OU%3D","line":67,"in_reply_to":"AAAAMH%2F%2F0Zk%3D","updated":"2012-11-21 19:36:10.000000000","message":"This is actually copied from nova/db/sqlalchemy/api.py, so if it needs to change, it should be a separate patch to change in both places.","commit_id":"b168fd84b394dcee3eb4582ec4e052f691de51d2"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"28c0ce55143b1ae2eaa9d23edf81730c99023223","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    if not result:"},{"line_number":347,"context_line":"        raise exception.NovaException(_(\"Baremetal interface %s \""},{"line_number":348,"context_line":"                        \"not found\") % if_id)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    return result"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fzpg%3D","line":348,"updated":"2012-11-21 23:34:48.000000000","message":"use vif_uuid and a message suitable for it","commit_id":"0020b89e04242947873e2391c6180d851840c90a"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"b39de71eedf7fff57e2bc8c57f65bb96060274dc","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"@require_admin_context"},{"line_number":340,"context_line":"def bm_interface_get_by_vif_uuid(context, vif_uuid):"},{"line_number":341,"context_line":"    result \u003d model_query(context, models.BareMetalInterface,"},{"line_number":342,"context_line":"                         read_deleted\u003d\"no\").\\"},{"line_number":343,"context_line":"                filter_by(vif_uuid\u003dvif_uuid).\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FyfY%3D","line":340,"updated":"2012-11-23 11:55:39.000000000","message":"Should we check vif_uuid like L132 ?","commit_id":"82433b3f28e37dcb7c5d77ffb86fd5cd10f2c6b6"}]}