)]}'
{"nova/tests/unit/api/openstack/compute/contrib/test_extended_volumes.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"afa0959d52bb92d97abbf1e7529aea794e56a22b","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"},{"line_number":155,"context_line":"        self.policy.set_rules({rule_name: \"project:non_fake\"})"},{"line_number":156,"context_line":"        # Pass ResponseObj as None, the code shouldn\u0027t touch the None."},{"line_number":157,"context_line":"        self.controller.show(self.req, None, fakes.FAKE_UUID)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_extend_detail_policy_failed(self):"},{"line_number":160,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_b72fc9a0","line":157,"updated":"2015-03-26 23:19:43.000000000","message":"there should assert the error message, this is the reason way this unittest didn\u0027t failed with wrong rule name. Like this assert https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_admin_actions.py#L80","commit_id":"cc1632b9b2ca2ac7043255e00ca7ef00b6e57547"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b499b83c1084daa2a23af3ae68d05c6317052117","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"},{"line_number":155,"context_line":"        self.policy.set_rules({rule_name: \"project:non_fake\"})"},{"line_number":156,"context_line":"        # Pass ResponseObj as None, the code shouldn\u0027t touch the None."},{"line_number":157,"context_line":"        self.controller.show(self.req, None, fakes.FAKE_UUID)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_extend_detail_policy_failed(self):"},{"line_number":160,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_bb2fa4a0","line":157,"in_reply_to":"fa963961_3b0cb493","updated":"2015-03-27 12:57:13.000000000","message":"oops, you are right. I missed that, sorry.\n\nWe can set a default rule, the default rule is True, then if this rule didn\u0027t fault, the testcase will failed, what would you think?","commit_id":"cc1632b9b2ca2ac7043255e00ca7ef00b6e57547"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3f5d05fee5add59857dbb695a9ce0aef197dcf08","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"},{"line_number":155,"context_line":"        self.policy.set_rules({rule_name: \"project:non_fake\"})"},{"line_number":156,"context_line":"        # Pass ResponseObj as None, the code shouldn\u0027t touch the None."},{"line_number":157,"context_line":"        self.controller.show(self.req, None, fakes.FAKE_UUID)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_extend_detail_policy_failed(self):"},{"line_number":160,"context_line":"        rule_name \u003d \u0027os_compute_api:os-extended-volumes\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_3b0cb493","line":157,"in_reply_to":"fa963961_b72fc9a0","updated":"2015-03-27 12:46:50.000000000","message":"why? \nthe code use \u0027soft_authorize\u0027 logic...\n\nI can do a mock to check the function it\u0027s called or not \nbut No Exception raising","commit_id":"cc1632b9b2ca2ac7043255e00ca7ef00b6e57547"}],"nova/tests/unit/api/openstack/compute/contrib/test_used_limits.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"76eec52dc56852810d4f1662a6f356378dfab1cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class UsedLimitsTestCaseV21(test.NoDBTestCase):"},{"line_number":35,"context_line":"    used_limit_extension \u003d \"os_compute_api:os-used-limits:used_limits\""},{"line_number":36,"context_line":"    include_server_group_quotas \u003d True"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_ab5b6df4","line":35,"updated":"2015-03-26 02:29:31.000000000","message":"00-os-compute-api.json doesn\u0027t contain\n\n os_compute_api:os-used-limits:used_limits\n\nso here should be\n\n os_compute_api:os-used-limits","commit_id":"6b71b93caae2a1d379a90859bd549ce2324d5538"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0e3d23f8fbe8f2f9722109cbb2355fb0ef9a71e7","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class UsedLimitsTestCaseV21(test.NoDBTestCase):"},{"line_number":35,"context_line":"    used_limit_extension \u003d \"os_compute_api:os-used-limits:used_limits\""},{"line_number":36,"context_line":"    include_server_group_quotas \u003d True"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_82ac8fee","line":35,"in_reply_to":"1a6ced46_ab5b6df4","updated":"2015-03-26 16:46:45.000000000","message":"yes, thanks for pointing out ~","commit_id":"6b71b93caae2a1d379a90859bd549ce2324d5538"}]}