)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/280_drop_nova_volumes_tables.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19a92cfd942e357c36b955a3ce2d9fbd1e080e4b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # nova-volumes, which is deprecated and removed, but the related"},{"line_number":30,"context_line":"    # tables are still created."},{"line_number":31,"context_line":"    table_names \u003d (\u0027volumes\u0027, \u0027iscsi_targets\u0027,"},{"line_number":32,"context_line":"                   \u0027shadow_volumes\u0027, \u0027shadow_iscsi_targets\u0027)"},{"line_number":33,"context_line":"    for table_name in table_names:"},{"line_number":34,"context_line":"        table \u003d Table(table_name, meta, autoload\u003dTrue)"},{"line_number":35,"context_line":"        table.drop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_d5e560a4","line":32,"updated":"2015-03-20 19:54:04.000000000","message":"You could probably also remove volume_usage but that has some db api and conductor api code still calling vol_get_usage_by_time - even though there is no entry point to that code and it wouldn\u0027t work anyway since conductor manager doesn\u0027t implement vol_get_usage_by_time.","commit_id":"d2d162d5d3e7628c977257708b04411499de70bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"594ed774d0be7278e18fd773e4d2d19158d6e0bc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # nova-volumes, which is deprecated and removed, but the related"},{"line_number":30,"context_line":"    # tables are still created."},{"line_number":31,"context_line":"    table_names \u003d (\u0027volumes\u0027, \u0027iscsi_targets\u0027,"},{"line_number":32,"context_line":"                   \u0027shadow_volumes\u0027, \u0027shadow_iscsi_targets\u0027)"},{"line_number":33,"context_line":"    for table_name in table_names:"},{"line_number":34,"context_line":"        table \u003d Table(table_name, meta, autoload\u003dTrue)"},{"line_number":35,"context_line":"        table.drop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_15b1b88e","line":32,"in_reply_to":"9a80dd14_d5e560a4","updated":"2015-03-20 19:56:28.000000000","message":"Nevermind, you can\u0027t remove volume_usages since vol_get_usage_by_time is still using it and detach_volume in conductor is calling that.\n\nThere is still no external entry point (compute API or nova-manage) that I see which uses that data though.","commit_id":"d2d162d5d3e7628c977257708b04411499de70bf"}],"nova/db/sqlalchemy/migrate_repo/versions/292_drop_nova_volumes_tables.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"7a4f46fd2123716a7958c96e0339ec6ac1763758","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        _drop_table_and_indexes(meta, table_name)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def downgrade(engine):"},{"line_number":66,"context_line":"    meta \u003d MetaData()"},{"line_number":67,"context_line":"    meta.bind \u003d engine"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3acd31a7_b1c1f9e6","line":65,"updated":"2015-04-30 17:44:41.000000000","message":"I thought we weren\u0027t doing downgrades anymore?","commit_id":"b88eed46875da6c8a104e504b5c328ea02f0d814"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"f7141c9de5c15553eedea7adedde34876a59357f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        _drop_table_and_indexes(meta, table_name)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def downgrade(engine):"},{"line_number":66,"context_line":"    meta \u003d MetaData()"},{"line_number":67,"context_line":"    meta.bind \u003d engine"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3acd31a7_d48fc321","line":65,"in_reply_to":"3acd31a7_517865c4","updated":"2015-04-30 17:58:14.000000000","message":"p00f! it\u0027s gone. thanks :)","commit_id":"b88eed46875da6c8a104e504b5c328ea02f0d814"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bcff9c926a511ae49c719e84aa5e026cb973badf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        _drop_table_and_indexes(meta, table_name)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def downgrade(engine):"},{"line_number":66,"context_line":"    meta \u003d MetaData()"},{"line_number":67,"context_line":"    meta.bind \u003d engine"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3acd31a7_517865c4","line":65,"in_reply_to":"3acd31a7_b1c1f9e6","updated":"2015-04-30 17:45:48.000000000","message":"Yep, this all needs to go.","commit_id":"b88eed46875da6c8a104e504b5c328ea02f0d814"}],"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"af1acf597e1ae50b566d9951b4380c19aaf67af9","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # check"},{"line_number":675,"context_line":"        pass"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def _check_292(self, engine, data):"},{"line_number":678,"context_line":"        self.assertTableNotExists(engine, \u0027iscsi_targets\u0027)"},{"line_number":679,"context_line":"        self.assertTableNotExists(engine, \u0027volumes\u0027)"},{"line_number":680,"context_line":"        self.assertTableNotExists(engine, \u0027shadow_iscsi_targets\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3acd31a7_fd2fe685","line":677,"updated":"2015-05-05 12:44:23.000000000","message":"honestly, this kind of test is sort of pointless. If sqlalchemy doesn\u0027t work, we have bigger problems.","commit_id":"5c87cc67114c1f4e538b5fedc25c8751bfa1177c"}]}