)]}'
{"id":"openstack%2Fnova~16632","triplet_id":"openstack%2Fnova~master~Id76dedef8fc96dcd6fa5b72ace6c50c85e04215b","project":"openstack/nova","branch":"master","topic":"arch-update","hashtags":[],"change_id":"Id76dedef8fc96dcd6fa5b72ace6c50c85e04215b","subject":"Don\u0027t update arch twice when create server","status":"MERGED","created":"2012-11-21 12:03:46.000000000","updated":"2012-11-23 04:55:00.000000000","submitted":"2012-11-23 04:54:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"894b5aad93dccfbac4dadf100ff4956dde6bdbe6","_number":16632,"virtual_id_number":16632,"owner":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},{"value":2,"date":"2012-11-23 04:54:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-11-22 14:49:09.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":2,"date":"2012-11-23 04:33:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-11-22 14:49:09.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":1,"date":"2012-11-23 04:33:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-21 12:25:05.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2012-11-21 13:38:46.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2012-11-21 17:15:49.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-11-21 17:33:17.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-11-22 14:49:09.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-11-23 04:33:20.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2012-11-23 04:54:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d15f755da864957461643ece2ed85cfbfbee8d09","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2012-11-21 12:25:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a693b84f9379cb99e2be36dccc811b3dbbd5872b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-21 13:31:48.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16632/1/check/gate-nova-merge/12631 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-nova-docs/8362 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-nova-pep8/13672 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-nova-python26/9812 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-nova-python27/9882 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-tempest-devstack-vm/19494 : SUCCESS\n- http://logs.openstack.org/16632/1/check/gate-nova-pylint/3353 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"b93c0e0722d1143549e5a361be36cdcdaa11d170","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-11-21 13:38:14.000000000","message":"Patch Set 1:\n\nI looks like I530760cfaa5eb0cae590c7383e0840c6b3f896b9 goes the other way and removes the architecture from _create_instance(). OK to go with that?","accounts_in_message":[],"_revision_number":1},{"id":"7bd3975b02bf030be04ea5dfe3c9f9549c613a2f","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2012-11-21 14:14:51.000000000","message":"Patch Set 1:\n\nActually in I530760cfaa5eb0cae590c7383e0840c6b3f896b9 I forgot to remove it form where this patch removes it - they can go together since we get the architecture in  _inherit_properties_from_image and there is no need to get it again anywhere else. \n\nWe can keep this patch if the author insists (and I\u0027ll rebase when my patch gets in), or I can add it to my patch to have things in one place","accounts_in_message":[],"_revision_number":1},{"id":"88ae9750aa28d6134a8682e626fa1d3d05d0a199","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-11-21 17:15:49.000000000","message":"Patch Set 1:\n\nWould you mind word-wrapping the commit message? :)","accounts_in_message":[],"_revision_number":1},{"id":"35193e3439a9160014abf5858a2eaa51f8d2980f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-21 17:33:17.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Running: http://smokestack.openstack.org/?go\u003d/jobs/49439\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/49437\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/49438\n","accounts_in_message":[],"_revision_number":1},{"id":"275b21b5a0a3d61aa325fe6d16f088694cd5d3ab","author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"date":"2012-11-21 19:27:37.000000000","message":"Patch Set 1:\n\nAs you said is not in I530760cfaa5eb0cae590c7383e0840c6b3f896b9 and they can go together so if it\u0027s OK for you I would suggest the rebase after.","accounts_in_message":[],"_revision_number":1},{"id":"e94e8c6493426d0df4b19b60133afe697f162c78","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2012-11-22 07:59:35.000000000","message":"Patch Set 1:\n\nSure - fine with me, just please word-wrap the commit message as was suggested. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"be8b8dca0858a77709e5ad4755a3151481f2cb24","author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"date":"2012-11-22 12:30:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"61176fc9f0a58960d8f32656ca7142eb2284457a","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-11-22 12:30:51.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"788390334f56816744b3cbef9f901a0eb69106c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-22 12:53:40.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16632/2/check/gate-nova-merge/12775 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-nova-docs/8506 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-nova-pep8/13816 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-nova-python26/9956 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-nova-python27/10026 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-tempest-devstack-vm/19737 : SUCCESS\n- http://logs.openstack.org/16632/2/check/gate-nova-pylint/3468 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ddd0663c850b0837c45cd645dce5b0551e90726e","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-11-22 14:49:09.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nthanks","accounts_in_message":[],"_revision_number":2},{"id":"f62c8be69c7e15f7c46cc5a6e871baf2ec5de7cf","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-23 04:33:20.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"77faf5e70ccd799b3d3c387b9507e6f037519a43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-23 04:33:40.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"d41ca4511b49917cf7b763086c95315da8d98d2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-23 04:54:59.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/16632/2/gate/gate-nova-merge/12815 : SUCCESS\n- http://logs.openstack.org/16632/2/gate/gate-nova-docs/8545 : SUCCESS\n- http://logs.openstack.org/16632/2/gate/gate-nova-pep8/13855 : SUCCESS\n- http://logs.openstack.org/16632/2/gate/gate-nova-python26/9995 : SUCCESS\n- http://logs.openstack.org/16632/2/gate/gate-nova-python27/10065 : SUCCESS\n- http://logs.openstack.org/16632/2/gate/gate-tempest-devstack-vm/19794 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"81a1db24e1b5f0c4cbd9b06982fa1ba521008375","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-23 04:55:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"acfe50638254da608fec0c01f2511b3aad4c9487","revisions":{"9ff879c43b7592f7a85c6850c28a15197a4bda86":{"kind":"REWORK","_number":1,"created":"2012-11-21 12:03:46.000000000","uploader":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"ref":"refs/changes/32/16632/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/32/16632/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/32/16632/1"}}},"commit":{"parents":[{"commit":"9dfb4b420f9d15d348f9fa9a2a0cb1a57f4e5771","subject":"Merge \"Rename sql_pool_size to sql_max_pool_size\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9dfb4b420f9d15d348f9fa9a2a0cb1a57f4e5771"}]}],"author":{"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","date":"2012-11-21 11:58:35.000000000","tz":60},"committer":{"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","date":"2012-11-21 11:58:35.000000000","tz":60},"subject":"Don\u0027t update arch twice when create server","message":"Don\u0027t update arch twice when create server\n\nDuring the instance creation a dictionary of instance characteristics (base_options) is created in nova.compute.api._create_instance where\n\"architecture\" is defined looking into image[properties]. Then \"architecture\" entry is updated to the same value in nova.compute.api._populate_instance_for_create if defined or it removes the \u0027Unknown\u0027 value for this key.\n\nThis patch removes the unnecessary \"architecture\" update.\n\nChange-Id: Id76dedef8fc96dcd6fa5b72ace6c50c85e04215b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9ff879c43b7592f7a85c6850c28a15197a4bda86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9ff879c43b7592f7a85c6850c28a15197a4bda86"}]},"branch":"refs/heads/master"},"acfe50638254da608fec0c01f2511b3aad4c9487":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-11-22 12:30:38.000000000","uploader":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"ref":"refs/changes/32/16632/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/32/16632/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/32/16632/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/32/16632/2"}}},"commit":{"parents":[{"commit":"9dfb4b420f9d15d348f9fa9a2a0cb1a57f4e5771","subject":"Merge \"Rename sql_pool_size to sql_max_pool_size\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9dfb4b420f9d15d348f9fa9a2a0cb1a57f4e5771"}]}],"author":{"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","date":"2012-11-21 11:58:35.000000000","tz":60},"committer":{"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","date":"2012-11-22 12:28:12.000000000","tz":60},"subject":"Don\u0027t update arch twice when create server","message":"Don\u0027t update arch twice when create server\n\nDuring the instance creation a dictionary of instance characteristics\n(base_options) is created in nova.compute.api._create_instance where\n\"architecture\" is defined looking into image[properties].\nThen \"architecture\" entry is updated to the same value in\nnova.compute.api._populate_instance_for_create if defined or it removes\nthe \u0027Unknown\u0027 value for this key.\n\nThis patch removes the unnecessary \"architecture\" update.\n\nChange-Id: Id76dedef8fc96dcd6fa5b72ace6c50c85e04215b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/acfe50638254da608fec0c01f2511b3aad4c9487"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/acfe50638254da608fec0c01f2511b3aad4c9487"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}