)]}'
{"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"b6003a4631396d978fc7f607cd20028d3c2ec372","unresolved":false,"context_lines":[{"line_number":3364,"context_line":"            ports_needed \u003d self.api._ports_needed_per_instance("},{"line_number":3365,"context_line":"                self.context, \u0027fake-neutron-client\u0027, requested_networks)"},{"line_number":3366,"context_line":"            self.assertEqual(1, ports_needed)"},{"line_number":3367,"context_line":""},{"line_number":3368,"context_line":""},{"line_number":3369,"context_line":"class TestNeutronv2ModuleMethods(test.NoDBTestCase):"},{"line_number":3370,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_0d6fbe93","line":3367,"updated":"2015-03-23 12:38:56.000000000","message":"I feel surprised by this kind of testing.  It seems that it may already be widespread in OpenStack, but in every other context where I\u0027ve worked the principle has been to test a component through its advertised public interfaces.  Whereas _ports_needed_per_instance is part of the internal implementation of neutronv2.API, and should - I would say - absolutely not be touched by unit test code.\n\nSuppose someone else in future wants to do some further refactoring of those internals.  Having this test code here will just make their task harder, won\u0027t it?\n\nAlso, my understanding is that your change to api.py is simply to improve its structure for better maintainability and readability.  Therefore, why should there be any new testing at all?","commit_id":"83bae39f74bdebb5ea05a70fec8b042fcffa6c00"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e5d5de26625f9dfe9367c0cf14f080ff5edf2db9","unresolved":false,"context_lines":[{"line_number":3364,"context_line":"            ports_needed \u003d self.api._ports_needed_per_instance("},{"line_number":3365,"context_line":"                self.context, \u0027fake-neutron-client\u0027, requested_networks)"},{"line_number":3366,"context_line":"            self.assertEqual(1, ports_needed)"},{"line_number":3367,"context_line":""},{"line_number":3368,"context_line":""},{"line_number":3369,"context_line":"class TestNeutronv2ModuleMethods(test.NoDBTestCase):"},{"line_number":3370,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_8dc1eee6","line":3367,"in_reply_to":"1a6ced46_0d6fbe93","updated":"2015-03-23 12:54:53.000000000","message":"The code is actually tested. I just added this to help. I will drop this.","commit_id":"83bae39f74bdebb5ea05a70fec8b042fcffa6c00"}]}