)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3e19eb4358b57152ebc3ac9a7672b9e0388a4865","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This will now be:"},{"line_number":13,"context_line":" \u003cdisplay-name\u003e (\u003cinstance-uuid\u003e)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Once the the instance is created we will perform a rename. The reason"},{"line_number":16,"context_line":"for this is that the disks are all stored under a folder on the datastore"},{"line_number":17,"context_line":"that has the name of the instance UUID."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3acd31a7_289013ec","line":15,"updated":"2015-04-29 15:21:38.000000000","message":"the the -\u003e the","commit_id":"baff988a7f18bbabd8ed53ead18c2b212d56e222"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7936174e4e8be468efa3c7e63223bbb42ed292ce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: improve instance names on VC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Up until now the instance name of the VC was the UUID of the instance."},{"line_number":10,"context_line":"This is very confusing for administrators and they would like some"},{"line_number":11,"context_line":"context for the VM."},{"line_number":12,"context_line":"This will now be:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a0c5dc1_d820224c","line":9,"updated":"2015-05-12 14:26:02.000000000","message":"\"of the VM\" right? or in the VC","commit_id":"5a4002a5c72763e285e4caf5f2df436f9993dbaa"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"36cf599245180d0a4c90fa45132e98df3e688bd8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                         \u0027project_id\u0027: \u0027fake\u0027,"},{"line_number":203,"context_line":"                                         \u0027user_id\u0027: \u0027fake\u0027,"},{"line_number":204,"context_line":"                                         \u0027name\u0027: \u00271\u0027,"},{"line_number":205,"context_line":"                                         \u0027disaply_name\u0027: self._display_name,"},{"line_number":206,"context_line":"                                         \u0027display_description\u0027: \u00271\u0027,"},{"line_number":207,"context_line":"                                         \u0027kernel_id\u0027: \u00271\u0027,"},{"line_number":208,"context_line":"                                         \u0027ramdisk_id\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa80f949_40063dcf","line":205,"updated":"2015-11-05 22:01:42.000000000","message":"typo: display_name","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e3230e1c1bbcad64827154ad0bfd90d8073fbf94","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                         \u0027project_id\u0027: \u0027fake\u0027,"},{"line_number":203,"context_line":"                                         \u0027user_id\u0027: \u0027fake\u0027,"},{"line_number":204,"context_line":"                                         \u0027name\u0027: \u00271\u0027,"},{"line_number":205,"context_line":"                                         \u0027disaply_name\u0027: self._display_name,"},{"line_number":206,"context_line":"                                         \u0027display_description\u0027: \u00271\u0027,"},{"line_number":207,"context_line":"                                         \u0027kernel_id\u0027: \u00271\u0027,"},{"line_number":208,"context_line":"                                         \u0027ramdisk_id\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_1b8f202b","line":205,"in_reply_to":"3a7e1126_ddfc9e40","updated":"2015-12-20 08:41:45.000000000","message":"my bad - the tests pass as this is for a specific test case when there is no instance running.","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"56b00204d93ca77be6d469993be77185be62cd0b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                         \u0027project_id\u0027: \u0027fake\u0027,"},{"line_number":203,"context_line":"                                         \u0027user_id\u0027: \u0027fake\u0027,"},{"line_number":204,"context_line":"                                         \u0027name\u0027: \u00271\u0027,"},{"line_number":205,"context_line":"                                         \u0027disaply_name\u0027: self._display_name,"},{"line_number":206,"context_line":"                                         \u0027display_description\u0027: \u00271\u0027,"},{"line_number":207,"context_line":"                                         \u0027kernel_id\u0027: \u00271\u0027,"},{"line_number":208,"context_line":"                                         \u0027ramdisk_id\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_ddfc9e40","line":205,"in_reply_to":"fa80f949_40063dcf","updated":"2015-12-17 14:55:56.000000000","message":"+1 unsure how the tests pass :S","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a566595aa2bc21ad7cf13765a56cfd179a586682","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        self.fake_image_uuid \u003d self.image[\u0027id\u0027]"},{"line_number":197,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self.stubs)"},{"line_number":198,"context_line":"        self.vnc_host \u003d \u0027ha-host\u0027"},{"line_number":199,"context_line":"        self.instance_without_compute \u003d fake_instance.fake_instance_obj(None,"},{"line_number":200,"context_line":"                                        **{\u0027node\u0027: None,"},{"line_number":201,"context_line":"                                         \u0027vm_state\u0027: \u0027building\u0027,"},{"line_number":202,"context_line":"                                         \u0027project_id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a7e1126_e9100e5b","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":37},"updated":"2015-12-22 06:35:20.000000000","message":"on the other your patch https://review.openstack.org/#/c/259753/ , this part will be removed.\nSo this part seems conflict.\n\nIs it possible to rebase this on the other?","commit_id":"9d96a63f7943f809d8e1ef9045cf09b102916fca"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c62041b2361e684f3efd0c2cf3df860685275477","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        self.fake_image_uuid \u003d self.image[\u0027id\u0027]"},{"line_number":197,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self.stubs)"},{"line_number":198,"context_line":"        self.vnc_host \u003d \u0027ha-host\u0027"},{"line_number":199,"context_line":"        self.instance_without_compute \u003d fake_instance.fake_instance_obj(None,"},{"line_number":200,"context_line":"                                        **{\u0027node\u0027: None,"},{"line_number":201,"context_line":"                                         \u0027vm_state\u0027: \u0027building\u0027,"},{"line_number":202,"context_line":"                                         \u0027project_id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a7e1126_04377f4d","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":37},"in_reply_to":"3a7e1126_e9100e5b","updated":"2015-12-22 07:05:23.000000000","message":"Done","commit_id":"9d96a63f7943f809d8e1ef9045cf09b102916fca"}],"nova/tests/unit/virt/vmwareapi/test_vm_util.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3f660bc14722fa55721fc3767c207dc2c29e6f27","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        uuid \u003d uuidutils.generate_uuid()"},{"line_number":1738,"context_line":"        expected \u003d uuid"},{"line_number":1739,"context_line":"        name \u003d vm_util._get_vm_name(None, uuid)"},{"line_number":1740,"context_line":"        self.assertEqual(expected, name)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"        display_name \u003d \u0027fira\u0027"},{"line_number":1743,"context_line":"        expected \u003d \u0027fira (%s)\u0027 % uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6ed579_a27f99de","line":1740,"updated":"2016-01-15 11:51:02.000000000","message":"Nit: I wish this was three separate tests, or had string comments in the assert statements.","commit_id":"47e3a4e96189486b53d3f8f0aac0ea56931adac8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"70ec54dee20717e6a44e45041c264158e3c94af5","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        uuid \u003d uuidutils.generate_uuid()"},{"line_number":1738,"context_line":"        expected \u003d uuid"},{"line_number":1739,"context_line":"        name \u003d vm_util._get_vm_name(None, uuid)"},{"line_number":1740,"context_line":"        self.assertEqual(expected, name)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"        display_name \u003d \u0027fira\u0027"},{"line_number":1743,"context_line":"        expected \u003d \u0027fira (%s)\u0027 % uuid"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba63e191_e1d74821","line":1740,"in_reply_to":"da6ed579_a27f99de","updated":"2016-01-20 08:01:25.000000000","message":"nice point, but this test already passes and it is nice to merge this because this is not so big test.","commit_id":"47e3a4e96189486b53d3f8f0aac0ea56931adac8"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c99d7ffa81f011283e7dbe81590bc09a7646b42c","unresolved":false,"context_lines":[{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"def _get_vm_name(display_name, id):"},{"line_number":1591,"context_line":"    if display_name:"},{"line_number":1592,"context_line":"        return \u0027%s (%s)\u0027 % (display_name[:41], id[:36])"},{"line_number":1593,"context_line":"    else:"},{"line_number":1594,"context_line":"        return id[:36]"},{"line_number":1595,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_64d728ee","line":1592,"updated":"2015-05-13 12:39:15.000000000","message":"You may be able to use the instance.name as the vm name, allow users to configure \"CONF.instance_name_template\" \u003d \"%(display_name)s %(uuid)s\" or other template.","commit_id":"5a4002a5c72763e285e4caf5f2df436f9993dbaa"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"12c044184e65b1a1efd96f4f2aa560721d18373f","unresolved":false,"context_lines":[{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"def _get_vm_name(display_name, id):"},{"line_number":1612,"context_line":"    if display_name:"},{"line_number":1613,"context_line":"        return \u0027%s (%s)\u0027 % (display_name[:41], id[:36])"},{"line_number":1614,"context_line":"    else:"},{"line_number":1615,"context_line":"        return id[:36]"},{"line_number":1616,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_816b2af1","line":1613,"updated":"2015-07-30 21:43:26.000000000","message":"nit: would be good to define a variable/constants for these magic numbers.","commit_id":"0e96678c39c3af522a652864ee14f3eca2288a06"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"ab8856ad67b86fe5f29c6b16b85e400f35876a35","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"def rename_vm(session, vm_ref, instance):"},{"line_number":1607,"context_line":"    rename_spec \u003d _get_vm_rename_spec(session.vim.client.factory, instance)"},{"line_number":1608,"context_line":"    reconfigure_vm(session, vm_ref, rename_spec)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a26ad4f_6f04c87d","line":1608,"updated":"2015-10-28 13:13:54.000000000","message":"We should use Rename_Task instead of ReconfigVM_Task for this","commit_id":"9c26448ac99545b002f65bc625e3e5b6689b2e4a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4ebc882a09b23ae724d4dcfcae794fabe7329942","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"def rename_vm(session, vm_ref, instance):"},{"line_number":1607,"context_line":"    rename_spec \u003d _get_vm_rename_spec(session.vim.client.factory, instance)"},{"line_number":1608,"context_line":"    reconfigure_vm(session, vm_ref, rename_spec)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a26ad4f_457f1166","line":1608,"in_reply_to":"1a26ad4f_6f04c87d","updated":"2015-11-01 13:12:28.000000000","message":"Done","commit_id":"9c26448ac99545b002f65bc625e3e5b6689b2e4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"56b00204d93ca77be6d469993be77185be62cd0b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                       profile_spec\u003dNone, metadata\u003dNone):"},{"line_number":212,"context_line":"    \"\"\"Builds the VM Create spec.\"\"\""},{"line_number":213,"context_line":"    config_spec \u003d client_factory.create(\u0027ns0:VirtualMachineConfigSpec\u0027)"},{"line_number":214,"context_line":"    config_spec.name \u003d instance.uuid"},{"line_number":215,"context_line":"    config_spec.guestId \u003d os_type"},{"line_number":216,"context_line":"    # The name is the unique identifier for the VM."},{"line_number":217,"context_line":"    config_spec.instanceUuid \u003d instance.uuid"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_2a931351","line":214,"updated":"2015-12-17 14:55:56.000000000","message":"Why not fix it here, so you don\u0027t need to rename things?","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e3230e1c1bbcad64827154ad0bfd90d8073fbf94","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                       profile_spec\u003dNone, metadata\u003dNone):"},{"line_number":212,"context_line":"    \"\"\"Builds the VM Create spec.\"\"\""},{"line_number":213,"context_line":"    config_spec \u003d client_factory.create(\u0027ns0:VirtualMachineConfigSpec\u0027)"},{"line_number":214,"context_line":"    config_spec.name \u003d instance.uuid"},{"line_number":215,"context_line":"    config_spec.guestId \u003d os_type"},{"line_number":216,"context_line":"    # The name is the unique identifier for the VM."},{"line_number":217,"context_line":"    config_spec.instanceUuid \u003d instance.uuid"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_9b7b1028","line":214,"in_reply_to":"3a7e1126_2a931351","updated":"2015-12-20 08:41:45.000000000","message":"this is actually a very good question - the reason is that this is name that the VC will give to the directory on the datastore. That causes a number of problems. So it is better to do the rename","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3e19eb4358b57152ebc3ac9a7672b9e0388a4865","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                    injected_files, admin_password)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Rename the VM. This is done after the spec is created to ensure"},{"line_number":672,"context_line":"        # that all of the files for the instance ar under the directory"},{"line_number":673,"context_line":"        # \u0027uuid\u0027 of the instance"},{"line_number":674,"context_line":"        vm_util.rename_vm(self._session, vm_ref, instance)"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_685bab55","line":672,"updated":"2015-04-29 15:21:38.000000000","message":"ar -\u003e are","commit_id":"baff988a7f18bbabd8ed53ead18c2b212d56e222"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7936174e4e8be468efa3c7e63223bbb42ed292ce","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                    injected_files, admin_password)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Rename the VM. This is done after the spec is created to ensure"},{"line_number":672,"context_line":"        # that all of the files for the instance ar under the directory"},{"line_number":673,"context_line":"        # \u0027uuid\u0027 of the instance"},{"line_number":674,"context_line":"        vm_util.rename_vm(self._session, vm_ref, instance)"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_78c5b659","line":672,"updated":"2015-05-12 14:26:02.000000000","message":"s/ar/are","commit_id":"5a4002a5c72763e285e4caf5f2df436f9993dbaa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"56b00204d93ca77be6d469993be77185be62cd0b","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        # Rename the VM. This is done after the spec is created to ensure"},{"line_number":790,"context_line":"        # that all of the files for the instance are under the directory"},{"line_number":791,"context_line":"        # \u0027uuid\u0027 of the instance"},{"line_number":792,"context_line":"        vm_util.rename_vm(self._session, vm_ref, instance)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        vm_util.power_on_instance(self._session, instance, vm_ref\u003dvm_ref)"},{"line_number":795,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_2e87aab6","line":792,"updated":"2015-12-17 14:55:56.000000000","message":"Could you not just set the correct name in the first place? I think that is here:\nhttps://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L211","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e3230e1c1bbcad64827154ad0bfd90d8073fbf94","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        # Rename the VM. This is done after the spec is created to ensure"},{"line_number":790,"context_line":"        # that all of the files for the instance are under the directory"},{"line_number":791,"context_line":"        # \u0027uuid\u0027 of the instance"},{"line_number":792,"context_line":"        vm_util.rename_vm(self._session, vm_ref, instance)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        vm_util.power_on_instance(self._session, instance, vm_ref\u003dvm_ref)"},{"line_number":795,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_fb901445","line":792,"in_reply_to":"3a7e1126_2e87aab6","updated":"2015-12-20 08:41:45.000000000","message":"that has all kinds of implications for instances on the backend. it is preferable to leave that unchanged","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"56b00204d93ca77be6d469993be77185be62cd0b","unresolved":false,"context_lines":[{"line_number":1917,"context_line":"    def list_instances(self):"},{"line_number":1918,"context_line":"        \"\"\"Lists the VM instances that are registered with vCenter cluster.\"\"\""},{"line_number":1919,"context_line":"        properties \u003d [\u0027runtime.connectionState\u0027,"},{"line_number":1920,"context_line":"                      \u0027config.extraConfig[\"nvp.vm-uuid\"]\u0027]"},{"line_number":1921,"context_line":"        LOG.debug(\"Getting list of instances from cluster %s\","},{"line_number":1922,"context_line":"                  self._cluster)"},{"line_number":1923,"context_line":"        vms \u003d []"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a7e1126_249fcab5","line":1920,"updated":"2015-12-17 14:55:56.000000000","message":"went to check now long we have been setting this, it seems since 2013:\nhttps://github.com/openstack/nova/commit/ac7188f330683ce480b7b362997ec88b151b9749\n\nSo I guess that should be fine for most folks.","commit_id":"2fc9a5fc7216efdf3cd017fc945fb341d963e55d"}]}