)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"53c669e265fe2616e0c44cc220a2bd944e070688","unresolved":false,"context_lines":[{"line_number":924,"context_line":"            # check if the instance was fully spawned."},{"line_number":925,"context_line":"            current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":926,"context_line":"            if (current_power_state \u003d\u003d power_state.RUNNING and"},{"line_number":927,"context_line":"                instance.task_state \u003d\u003d task_states.SPAWNING):"},{"line_number":928,"context_line":"                # Instance was fully spawned - set the states."},{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_325cd124","line":927,"updated":"2015-04-02 13:26:05.000000000","message":"Looking at the libvirt driver only, this does not seem like a safe assumption to make.\n\nThere\u0027s still some stuff that needs to be done after we call virDomainCreateWithFlags in the libvirt driver (although not a lot), and there may be stuff in other drivers as well.","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d18ffe67acf57f5a3993c4d365746aeecc90d665","unresolved":false,"context_lines":[{"line_number":924,"context_line":"            # check if the instance was fully spawned."},{"line_number":925,"context_line":"            current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":926,"context_line":"            if (current_power_state \u003d\u003d power_state.RUNNING and"},{"line_number":927,"context_line":"                instance.task_state \u003d\u003d task_states.SPAWNING):"},{"line_number":928,"context_line":"                # Instance was fully spawned - set the states."},{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_81ac3f36","line":927,"in_reply_to":"baa041b7_325cd124","updated":"2015-04-08 10:45:16.000000000","message":"I don\u0027t understand, can you be more precise? Is calling _get_power_state not enough to determine the instance power state?","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cac13ac880a7484d32244a0e25abd02f30247a6a","unresolved":false,"context_lines":[{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":931,"context_line":"                instance.task_state \u003d None"},{"line_number":932,"context_line":"                instance.launched_at \u003d timeutils.utcnow()"},{"line_number":933,"context_line":"                instance.save()"},{"line_number":934,"context_line":"                return"},{"line_number":935,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_466f672b","line":932,"updated":"2015-03-25 16:19:45.000000000","message":"suspect this will make the launch_at to  compute service start up\nit maybe not accurate ...","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a4aac5c76e599ebbf4b4f790c7d2624ff3f5642d","unresolved":false,"context_lines":[{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":931,"context_line":"                instance.task_state \u003d None"},{"line_number":932,"context_line":"                instance.launched_at \u003d timeutils.utcnow()"},{"line_number":933,"context_line":"                instance.save()"},{"line_number":934,"context_line":"                return"},{"line_number":935,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_3c8835e7","line":932,"in_reply_to":"1a6ced46_466f672b","updated":"2015-04-02 07:25:45.000000000","message":"why we need update instance.launched_at manually ?","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d6497057020af6a21f13302f2bbcc10cb7d7b3bb","unresolved":false,"context_lines":[{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":931,"context_line":"                instance.task_state \u003d None"},{"line_number":932,"context_line":"                instance.launched_at \u003d timeutils.utcnow()"},{"line_number":933,"context_line":"                instance.save()"},{"line_number":934,"context_line":"                return"},{"line_number":935,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_b17c03b6","line":932,"in_reply_to":"9aa53dc9_21321311","updated":"2015-04-09 09:31:37.000000000","message":"Actually, this has to be set here manually, because it\u0027s later checked when making API calls.\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L193","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d18ffe67acf57f5a3993c4d365746aeecc90d665","unresolved":false,"context_lines":[{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":931,"context_line":"                instance.task_state \u003d None"},{"line_number":932,"context_line":"                instance.launched_at \u003d timeutils.utcnow()"},{"line_number":933,"context_line":"                instance.save()"},{"line_number":934,"context_line":"                return"},{"line_number":935,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_21321311","line":932,"in_reply_to":"baa041b7_3c8835e7","updated":"2015-04-08 10:45:16.000000000","message":"To avoid any confusion, I think it\u0027s safe to skip setting the launched_at time at this point.","commit_id":"8d98f00cec0db3b180987acd9525bbccc2b609a1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7768a04cb6f2e580be0c04085dffa571d7607527","unresolved":false,"context_lines":[{"line_number":924,"context_line":"            # check if the instance was fully spawned."},{"line_number":925,"context_line":"            current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":926,"context_line":"            if (current_power_state \u003d\u003d power_state.RUNNING and"},{"line_number":927,"context_line":"                instance.task_state \u003d\u003d task_states.SPAWNING):"},{"line_number":928,"context_line":"                # Instance was fully spawned - set the states."},{"line_number":929,"context_line":"                instance.power_state \u003d current_power_state"},{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_b56fc491","line":927,"updated":"2015-04-11 23:21:13.000000000","message":"After the instance was create, there still need waiting for event from neutron ensure the network is ready,https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4378 \n\nMaybe we should ensure the network is real ready.","commit_id":"fb4d54844165c76939c83362a81ddab264d41edd"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7768a04cb6f2e580be0c04085dffa571d7607527","unresolved":false,"context_lines":[{"line_number":930,"context_line":"                instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":931,"context_line":"                instance.task_state \u003d None"},{"line_number":932,"context_line":"                instance.launched_at \u003d timeutils.utcnow()"},{"line_number":933,"context_line":"                instance.save()"},{"line_number":934,"context_line":"                return"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"            # NOTE(dave-mcnally) compute stopped before instance was fully"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_350a94d3","line":933,"updated":"2015-04-11 23:21:13.000000000","message":"Emm...I think more than just change the status. For example https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2361","commit_id":"fb4d54844165c76939c83362a81ddab264d41edd"}]}