)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"252a5eb773dfff630ee4b098b1acca9237822623","unresolved":false,"context_lines":[{"line_number":3025,"context_line":"                    volume_id\u003dvolume_id, mountpoint\u003ddevice, bdm\u003dvolume_bdm)"},{"line_number":3026,"context_line":"        except Exception:"},{"line_number":3027,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3028,"context_line":"                volume_bdm \u003d objects.BlockDeviceMapping.get_by_volume_id("},{"line_number":3029,"context_line":"                               context, volume_id, expected_attrs\u003d[\u0027instance\u0027])"},{"line_number":3030,"context_line":"                if volume_bdm is not None:"},{"line_number":3031,"context_line":"                    volume_bdm.destroy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_2db17e8f","line":3028,"updated":"2015-03-25 07:46:54.000000000","message":"if line 3018 succeeds then there is no need to call the get_by_volume_id.\nCan you set tge volume_dbm to None prior to 3018 and then check accordingly?","commit_id":"fbf78f24257fb9f350ce7341eeb7f5628ed897b4"},{"author":{"_account_id":8922,"name":"haruka tanizawa","email":"h-tanizawa@intellilink.co.jp","username":"h-tanizawa"},"change_message_id":"1c8e34d5c3284811b5acdbf29cad1b366ae4799b","unresolved":false,"context_lines":[{"line_number":3025,"context_line":"                    volume_id\u003dvolume_id, mountpoint\u003ddevice, bdm\u003dvolume_bdm)"},{"line_number":3026,"context_line":"        except Exception:"},{"line_number":3027,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3028,"context_line":"                volume_bdm \u003d objects.BlockDeviceMapping.get_by_volume_id("},{"line_number":3029,"context_line":"                               context, volume_id, expected_attrs\u003d[\u0027instance\u0027])"},{"line_number":3030,"context_line":"                if volume_bdm is not None:"},{"line_number":3031,"context_line":"                    volume_bdm.destroy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_206985be","line":3028,"in_reply_to":"1a6ced46_2db17e8f","updated":"2015-03-25 07:56:34.000000000","message":"Ah, yes. That is best.\nThanks for your review. I fix this.","commit_id":"fbf78f24257fb9f350ce7341eeb7f5628ed897b4"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"252a5eb773dfff630ee4b098b1acca9237822623","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"    @object_compat"},{"line_number":4706,"context_line":"    @wrap_exception()"},{"line_number":4707,"context_line":"    @wrap_instance_fault"},{"line_number":4708,"context_line":"    def unreserve_block_device_name(self, context, instance, device,"},{"line_number":4709,"context_line":"                                    volume_id, return_bdm_object\u003dFalse):"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        @utils.synchronized(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_0d49228b","line":4708,"updated":"2015-03-25 07:46:54.000000000","message":"why do we not pass the volume_bdm object as a parameter?","commit_id":"fbf78f24257fb9f350ce7341eeb7f5628ed897b4"},{"author":{"_account_id":8922,"name":"haruka tanizawa","email":"h-tanizawa@intellilink.co.jp","username":"h-tanizawa"},"change_message_id":"1c8e34d5c3284811b5acdbf29cad1b366ae4799b","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"    @object_compat"},{"line_number":4706,"context_line":"    @wrap_exception()"},{"line_number":4707,"context_line":"    @wrap_instance_fault"},{"line_number":4708,"context_line":"    def unreserve_block_device_name(self, context, instance, device,"},{"line_number":4709,"context_line":"                                    volume_id, return_bdm_object\u003dFalse):"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        @utils.synchronized(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_60ba9d24","line":4708,"in_reply_to":"1a6ced46_0d49228b","updated":"2015-03-25 07:56:34.000000000","message":"Oh, this is also, your idea is better. Thank you.","commit_id":"fbf78f24257fb9f350ce7341eeb7f5628ed897b4"}]}