)]}'
{"nova/tests/integrated/test_api_samples.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d43ba8daafb1e41cd6137c40f2dec17357a9ac23","unresolved":false,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":""},{"line_number":1488,"context_line":"class ConsolesSampleXmlTests(ConsolesSampleJsonTests):"},{"line_number":1489,"context_line":"        ctype \u003d \u0027xml\u0027"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"class DeferredDeleteSampleJsonTests(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fyrw%3D","line":1489,"updated":"2012-11-23 02:53:47.000000000","message":"I would do such things in a different patch. Just suggesting","commit_id":"9d77ecdff96081933526288e4c832816fe2bcfeb"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d43ba8daafb1e41cd6137c40f2dec17357a9ac23","unresolved":false,"context_lines":[{"line_number":1501,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % uuid)"},{"line_number":1502,"context_line":"        self.assertEqual(response.status, 204)"},{"line_number":1503,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        # test restore"},{"line_number":1506,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1507,"context_line":"                                 \u0027restore-post-req\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FyoY%3D","line":1504,"updated":"2012-11-23 02:53:47.000000000","message":"you could put the lines above that seems to repeat on  both tests as requirements in a setup method","commit_id":"9d77ecdff96081933526288e4c832816fe2bcfeb"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d43ba8daafb1e41cd6137c40f2dec17357a9ac23","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"        # test restore"},{"line_number":1506,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1507,"context_line":"                                 \u0027restore-post-req\u0027,"},{"line_number":1508,"context_line":"                                {\u0027action\u0027: \u0027os-restore\u0027})"},{"line_number":1509,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1510,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fyos%3D","line":1508,"updated":"2012-11-23 02:53:47.000000000","message":"this arguement \"{\u0027action\u0027: \u0027os-restore\u0027}\" is really necessary? I tested it briefly and it seems to work with {} and since there are no replacements on the tpl files, I dont think they\u0027re necessary here","commit_id":"9d77ecdff96081933526288e4c832816fe2bcfeb"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d43ba8daafb1e41cd6137c40f2dec17357a9ac23","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"        # test delete"},{"line_number":1517,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % uuid)"},{"line_number":1518,"context_line":"        self.assertEqual(response.status, 204)"},{"line_number":1519,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"        # test restore"},{"line_number":1522,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fyoc%3D","line":1519,"updated":"2012-11-23 02:53:47.000000000","message":"setup method ^","commit_id":"9d77ecdff96081933526288e4c832816fe2bcfeb"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d43ba8daafb1e41cd6137c40f2dec17357a9ac23","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"        # test restore"},{"line_number":1522,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1523,"context_line":"                                 \u0027force-delete-post-req\u0027,"},{"line_number":1524,"context_line":"                                {\u0027action\u0027: \u0027os-forceDelete\u0027})"},{"line_number":1525,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1526,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1527,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fyoo%3D","line":1524,"updated":"2012-11-23 02:53:47.000000000","message":"idem L1508","commit_id":"9d77ecdff96081933526288e4c832816fe2bcfeb"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3c6c255d15813b5cee3ee0183a902e734bbc629e","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"    extension_name \u003d (\"nova.api.openstack.compute.contrib\""},{"line_number":1494,"context_line":"                                     \".deferred_delete.Deferred_delete\")"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def createDeletedServer(self):"},{"line_number":1497,"context_line":"        self.flags(reclaim_instance_interval\u003d1)"},{"line_number":1498,"context_line":"        self.uuid \u003d self._post_server()"},{"line_number":1499,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2Fx80%3D","line":1496,"updated":"2012-11-25 17:38:42.000000000","message":"Suggestion: this method should be called setUp as you did on patchset 2 and 3, and you don\u0027t need to call it on the tests, I mean: setUp method is automatically called before each test","commit_id":"d65cd4bf704f654cfca1689964a522d8e4c9c0f9"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3c6c255d15813b5cee3ee0183a902e734bbc629e","unresolved":false,"context_lines":[{"line_number":1503,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"    def test_restore(self):"},{"line_number":1506,"context_line":"        self.createDeletedServer()"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"        # test restore"},{"line_number":1509,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2Fx8w%3D","line":1506,"updated":"2012-11-25 17:38:42.000000000","message":"If you renname createDeletedServer to setUp you don\u0027t need to call it here.","commit_id":"d65cd4bf704f654cfca1689964a522d8e4c9c0f9"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3c6c255d15813b5cee3ee0183a902e734bbc629e","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        # test restore"},{"line_number":1509,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"},{"line_number":1510,"context_line":"                                 \u0027restore-post-req\u0027,"},{"line_number":1511,"context_line":"                                 {})"},{"line_number":1512,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1513,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1514,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2Fx8s%3D","line":1511,"updated":"2012-11-25 17:38:42.000000000","message":"Suggestion: put {} on the prior line since it doesn\u0027t have more than 80 chars","commit_id":"d65cd4bf704f654cfca1689964a522d8e4c9c0f9"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3c6c255d15813b5cee3ee0183a902e734bbc629e","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"        # test force delete"},{"line_number":1519,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"},{"line_number":1520,"context_line":"                                 \u0027force-delete-post-req\u0027,"},{"line_number":1521,"context_line":"                                 {})"},{"line_number":1522,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1523,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1524,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2Fx8o%3D","line":1521,"updated":"2012-11-25 17:38:42.000000000","message":"same as line 1511","commit_id":"d65cd4bf704f654cfca1689964a522d8e4c9c0f9"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"e6312f005f4eed88de53e07bdcef5b02797c242e","unresolved":false,"context_lines":[{"line_number":1496,"context_line":"    def setUp(self):"},{"line_number":1497,"context_line":"        super(DeferredDeleteSampleJsonTests, self).setUp()"},{"line_number":1498,"context_line":"        self.flags(reclaim_instance_interval\u003d1)"},{"line_number":1499,"context_line":"        self.uuid \u003d self._post_server()"},{"line_number":1500,"context_line":""},{"line_number":1501,"context_line":"        # test delete"},{"line_number":1502,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % self.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2Fus8%3D","line":1499,"updated":"2012-11-28 12:08:38.000000000","message":"You should do _post_server() in each test since it involves some assertion checks - don\u0027t think they belong in setUp()","commit_id":"eaadb7510962a51d2ffa8c7c407081590d647347"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"e6312f005f4eed88de53e07bdcef5b02797c242e","unresolved":false,"context_lines":[{"line_number":1501,"context_line":"        # test delete"},{"line_number":1502,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % self.uuid)"},{"line_number":1503,"context_line":"        self.assertEqual(response.status, 204)"},{"line_number":1504,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"    def test_restore(self):"},{"line_number":1507,"context_line":"        # test restore"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2Fus4%3D","line":1504,"updated":"2012-11-28 12:08:38.000000000","message":"This should be a separate test","commit_id":"eaadb7510962a51d2ffa8c7c407081590d647347"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"e6312f005f4eed88de53e07bdcef5b02797c242e","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"        self.assertEqual(response.read(), \u0027\u0027)"},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"    def test_restore(self):"},{"line_number":1507,"context_line":"        # test restore"},{"line_number":1508,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"},{"line_number":1509,"context_line":"                                 \u0027restore-post-req\u0027, {})"},{"line_number":1510,"context_line":"        self.assertEqual(response.status, 202)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2Fus0%3D","line":1507,"updated":"2012-11-28 12:08:38.000000000","message":"These commends don\u0027t add anything useful, you can remove them","commit_id":"eaadb7510962a51d2ffa8c7c407081590d647347"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"ebb85e7d1301f6300f44fa96f33cc889830b0244","unresolved":false,"context_lines":[{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    def test_restore(self):"},{"line_number":1676,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1677,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % uuid)"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1680,"context_line":"                                 \u0027restore-post-req\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F%2FiI%3D","line":1677,"updated":"2012-12-03 14:29:47.000000000","message":"**if** you\u0027ll re-submit this for some other reason I would put theses 2 lines in a method like self._create_and_delete_server(), I would prefer even more in setUp, but someone else (not sure who) already asked you to move them from there... but do this only if you re-submit the patch... +1 already \u003d)","commit_id":"25325153ae0172082369ea03dfbeddc4c35e473b"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"ebb85e7d1301f6300f44fa96f33cc889830b0244","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"    def test_force_delete(self):"},{"line_number":1685,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1686,"context_line":"        response \u003d self._do_delete(\u0027servers/%s\u0027 % uuid)"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1689,"context_line":"                                 \u0027force-delete-post-req\u0027, {})"},{"line_number":1690,"context_line":"        self.assertEqual(response.status, 202)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F%2FiE%3D","line":1687,"updated":"2012-12-03 14:29:47.000000000","message":"if you do the suggestion on 1677, call the method here","commit_id":"25325153ae0172082369ea03dfbeddc4c35e473b"}]}