)]}'
{"nova/tests/unit/virt/vmwareapi/test_vm_util.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5deabafa23b3c229181687437b9e66f00e9d97d4","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"                          cpu_limits.validate)"},{"line_number":1199,"context_line":"        cpu_limits \u003d vm_util.CpuLimits(cpu_shares_level\u003d\u0027fira\u0027)"},{"line_number":1200,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1201,"context_line":"                          cpu_limits.validate)"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"@mock.patch.object(driver.VMwareAPISession, \u0027vim\u0027, stubs.fake_vim_prop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_ea59f68f","line":1201,"updated":"2015-03-28 09:30:42.000000000","message":"you should also add the \u0027custom\u0027 case. Also, maybe add the case(s) I\u0027ve mentioned in my other comment in vm_util.py.","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20d1f5045c40bea58f18464cbd23a8348fbb4a5e","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"                          cpu_limits.validate)"},{"line_number":1199,"context_line":"        cpu_limits \u003d vm_util.CpuLimits(cpu_shares_level\u003d\u0027fira\u0027)"},{"line_number":1200,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1201,"context_line":"                          cpu_limits.validate)"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"@mock.patch.object(driver.VMwareAPISession, \u0027vim\u0027, stubs.fake_vim_prop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_92371db0","line":1201,"in_reply_to":"baa041b7_47632e1b","updated":"2015-04-02 13:39:24.000000000","message":"Regarding the test cases:\nIf the cpu_shares_share is not an integer then this will fail when the flavor extra specs is read - here we read an int (https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L274)\nA cpu_shares_share set as None is a valid value - this is the same as 0 (that is, the VC has it as a valid value)","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ee6303430605a1a3bf97d6984042b230adf17b7d","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"                          cpu_limits.validate)"},{"line_number":1199,"context_line":"        cpu_limits \u003d vm_util.CpuLimits(cpu_shares_level\u003d\u0027fira\u0027)"},{"line_number":1200,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1201,"context_line":"                          cpu_limits.validate)"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"@mock.patch.object(driver.VMwareAPISession, \u0027vim\u0027, stubs.fake_vim_prop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_47632e1b","line":1201,"in_reply_to":"da9b358b_2f1248b5","updated":"2015-04-02 00:09:36.000000000","message":"What about a case where the user sets cpu_shares_shares to some integer value and does not set cpu_shares_level? Similarly, what about a case where the user sets cpu_shares_shares to some non-integer value and cpu_shares_level to \u0027custom\u0027? What about the case where the user sets the cpu_shares_shares to a non-integer value and leaves the cpu_shares_level as None?","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9db624f5912936170755cff7d975f8d5247d2363","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"                          cpu_limits.validate)"},{"line_number":1199,"context_line":"        cpu_limits \u003d vm_util.CpuLimits(cpu_shares_level\u003d\u0027fira\u0027)"},{"line_number":1200,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1201,"context_line":"                          cpu_limits.validate)"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"@mock.patch.object(driver.VMwareAPISession, \u0027vim\u0027, stubs.fake_vim_prop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_2f1248b5","line":1201,"in_reply_to":"da9b358b_ea59f68f","updated":"2015-03-29 04:45:34.000000000","message":"custom is tested in previous tests where the type is validated. this test case is for assertions that are raised","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5deabafa23b3c229181687437b9e66f00e9d97d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return"},{"line_number":71,"context_line":"        if self.cpu_shares_level \u003d\u003d \u0027custom\u0027:"},{"line_number":72,"context_line":"            return"},{"line_number":73,"context_line":"        if self.cpu_shares_level:"},{"line_number":74,"context_line":"            reason \u003d _(\"Share \u0027%s\u0027 is not supported\") % self.cpu_shares_level"},{"line_number":75,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_aa6d2e34","line":73,"updated":"2015-03-28 09:30:42.000000000","message":"It seems to me that self.cpu_shares_level can also be None (as I can see from __init__) or \"\", as given as argument. This case doesn\u0027t seem to be treated. Are those values ok?","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9db624f5912936170755cff7d975f8d5247d2363","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return"},{"line_number":71,"context_line":"        if self.cpu_shares_level \u003d\u003d \u0027custom\u0027:"},{"line_number":72,"context_line":"            return"},{"line_number":73,"context_line":"        if self.cpu_shares_level:"},{"line_number":74,"context_line":"            reason \u003d _(\"Share \u0027%s\u0027 is not supported\") % self.cpu_shares_level"},{"line_number":75,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_4f46acc0","line":73,"in_reply_to":"da9b358b_aa6d2e34","updated":"2015-03-29 04:45:34.000000000","message":"None is a valid value here. If None is passed to the instance configuration then the VC sets this to the default value which is 0","commit_id":"d3a447cb0bab790b13053403aed947c3d8aa31c3"}]}