)]}'
{"nova/compute/api.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"71e30c53d228c231821ebbcc3b148345f7f86969","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2321,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2322,"context_line":"                orig_image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2323,"context_line":"                    instance.system_metadata)"},{"line_number":2324,"context_line":"                if strutils.bool_from_string(orig_image_meta[\u0027properties\u0027].get("},{"line_number":2325,"context_line":"                        \u0027os_require_quiesce\u0027)):"},{"line_number":2326,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_c1493cd2","line":2323,"updated":"2015-10-19 11:30:20.000000000","message":"why we didn\u0027t use ImageMeta obj at here, as we already nova object, we should avoid to use dict anymore","commit_id":"9f7ef53b3a58cd160d77e9e6e445cacb5accadb2"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"efe46917ed2c40b0c37d942c4c668284918488e0","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2321,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2322,"context_line":"                orig_image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2323,"context_line":"                    instance.system_metadata)"},{"line_number":2324,"context_line":"                if strutils.bool_from_string(orig_image_meta[\u0027properties\u0027].get("},{"line_number":2325,"context_line":"                        \u0027os_require_quiesce\u0027)):"},{"line_number":2326,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_60f6e6d8","line":2323,"in_reply_to":"3a29b11f_27e5a008","updated":"2015-10-20 11:21:23.000000000","message":"Actually I agree with this one too - It would be best to use the object methods for this.","commit_id":"9f7ef53b3a58cd160d77e9e6e445cacb5accadb2"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"3156a2f6ce7f4b8de6c32c78177c15e5127fe553","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2321,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2322,"context_line":"                orig_image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2323,"context_line":"                    instance.system_metadata)"},{"line_number":2324,"context_line":"                if strutils.bool_from_string(orig_image_meta[\u0027properties\u0027].get("},{"line_number":2325,"context_line":"                        \u0027os_require_quiesce\u0027)):"},{"line_number":2326,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_ffd90ff4","line":2323,"in_reply_to":"3a29b11f_60f6e6d8","updated":"2015-12-02 11:29:58.000000000","message":"What is the best way to get the value of the key \"os_require_quiesce\" from CoercedDict (instance.system_metadata)?","commit_id":"9f7ef53b3a58cd160d77e9e6e445cacb5accadb2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"7d8973458c9dfa6320e32a2c5e2c26d87f4efd64","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2321,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2322,"context_line":"                orig_image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2323,"context_line":"                    instance.system_metadata)"},{"line_number":2324,"context_line":"                if strutils.bool_from_string(orig_image_meta[\u0027properties\u0027].get("},{"line_number":2325,"context_line":"                        \u0027os_require_quiesce\u0027)):"},{"line_number":2326,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_27e5a008","line":2323,"in_reply_to":"3a29b11f_c1493cd2","updated":"2015-10-19 11:50:06.000000000","message":"Agreed","commit_id":"9f7ef53b3a58cd160d77e9e6e445cacb5accadb2"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"e07d81fd67fa0a0119d539e499eb2652e3b93130","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2321,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2322,"context_line":"                orig_image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2323,"context_line":"                    instance.system_metadata)"},{"line_number":2324,"context_line":"                if strutils.bool_from_string(orig_image_meta[\u0027properties\u0027].get("},{"line_number":2325,"context_line":"                        \u0027os_require_quiesce\u0027)):"},{"line_number":2326,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_7d6ba0f1","line":2323,"in_reply_to":"9a8ffd7b_ffd90ff4","updated":"2015-12-14 05:53:58.000000000","message":"Done","commit_id":"9f7ef53b3a58cd160d77e9e6e445cacb5accadb2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"eeab91d5e89b7848b0ac17e1d4666d3db24fccba","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"                    exception.QemuGuestAgentNotEnabled,"},{"line_number":2320,"context_line":"                    exception.NovaException, NotImplementedError) as err:"},{"line_number":2321,"context_line":"                if strutils.bool_from_string(instance.system_metadata.get("},{"line_number":2322,"context_line":"                        \u0027image_os_require_quiesce\u0027)):"},{"line_number":2323,"context_line":"                    raise"},{"line_number":2324,"context_line":"                else:"},{"line_number":2325,"context_line":"                    LOG.info(_LI(\u0027Skipping quiescing instance: \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_c40bd8d4","line":2322,"updated":"2016-01-14 20:02:06.000000000","message":"It should also have been possible to use the properties.os_require_quiesce.","commit_id":"5fe5c2b42ff53e0df6e0e420cca3320b862b5fa0"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"a322bf2806c8f0cfeed9d8e29795688a3b87ba4f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            \"disk_format\": \"raw\","},{"line_number":630,"context_line":"        }"},{"line_number":631,"context_line":"        self.image_service \u003d nova.tests.unit.image.fake.stub_out_image_service("},{"line_number":632,"context_line":"                self)"},{"line_number":633,"context_line":"        self.device_xml_tmpl \u003d \"\"\""},{"line_number":634,"context_line":"        \u003cdomain type\u003d\u0027kvm\u0027\u003e"},{"line_number":635,"context_line":"          \u003cdevices\u003e"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_8d3fcfd5","line":632,"range":{"start_line":632,"start_character":16,"end_line":632,"end_character":20},"updated":"2016-01-18 09:10:52.000000000","message":"Changed here to \u0027self\u0027 from \u0027self.stubs\u0027.","commit_id":"527d17e98f26ed5ab592f3840328ba6d188fe451"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8aead736f375ef488b16762438963e66af4cf882","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"            self._set_quiesced(context, instance, image_meta, True)"},{"line_number":1563,"context_line":"            quiesced \u003d True"},{"line_number":1564,"context_line":"        except (exception.InstanceQuiesceNotSupported,"},{"line_number":1565,"context_line":"                exception.NovaException) as err:"},{"line_number":1566,"context_line":"            if image_meta.properties.get(\u0027os_require_quiesce\u0027, False):"},{"line_number":1567,"context_line":"                raise"},{"line_number":1568,"context_line":"            LOG.info(_LI(\u0027Skipping quiescing instance: %(reason)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_e45a4d50","line":1565,"updated":"2015-10-12 15:48:29.000000000","message":"Should we be catching QemuGuestAgentNotEnabled here as well as _set_quiesced can raise it?","commit_id":"68e39cebbc5f54065325ccd632d59f8d98e4c374"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"82cbb8162fc2d1a148b5a2911dd3e9017ab68f2c","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"            self._set_quiesced(context, instance, image_meta, True)"},{"line_number":1563,"context_line":"            quiesced \u003d True"},{"line_number":1564,"context_line":"        except (exception.InstanceQuiesceNotSupported,"},{"line_number":1565,"context_line":"                exception.NovaException) as err:"},{"line_number":1566,"context_line":"            if image_meta.properties.get(\u0027os_require_quiesce\u0027, False):"},{"line_number":1567,"context_line":"                raise"},{"line_number":1568,"context_line":"            LOG.info(_LI(\u0027Skipping quiescing instance: %(reason)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_c025bdc2","line":1565,"in_reply_to":"5a2ca52d_6294f136","updated":"2015-10-13 18:03:43.000000000","message":"Agreed. Removed InstanceQuiesceNotSupported.","commit_id":"68e39cebbc5f54065325ccd632d59f8d98e4c374"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"dfb2781f7cfd6306321e82f70afc80d621989236","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"            self._set_quiesced(context, instance, image_meta, True)"},{"line_number":1563,"context_line":"            quiesced \u003d True"},{"line_number":1564,"context_line":"        except (exception.InstanceQuiesceNotSupported,"},{"line_number":1565,"context_line":"                exception.NovaException) as err:"},{"line_number":1566,"context_line":"            if image_meta.properties.get(\u0027os_require_quiesce\u0027, False):"},{"line_number":1567,"context_line":"                raise"},{"line_number":1568,"context_line":"            LOG.info(_LI(\u0027Skipping quiescing instance: %(reason)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_6294f136","line":1565,"in_reply_to":"7a2fa921_d0ca6b6e","updated":"2015-10-13 17:14:02.000000000","message":"you are right, but so is InstanceQuiesceNotSupported - so I suggest either remove it or add the other one (probably best to just remove it and even better to remove raising of such general exceptions but not really required for this patch).\n\nIt\u0027s just confusing this way to the reader of the code if nothing else.","commit_id":"68e39cebbc5f54065325ccd632d59f8d98e4c374"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"0d95b6d756f5be7cf3167d3cffbe9921aedac3e4","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"            self._set_quiesced(context, instance, image_meta, True)"},{"line_number":1563,"context_line":"            quiesced \u003d True"},{"line_number":1564,"context_line":"        except (exception.InstanceQuiesceNotSupported,"},{"line_number":1565,"context_line":"                exception.NovaException) as err:"},{"line_number":1566,"context_line":"            if image_meta.properties.get(\u0027os_require_quiesce\u0027, False):"},{"line_number":1567,"context_line":"                raise"},{"line_number":1568,"context_line":"            LOG.info(_LI(\u0027Skipping quiescing instance: %(reason)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_d0ca6b6e","line":1565,"in_reply_to":"7a2fa921_e45a4d50","updated":"2015-10-12 16:54:05.000000000","message":"QemuGuestAgentNotEnabled is a descendant of NovaException, so it will be caught.","commit_id":"68e39cebbc5f54065325ccd632d59f8d98e4c374"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"71e30c53d228c231821ebbcc3b148345f7f86969","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"        require_quiesce \u003d image_meta.properties.get("},{"line_number":1561,"context_line":"            \u0027os_require_quiesce\u0027, False)"},{"line_number":1562,"context_line":"        if require_quiesce:"},{"line_number":1563,"context_line":"            self.quiesce(context, instance, image_meta)"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"        try:"},{"line_number":1566,"context_line":"            # NOTE (rmk): blockRebase cannot be executed on persistent"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_012654ce","side":"PARENT","line":1563,"updated":"2015-10-19 11:30:20.000000000","message":"I\u0027m thinking we should fix \u0027quiesce\u0027, otherwise if we just use _set_quiesced\u0027, the \u0027quiesce\u0027 looks like useless anymore https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1516","commit_id":"78b1728a4b1f043f6b8d78bdd78ebf544b24de81"}]}