)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b68eaee2eb47997ea51fdfc83ddc17f7960327d3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"exception should be avoided and logged."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie0bba032615d3da06cdd95b221beb37a9b8a377d"},{"line_number":17,"context_line":"Closes-bug: #1436693"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5ad0253b_82059fc3","line":17,"updated":"2015-04-29 12:55:36.000000000","message":"It\u0027s Related-To or Partial-Closes but you actually do not fix the issue.","commit_id":"3301177c06b41aec1e33c2b03d28d92159578c06"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c3d8d76fcba98ae4bcc3d79ae75dca7e420b838","unresolved":false,"context_lines":[{"line_number":14,"context_line":"exception should be avoided and logged."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie0bba032615d3da06cdd95b221beb37a9b8a377d"},{"line_number":17,"context_line":"Closes-bug: #1436693"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_3b12120a","line":17,"updated":"2015-05-09 07:40:09.000000000","message":"s/Closes-Bug/Related-Bug","commit_id":"8e140a5d4cda842c9ef33864dfc5871975cb578e"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"7cd93cfdcf0f84c44b0278acc655a725ce616d9f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"exception should be avoided and logged."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie0bba032615d3da06cdd95b221beb37a9b8a377d"},{"line_number":17,"context_line":"Closes-bug: #1436693"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9af37de9_cc9d1e5b","line":17,"in_reply_to":"1aca2d91_3b12120a","updated":"2015-05-11 04:05:13.000000000","message":"Thank you for your comment.\n\nI intend that Bug #1436693 is for \"nova delete\".\n\nAs an alternative idea, Shall I register to Launchpad another related bug report for the root cause which is probably at \"nova boot\"?","commit_id":"8e140a5d4cda842c9ef33864dfc5871975cb578e"}],"nova/compute/api.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"644f0d659b1f75bdbfb4820d22567a02cd9323bc","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(\"Info cache for instance could not found. \""},{"line_number":1754,"context_line":"                        \"Ignore.\", instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_259de1bc","line":1753,"updated":"2015-03-26 10:16:38.000000000","message":"%(instance) is absent","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"589f81151237c55d0967e5c1fc00c935fe5c608d","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(\"Info cache for instance could not found. \""},{"line_number":1754,"context_line":"                        \"Ignore.\", instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_4f383cef","line":1753,"updated":"2015-03-26 09:49:10.000000000","message":"missing log hint _LW","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"29ce50162cf6aa27a744e8b2399b413914831bef","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(\"Info cache for instance could not found. \""},{"line_number":1754,"context_line":"                        \"Ignore.\", instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_3c871863","line":1753,"in_reply_to":"1a6ced46_259de1bc","updated":"2015-03-27 06:31:44.000000000","message":"Thanks for your reviewing. \nAs ken\u0027ichi written, the argument \"instance\u003dinstance\" is for oslo.log.\nBut I have made a mistake in the message. I will correct the message as \"Info cache for instance could not be found.\".","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"edf771ceebcbb8937191eece09b9043f3a8fbf87","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(\"Info cache for instance could not found. \""},{"line_number":1754,"context_line":"                        \"Ignore.\", instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_0a12cd62","line":1753,"in_reply_to":"1a6ced46_259de1bc","updated":"2015-03-26 22:02:53.000000000","message":"garyk is right, we need _LW line the other LOG.warning calls.\n\nbut I don\u0027t think %(instance) is necessary in the message because the above line 1749 also doesn\u0027t contain and oslo.log uses the keyword \"instance\" for formatting.\n\nhttps://github.com/openstack/oslo.log/blob/master/oslo_log/formatters.py#L176","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"29ce50162cf6aa27a744e8b2399b413914831bef","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(\"Info cache for instance could not found. \""},{"line_number":1754,"context_line":"                        \"Ignore.\", instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_1c57b403","line":1753,"in_reply_to":"1a6ced46_4f383cef","updated":"2015-03-27 06:31:44.000000000","message":"Thanks for your reviewing, I will fix it in the next patch.","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f98f385f7f9003374ad1d65bce3a8244cea33797","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1749,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_5082b101","line":1751,"updated":"2015-03-30 16:08:45.000000000","message":"instead of this try, can we use following?\n\nif instance.info_cache is not None:\n       instance.info_cache.delete()","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"5e8165dabf6e88400efae228d9d320d8578373e2","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1749,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_9b73a415","line":1751,"in_reply_to":"bab921fb_94e9601d","updated":"2015-04-24 03:32:26.000000000","message":"Thank you for your comment. I got the point.\n\nI will correct the code.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cace6db7c598a4aa8efce9b34e614fae9203b211","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1749,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_63b95fe9","line":1751,"in_reply_to":"da9b358b_5082b101","updated":"2015-03-30 22:39:46.000000000","message":"I also did think the same thing, but I feel \"try:\" is better than \"if ..\" because this is not a normal case and \"try: .. except\" clarifies it.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"d8656c105203ab169093fd532af1f3ccb422b12c","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1749,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_4d056178","line":1751,"in_reply_to":"da9b358b_5082b101","updated":"2015-03-31 03:51:31.000000000","message":"Thank you for your review. I too did think \"try...except\" is more suitable in such the unexpected case.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"183a83289c38b295005c119ba618ae0934f29331","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1749,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_94e9601d","line":1751,"in_reply_to":"da9b358b_63b95fe9","updated":"2015-04-23 10:44:58.000000000","message":"Except... if anything in delete throws an attribute error you can\u0027t distinguish them.\n\nI think the explicit check is better.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f98f385f7f9003374ad1d65bce3a8244cea33797","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_104c2941","line":1753,"updated":"2015-03-30 16:08:45.000000000","message":"nit s/./,/","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cace6db7c598a4aa8efce9b34e614fae9203b211","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_237a3725","line":1753,"in_reply_to":"da9b358b_104c2941","updated":"2015-03-30 22:39:46.000000000","message":"There is a similar message on https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6095 , so \".\" seems good for me.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"d8656c105203ab169093fd532af1f3ccb422b12c","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        try:"},{"line_number":1751,"context_line":"            instance.info_cache.delete()"},{"line_number":1752,"context_line":"        except AttributeError:"},{"line_number":1753,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1754,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"},{"line_number":1755,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1756,"context_line":"            self.notifier, context, instance, \"%s.start\" % delete_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_4d9681f1","line":1753,"in_reply_to":"da9b358b_237a3725","updated":"2015-03-31 03:51:31.000000000","message":"Thanks. Yes, this message is followed to the other similar messages.","commit_id":"38b17b1b51dd0624ea09387291abbb9d7e92d8c8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b68eaee2eb47997ea51fdfc83ddc17f7960327d3","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # TODO(yoshimatsu): When root cause is fixed, the log level"},{"line_number":1725,"context_line":"            # should be reconsidered."},{"line_number":1726,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1727,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ad0253b_c2e7173f","line":1724,"updated":"2015-04-29 12:55:36.000000000","message":"I don\u0027t know if in 1 week when looking at this TODO note we will understand what we have to reconsider\n\nYou should probably link the bug report here then recommend to remove that condition on the method info_cache since when fixed we should just call it.\n\n  # TODO(yoshimatsu): Workaround the issue lp:#12345678, after fixed we\n  # should be able to remove this all block of code\n  if instance.info_cache is not None:\n    ...\n\nHum i\u0027m not really good in english but I guess you catch what i mean here.","commit_id":"3301177c06b41aec1e33c2b03d28d92159578c06"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6bdd6489719f802eff76e1fc91255680835d5561","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # TODO(yoshimatsu): When root cause is fixed, the log level"},{"line_number":1725,"context_line":"            # should be reconsidered."},{"line_number":1726,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1727,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_1fbe6fd4","line":1724,"in_reply_to":"5ad0253b_c2e7173f","updated":"2015-04-30 22:34:22.000000000","message":"I also am not good at English, but sahid\u0027s comment is more understandable for me :)","commit_id":"3301177c06b41aec1e33c2b03d28d92159578c06"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"6d8141733b913515579d20696fd772b8a62cc342","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # TODO(yoshimatsu): When root cause is fixed, the log level"},{"line_number":1725,"context_line":"            # should be reconsidered."},{"line_number":1726,"context_line":"            LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":1727,"context_line":"                            \"Ignore.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_a36f48c4","line":1724,"in_reply_to":"5ad0253b_c2e7173f","updated":"2015-05-03 02:57:54.000000000","message":"Thanks for your comment.\n\nI understood that the meaning of my TODO comment will be unclear for us in the future. \nI will consider correcting the TODO comment. \n\nHowever, the suggestion of my bug report is that Nova should be the fault tolerant. \nSo I think the \"if\" block should not be removed for ever. \n\nHow do you feel about it?\nI need to get everyone\u0027s consent.","commit_id":"3301177c06b41aec1e33c2b03d28d92159578c06"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"85a85cf3c9c99bc226a716cc2a2495208e4e277a","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1720,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # NOTE(yoshimatsu): Avoid AttributeError if instance.info_cache"},{"line_number":1725,"context_line":"            # is None. When the root cause that instance.info_cache becomes"}],"source_content_type":"text/x-python","patch_set":7,"id":"9af37de9_3da73251","line":1722,"updated":"2015-05-11 07:51:00.000000000","message":"From the code of instance destroy, it already include delete info_cache https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1702\n\nSo I\u0027m think why we need remove info_cache before destroy instance.","commit_id":"8e140a5d4cda842c9ef33864dfc5871975cb578e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"663331d68a71921bc5fd130498f513b7f2d7e30d","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1720,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # NOTE(yoshimatsu): Avoid AttributeError if instance.info_cache"},{"line_number":1725,"context_line":"            # is None. When the root cause that instance.info_cache becomes"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_24fbaf7a","line":1722,"in_reply_to":"9a0c5dc1_a8129cb2","updated":"2015-07-29 03:32:39.000000000","message":"Emm...I didn\u0027t find any relationship with heal_instance_info_cache. And this code is added by https://review.openstack.org/#/c/14805/8\n\nBut I still didn\u0027t get why we need remove info cache at here.\n\nAnyway let me remove -1 first. Let see if there is comment from other people.","commit_id":"8e140a5d4cda842c9ef33864dfc5871975cb578e"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"0d0cd127186dc554ecdaeae2955d9169e371cf54","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            LOG.warning(_LW(\"instance\u0027s host %s is down, deleting from \""},{"line_number":1720,"context_line":"                            \"database\"), instance.host, instance\u003dinstance)"},{"line_number":1721,"context_line":"        if instance.info_cache is not None:"},{"line_number":1722,"context_line":"            instance.info_cache.delete()"},{"line_number":1723,"context_line":"        else:"},{"line_number":1724,"context_line":"            # NOTE(yoshimatsu): Avoid AttributeError if instance.info_cache"},{"line_number":1725,"context_line":"            # is None. When the root cause that instance.info_cache becomes"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_a8129cb2","line":1722,"in_reply_to":"9af37de9_3da73251","updated":"2015-05-13 09:00:00.000000000","message":"Thanks for your comment.\n\nThis code exists since grizzly-1.\nIt seems to me that its purpose is to control heal_instance_info_cache\u0027s activities during instance deletion.","commit_id":"8e140a5d4cda842c9ef33864dfc5871975cb578e"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"589f81151237c55d0967e5c1fc00c935fe5c608d","unresolved":false,"context_lines":[{"line_number":2626,"context_line":"            try:"},{"line_number":2627,"context_line":"                instance.info_cache.delete()"},{"line_number":2628,"context_line":"            except AttributeError:"},{"line_number":2629,"context_line":"                LOG.warning(\"Info cache for instance could not found. \""},{"line_number":2630,"context_line":"                            \"Ignore.\", instance\u003dinstance)"},{"line_number":2631,"context_line":""},{"line_number":2632,"context_line":"            # NOTE(vish): We have already deleted the instance, so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_cf234cbb","line":2629,"updated":"2015-03-26 09:49:10.000000000","message":"ditto","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"29ce50162cf6aa27a744e8b2399b413914831bef","unresolved":false,"context_lines":[{"line_number":2626,"context_line":"            try:"},{"line_number":2627,"context_line":"                instance.info_cache.delete()"},{"line_number":2628,"context_line":"            except AttributeError:"},{"line_number":2629,"context_line":"                LOG.warning(\"Info cache for instance could not found. \""},{"line_number":2630,"context_line":"                            \"Ignore.\", instance\u003dinstance)"},{"line_number":2631,"context_line":""},{"line_number":2632,"context_line":"            # NOTE(vish): We have already deleted the instance, so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_bcc1e882","line":2629,"in_reply_to":"1a6ced46_cf234cbb","updated":"2015-03-27 06:31:44.000000000","message":"Thank you. I will fix it in the same way.","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"73aba89ca9799b141e91b571fbf2656e96f3813d","unresolved":false,"context_lines":[{"line_number":2683,"context_line":"            if instance.info_cache is not None:"},{"line_number":2684,"context_line":"                instance.info_cache.delete()"},{"line_number":2685,"context_line":"            else:"},{"line_number":2686,"context_line":"                LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":2687,"context_line":"                                \"Ignore.\"), instance\u003dinstance)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"            # NOTE(vish): We have already deleted the instance, so we have"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab921fb_fa2d9a46","line":2686,"updated":"2015-04-25 17:44:11.000000000","message":"According to the bug report we can be in the case where info_cache is None because something was wrong when the instance was in building.\n\nI think it is probably better to fix where we missed to set info_cache or at worst if we consider to do not fix this case for any reason a log Warning here is not appropriate, Info should be better.\n\nIf i can give my opinion we should find where we missed to set info_cache.","commit_id":"512dbb1aa03da6e5d480dd995ff1093b1c1e7346"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"276f3568f90bb469943de46eb80da698a6252152","unresolved":false,"context_lines":[{"line_number":2683,"context_line":"            if instance.info_cache is not None:"},{"line_number":2684,"context_line":"                instance.info_cache.delete()"},{"line_number":2685,"context_line":"            else:"},{"line_number":2686,"context_line":"                LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":2687,"context_line":"                                \"Ignore.\"), instance\u003dinstance)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"            # NOTE(vish): We have already deleted the instance, so we have"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_9394d837","line":2686,"in_reply_to":"5ad0253b_c8a73b4e","updated":"2015-04-29 12:16:37.000000000","message":"Hum.. We should just start a serie right now to fix the issue :) - I don\u0027t want to block you or something like, if community are OK with what you are providing so I\u0027m OK but instead of adding a new TODO is the base code which will probably never be fixed we should fix start to fix it.","commit_id":"512dbb1aa03da6e5d480dd995ff1093b1c1e7346"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"319ec104c440729d67f5140994f8fadf70da1afb","unresolved":false,"context_lines":[{"line_number":2683,"context_line":"            if instance.info_cache is not None:"},{"line_number":2684,"context_line":"                instance.info_cache.delete()"},{"line_number":2685,"context_line":"            else:"},{"line_number":2686,"context_line":"                LOG.warning(_LW(\"Info cache for instance could not be found. \""},{"line_number":2687,"context_line":"                                \"Ignore.\"), instance\u003dinstance)"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"            # NOTE(vish): We have already deleted the instance, so we have"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_c8a73b4e","line":2686,"in_reply_to":"bab921fb_fa2d9a46","updated":"2015-04-29 12:06:48.000000000","message":"Thank you for your comment.\nI agree with your opinion basically. We should find the root cause.\n\nBut this abnormal case probably depends on the environments.\n\nMy proposal is ...\n\nWhen the root cause is fixed, this log level should be changed to \"Error\".\n\"Warning\" is better for now, until the root cause be fixed.\n\nI\u0027ll write TODO comment.","commit_id":"512dbb1aa03da6e5d480dd995ff1093b1c1e7346"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"589f81151237c55d0967e5c1fc00c935fe5c608d","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1061,"context_line":"                                       self._fake_do_delete)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"    def test_local_delete_without_info_cache(self):"},{"line_number":1064,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"        self.mox.StubOutWithMock(inst, \u0027destroy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_6f109859","line":1063,"updated":"2015-03-26 09:49:10.000000000","message":"Can you please use mock instead of mox for new tests","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"29ce50162cf6aa27a744e8b2399b413914831bef","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1061,"context_line":"                                       self._fake_do_delete)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"    def test_local_delete_without_info_cache(self):"},{"line_number":1064,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"        self.mox.StubOutWithMock(inst, \u0027destroy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_dc4b8c2a","line":1063,"in_reply_to":"1a6ced46_6f109859","updated":"2015-03-27 06:31:44.000000000","message":"Thanks for your comment. I will correct to use mock instead of mox.","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"edf771ceebcbb8937191eece09b9043f3a8fbf87","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1061,"context_line":"                                       self._fake_do_delete)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"    def test_local_delete_without_info_cache(self):"},{"line_number":1064,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"        self.mox.StubOutWithMock(inst, \u0027destroy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_6a039910","line":1063,"in_reply_to":"1a6ced46_6f109859","updated":"2015-03-26 22:02:53.000000000","message":"Yeah, right.","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"},{"author":{"_account_id":7202,"name":"Takenori Yoshimatsu","email":"tak-yoshimatsu@rf.jp.nec.com","username":"yoshimatsu"},"change_message_id":"29ce50162cf6aa27a744e8b2399b413914831bef","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1061,"context_line":"                                       self._fake_do_delete)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"    def test_local_delete_without_info_cache(self):"},{"line_number":1064,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"        self.mox.StubOutWithMock(inst, \u0027destroy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_bc6fa891","line":1063,"in_reply_to":"fa963961_6a039910","updated":"2015-03-27 06:31:44.000000000","message":"Noted with thanks.","commit_id":"ecafc5bcde5f562f9145de21745d82633fe38439"}]}