)]}'
{"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb4346a65a61bbba3007e14cd002b37167176fa6","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                    cpu_pinning\u003d{}),"},{"line_number":1530,"context_line":"                objects.InstanceNUMACell("},{"line_number":1531,"context_line":"                    id\u003d1, cpuset\u003dset([2]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1532,"context_line":"                    cpu_pinning\u003d{}),"},{"line_number":1533,"context_line":"        ])"},{"line_number":1534,"context_line":"        self.context \u003d context.RequestContext(\u0027fake-user\u0027,"},{"line_number":1535,"context_line":"                                              \u0027fake-project\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_1d403533","line":1532,"updated":"2015-03-26 12:51:32.000000000","message":"Put some actual data in this one to change it up, i.e. it should be a dict of integers field, so actually put some values in here.","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"9d8dc8899b5a247171b294f8dbd9d021e27f30ec","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                    cpu_pinning\u003d{}),"},{"line_number":1530,"context_line":"                objects.InstanceNUMACell("},{"line_number":1531,"context_line":"                    id\u003d1, cpuset\u003dset([2]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1532,"context_line":"                    cpu_pinning\u003d{}),"},{"line_number":1533,"context_line":"        ])"},{"line_number":1534,"context_line":"        self.context \u003d context.RequestContext(\u0027fake-user\u0027,"},{"line_number":1535,"context_line":"                                              \u0027fake-project\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_bd5641cc","line":1532,"in_reply_to":"1a6ced46_1d403533","updated":"2015-03-26 13:11:28.000000000","message":"Done","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb4346a65a61bbba3007e14cd002b37167176fa6","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"        fake_uuid \u003d str(uuid.uuid4())"},{"line_number":1659,"context_line":"        instance \u003d objects.Instance(context\u003dself.context, id\u003d1, uuid\u003dfake_uuid,"},{"line_number":1660,"context_line":"                                    numa_topology\u003dself.instancetopo)"},{"line_number":1661,"context_line":"        instance_dict \u003d instance_obj.compat_instance(instance)"},{"line_number":1662,"context_line":"        instance_numa_topo \u003d hw.instance_topology_from_instance(instance_dict)"},{"line_number":1663,"context_line":"        for expected_cell, actual_cell in zip(self.instancetopo.cells,"},{"line_number":1664,"context_line":"                                              instance_numa_topo.cells):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_7d012904","line":1661,"updated":"2015-03-26 12:51:32.000000000","message":"nit: I think compat_instance is used more for preserving flavor information in system_metadata, I\u0027m not sure it\u0027s needed here. base_obj.obj_to_primitive() might have worked the same.","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"9d8dc8899b5a247171b294f8dbd9d021e27f30ec","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"        fake_uuid \u003d str(uuid.uuid4())"},{"line_number":1659,"context_line":"        instance \u003d objects.Instance(context\u003dself.context, id\u003d1, uuid\u003dfake_uuid,"},{"line_number":1660,"context_line":"                                    numa_topology\u003dself.instancetopo)"},{"line_number":1661,"context_line":"        instance_dict \u003d instance_obj.compat_instance(instance)"},{"line_number":1662,"context_line":"        instance_numa_topo \u003d hw.instance_topology_from_instance(instance_dict)"},{"line_number":1663,"context_line":"        for expected_cell, actual_cell in zip(self.instancetopo.cells,"},{"line_number":1664,"context_line":"                                              instance_numa_topo.cells):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_c208622b","line":1661,"in_reply_to":"1a6ced46_7d012904","updated":"2015-03-26 13:11:28.000000000","message":"emm....yes, I call that because it used at here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L67\n\nhow about just keep that as the real code?","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb4346a65a61bbba3007e14cd002b37167176fa6","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                                    numa_topology\u003dself.instancetopo)"},{"line_number":1661,"context_line":"        instance_dict \u003d instance_obj.compat_instance(instance)"},{"line_number":1662,"context_line":"        instance_numa_topo \u003d hw.instance_topology_from_instance(instance_dict)"},{"line_number":1663,"context_line":"        for expected_cell, actual_cell in zip(self.instancetopo.cells,"},{"line_number":1664,"context_line":"                                              instance_numa_topo.cells):"},{"line_number":1665,"context_line":"            for k in expected_cell.fields:"},{"line_number":1666,"context_line":"                self.assertEqual(getattr(expected_cell, k),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_1d3915d7","line":1663,"updated":"2015-03-26 12:51:32.000000000","message":"Seems we should have a simpler object comparison assert method somewhere that could be reused.","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fe6d7b6163a43b737718e880f02cfb3dd7508dd","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                                    numa_topology\u003dself.instancetopo)"},{"line_number":1661,"context_line":"        instance_dict \u003d instance_obj.compat_instance(instance)"},{"line_number":1662,"context_line":"        instance_numa_topo \u003d hw.instance_topology_from_instance(instance_dict)"},{"line_number":1663,"context_line":"        for expected_cell, actual_cell in zip(self.instancetopo.cells,"},{"line_number":1664,"context_line":"                                              instance_numa_topo.cells):"},{"line_number":1665,"context_line":"            for k in expected_cell.fields:"},{"line_number":1666,"context_line":"                self.assertEqual(getattr(expected_cell, k),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_3db7b13b","line":1663,"in_reply_to":"1a6ced46_1d3915d7","updated":"2015-03-26 12:54:24.000000000","message":"I was thinking something like this:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/objects/test_objects.py#n269","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4106b8c35e0bb830371149d099e1c8363458b43","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                                    numa_topology\u003dself.instancetopo)"},{"line_number":1661,"context_line":"        instance_dict \u003d instance_obj.compat_instance(instance)"},{"line_number":1662,"context_line":"        instance_numa_topo \u003d hw.instance_topology_from_instance(instance_dict)"},{"line_number":1663,"context_line":"        for expected_cell, actual_cell in zip(self.instancetopo.cells,"},{"line_number":1664,"context_line":"                                              instance_numa_topo.cells):"},{"line_number":1665,"context_line":"            for k in expected_cell.fields:"},{"line_number":1666,"context_line":"                self.assertEqual(getattr(expected_cell, k),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_5de2ad2f","line":1663,"in_reply_to":"1a6ced46_3db7b13b","updated":"2015-03-26 12:57:50.000000000","message":"Nevermind, that takes a nova object and a dict-like db object, so not the same thing.","commit_id":"0ac8cf407250b456c1f6ecce715564c4853f9d14"}]}