)]}'
{"nova/virt/vmwareapi/ds_util.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"1625764b11706c52ddaff39aa4fc8f8b96620126","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                                       searchSpec\u003dsearch_spec)"},{"line_number":549,"context_line":"    task_info \u003d session._wait_for_task(search_task)"},{"line_number":550,"context_line":"    if hasattr(task_info.result, \u0027file\u0027):"},{"line_number":551,"context_line":"        return task_info.result.file[0].fileSize"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def mkdir(session, ds_path, dc_ref):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c9d4a548","line":551,"updated":"2015-05-03 11:12:27.000000000","message":"this looks a little bit strange to me.\n\nYou are checking if task_info.result has the field \u0027file\u0027, and yet you return file[0].fileSize. This implies that there are multiple files, thus the field in task_info.result field should be \u0027files\u0027. Are you sure this is correct?","commit_id":"d1327a110245eaab88f3bd283e4fdce6f56074cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"37f4dd0fa8f089339b5dd41ed02220bd7e2e057b","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                                       searchSpec\u003dsearch_spec)"},{"line_number":549,"context_line":"    task_info \u003d session._wait_for_task(search_task)"},{"line_number":550,"context_line":"    if hasattr(task_info.result, \u0027file\u0027):"},{"line_number":551,"context_line":"        return task_info.result.file[0].fileSize"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def mkdir(session, ds_path, dc_ref):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b442dc0e","line":551,"in_reply_to":"3acd31a7_c9d4a548","updated":"2015-05-03 14:36:40.000000000","message":"Yes, this is correct. Please see http://pubs.vmware.com/vsphere-55/index.jsp?topic\u003d%2Fcom.vmware.wssdk.apiref.doc%2Fvim.host.DatastoreBrowser.html\nThis returns - http://pubs.vmware.com/vsphere-55/index.jsp?topic\u003d%2Fcom.vmware.wssdk.apiref.doc%2Fvim.host.DatastoreBrowser.SearchResults.html\nIn this case we are looking for only one file - see line 543","commit_id":"d1327a110245eaab88f3bd283e4fdce6f56074cd"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"10ddabe662a94181bce9544bfd1cbb61b3b84f72","unresolved":false,"context_lines":[{"line_number":514,"context_line":"                self._delete_datastore_file(str(tmp_dir_loc), vi.dc_info.ref)"},{"line_number":515,"context_line":"            # The size of the image is different from the size of the virtual"},{"line_number":516,"context_line":"            # disk. We want to use the latter."},{"line_number":517,"context_line":"            self._update_image_size(vi)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _create_and_attach_ephemeral_disk(self, instance, vm_ref, dc_info,"},{"line_number":520,"context_line":"                                          size, adapter_type, path):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_9c79c6ca","line":517,"updated":"2015-07-15 12:07:31.000000000","message":"updating the image size here is incorrect for several reasons:\n- this needs to be done only for sparse images, there is no need to update for flat images\n- there is no -flat files on VSAN datastores\n- for streamOptimized and OVA images this needs to be done in another way: https://review.openstack.org/#/c/168024/","commit_id":"37ce631a07e5932ff6140c2190dc4745ceebdcbf"}]}