)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"94c958cdea8b34e64fcc6b9e98e5ca43a5d9af3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-17 09:18:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Libvirt: Make live_migration_bandwidth help msg more meaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch improves the help msg of live_migration_bandwidth, the help message"},{"line_number":10,"context_line":"is from libvirt driver documents(migrateToURI2)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa1b9901_0a0dabe7","line":7,"updated":"2015-08-19 15:03:46.000000000","message":"s/meaning/meaningful/","commit_id":"8666f7501f13ead3c60c8c8a83c308684a66fb4e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"11457f0e8d3a0d4ca890d4450c2e37d0a52009a6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":161,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":162,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":163,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_2ffd873a","line":161,"updated":"2015-03-27 15:34:37.000000000","message":"\"If set to 0, will choose a suitable default\" Not sure the phrasing is good perhaps talk about that qemu will try to find the best one to use. but I\u0027m not good in english so... :)","commit_id":"490c51dd0d803a381db33888bc0ee474f61cb787"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3675476c0e18a587701f7a87770744bbf9ee73cb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":161,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":162,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":163,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_c6d85420","line":161,"in_reply_to":"da9b358b_3b4617c0","updated":"2015-03-30 12:01:51.000000000","message":"Yes so i guess that should be enough :)","commit_id":"490c51dd0d803a381db33888bc0ee474f61cb787"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"f22b23d1897994c99fa38735b3a56f2cac5e8a15","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":161,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":162,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":163,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_3b4617c0","line":161,"in_reply_to":"fa963961_2ffd873a","updated":"2015-03-28 05:02:49.000000000","message":"Hehe , as I said in comments, it is from libvirt Python driver","commit_id":"490c51dd0d803a381db33888bc0ee474f61cb787"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"33f92d7bd3832b58cba832f4010ba60c7470961d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"               default\u003d0,"},{"line_number":158,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":159,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":160,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":161,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":163,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_928268c7","line":160,"updated":"2015-07-31 19:09:39.000000000","message":"Would it be possible to provide a list of these hypervisors here?  Or alternately just say that this works with kvm, if it does, and may not work with other hypervisors.","commit_id":"38b3327fc542d7f7e44118777e78dc83096110f6"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"e3125ae8f9d575f8076e7b1f3ed1629c8bff9fdf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"               default\u003d0,"},{"line_number":158,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":159,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":160,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":161,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":163,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1dcf2457","line":160,"in_reply_to":"3a50d1a3_928268c7","updated":"2015-08-06 01:21:08.000000000","message":"hi andrew, thanks for giving the comments.\n\nthese words are copied from libvirt doc string...\n\n        The maximum bandwidth (in MiB/s) that will be used to do migration\n        can be specified with the bandwidth parameter.  If set to 0,\n        libvirt will choose a suitable default.  Some hypervisors do\n        not support this feature and will return an error if bandwidth\n        is not 0.\n        \n        To see which features are supported by the current hypervisor,\n        see virConnectGetCapabilities, /capabilities/host/migration_features.\n        \n        There are many limitations on migration imposed by the underlying\n        technology - for example it may not be possible to migrate between\n        different processors even with the same architecture, or between\n        different types of hypervisor. \"\"\"\n\n\nand I don\u0027t find any list of there hyypervisors. should we changes these doc string...\n??","commit_id":"38b3327fc542d7f7e44118777e78dc83096110f6"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"d48ac7fc9898d9d36e97b1d8ce127d927a674a09","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":159,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":160,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":161,"context_line":"                    \u0027an error if bandwidth is not 0.\u0027),"},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":163,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":164,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_7a0d4334","line":161,"updated":"2015-08-15 21:56:31.000000000","message":"It sounds like the list of hypervisors is a bit of a moving target. How about appending \"Please refer to the libvirt documentation for further details.\"?","commit_id":"38b3327fc542d7f7e44118777e78dc83096110f6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b0641d697aa4fd3736d646cfc7a4c5da509f2f1e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":169,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":170,"context_line":"               default\u003d0,"},{"line_number":171,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":172,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":173,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":174,"context_line":"                    \u0027an error if bandwidth is not 0. Please refer to the \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_d840f0a7","line":171,"updated":"2015-08-19 14:58:05.000000000","message":"I see the docs here:\n\nhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateToURI2","commit_id":"8666f7501f13ead3c60c8c8a83c308684a66fb4e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b0641d697aa4fd3736d646cfc7a4c5da509f2f1e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"               help\u003d\u0027Maximum bandwidth(in MiB/s) to be used during migration. \u0027"},{"line_number":172,"context_line":"                    \u0027If set to 0, will choose a suitable default. Some \u0027"},{"line_number":173,"context_line":"                    \u0027hypervisors do not support this feature and will return \u0027"},{"line_number":174,"context_line":"                    \u0027an error if bandwidth is not 0. Please refer to the \u0027"},{"line_number":175,"context_line":"                    \u0027libvirt documentation for further details\u0027),"},{"line_number":176,"context_line":"    cfg.IntOpt(\u0027live_migration_downtime\u0027,"},{"line_number":177,"context_line":"               default\u003d500,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_984fd8bc","line":174,"updated":"2015-08-19 14:58:05.000000000","message":"The libvirt docs don\u0027t seem to go into much more detail on this besides calling virConnectGetCapabilities to see what the hypervisor supports.  We actually log this on startup in the nova.virt.libvirt.host module, so maybe it\u0027s worth pointing to that, e.g.:\n\nhttp://logs.openstack.org/58/168258/6/check/gate-tempest-dsvm-full/546ef13/logs/screen-n-cpu.txt.gz#_2015-08-17_01_45_12_588\n\nUnder migration_features though it doesn\u0027t tell me much about bandwidth support:\n\n    \u003cmigration_features\u003e\n      \u003clive/\u003e\n      \u003curi_transports\u003e\n        \u003curi_transport\u003etcp\u003c/uri_transport\u003e\n      \u003c/uri_transports\u003e\n    \u003c/migration_features\u003e\n\nHowever - the docs you added are definitely better than what we have now, which is to say basically leave this setting at 0 so libvirt picks the best value for you, unless you really know what you\u0027re doing, and in that case you need to figure it out via host capabilities.","commit_id":"8666f7501f13ead3c60c8c8a83c308684a66fb4e"}]}