)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"93feb8ef164d990231522179ccea098ae71066f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Cleanup conductor unused methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some conductor api methods left unused that can be removed"},{"line_number":10,"context_line":"together with two very old manager methods that was deprecated and"},{"line_number":11,"context_line":"scheduled for removal with the rpc api version bump to 2.0."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change removes the following unused api client methods:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_ee2fc3f4","line":10,"updated":"2015-04-29 15:51:04.000000000","message":"s/was/were/ (femtonit)","commit_id":"2d1c2c83cee00fbac957c5104ea7449118c621ca"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"2f2ec6e1f794de98f247e2917d19238f45be7208","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Cleanup conductor unused methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some conductor api methods left unused that can be removed"},{"line_number":10,"context_line":"together with two very old manager methods that was deprecated and"},{"line_number":11,"context_line":"scheduled for removal with the rpc api version bump to 2.0."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change removes the following unused api client methods:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aca2d91_4b69008b","line":10,"in_reply_to":"3acd31a7_ee2fc3f4","updated":"2015-05-06 09:37:47.000000000","message":"Done","commit_id":"2d1c2c83cee00fbac957c5104ea7449118c621ca"}],"nova/conductor/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"354d5a42a34bcd4114e030ea5528abecb04c8420","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return self._manager.instance_update(context, instance_uuid,"},{"line_number":67,"context_line":"                                             updates, \u0027compute\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":70,"context_line":"        return self._manager.instance_get_all_by_host("},{"line_number":71,"context_line":"            context, host, None, columns_to_join\u003dcolumns_to_join)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_ede569a8","side":"PARENT","line":69,"updated":"2015-04-29 11:37:03.000000000","message":"Don\u0027t we need to bump the version to 3.0 before we can remove these ones?","commit_id":"1248353ced3b5375b59fb2cbe3c7b706788e3fca"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a9370fe51d1a76ca6d93b625d1b3d5b5fabddf38","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return self._manager.instance_update(context, instance_uuid,"},{"line_number":67,"context_line":"                                             updates, \u0027compute\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":70,"context_line":"        return self._manager.instance_get_all_by_host("},{"line_number":71,"context_line":"            context, host, None, columns_to_join\u003dcolumns_to_join)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_97398644","side":"PARENT","line":69,"in_reply_to":"5ad0253b_ede569a8","updated":"2015-04-29 14:27:28.000000000","message":"Only when we remove the manager methods since thats when backwards compatibility is removed.","commit_id":"1248353ced3b5375b59fb2cbe3c7b706788e3fca"}],"nova/conductor/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"354d5a42a34bcd4114e030ea5528abecb04c8420","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            self.db.instance_get_by_uuid(context, instance_uuid,"},{"line_number":141,"context_line":"                columns_to_join))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def instance_get_all_by_host(self, context, host, node,"},{"line_number":144,"context_line":"                                 columns_to_join):"},{"line_number":145,"context_line":"        if node is not None:"},{"line_number":146,"context_line":"            result \u003d self.db.instance_get_all_by_host_and_node("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_4da45d56","line":143,"updated":"2015-04-29 11:37:03.000000000","message":"Don\u0027t we want to add a comment saying we can remove this when we bump the version to 3.0?","commit_id":"9ab1b0f4713a29756ae24b0637c14b7743694918"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a9370fe51d1a76ca6d93b625d1b3d5b5fabddf38","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            self.db.instance_get_by_uuid(context, instance_uuid,"},{"line_number":141,"context_line":"                columns_to_join))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def instance_get_all_by_host(self, context, host, node,"},{"line_number":144,"context_line":"                                 columns_to_join):"},{"line_number":145,"context_line":"        if node is not None:"},{"line_number":146,"context_line":"            result \u003d self.db.instance_get_all_by_host_and_node("}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_5723ee05","line":143,"in_reply_to":"5ad0253b_4da45d56","updated":"2015-04-29 14:27:28.000000000","message":"good point, I\u0027ll add that.","commit_id":"9ab1b0f4713a29756ae24b0637c14b7743694918"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ecb4737fba4eeb0e544bc1b041aa3b05139f8e80","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    # and can be removed in v3.0 of the RPC API."},{"line_number":257,"context_line":"    def vol_usage_update(self, context, vol_id, rd_req, rd_bytes, wr_req,"},{"line_number":258,"context_line":"                         wr_bytes, instance, update_totals,"},{"line_number":259,"context_line":"                         last_refreshed\u003dNone):"},{"line_number":260,"context_line":"        vol_usage \u003d self.db.vol_usage_update(context, vol_id,"},{"line_number":261,"context_line":"                                             rd_req, rd_bytes,"},{"line_number":262,"context_line":"                                             wr_req, wr_bytes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_625b2df7","line":259,"updated":"2015-05-05 15:46:30.000000000","message":"This is kindof a no-no because this is our external RPC API. However, since RPC is always dispatched by kwarg, and because the last use of this was many cycles ago (I think), it\u0027s probably worth the optimization here.","commit_id":"2d1c2c83cee00fbac957c5104ea7449118c621ca"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ecb4737fba4eeb0e544bc1b041aa3b05139f8e80","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    * Remove instance_get_all_by_host()"},{"line_number":177,"context_line":"    * Remove compute_node_update()"},{"line_number":178,"context_line":"    * Remove compute_node_delete()"},{"line_number":179,"context_line":"    * Remove security_groups_trigger_handler()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    \"\"\""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_02191922","line":179,"updated":"2015-05-05 15:46:30.000000000","message":"I think it\u0027s worth noting the change to the vol_usage_update() call here. From the RPC side, it\u0027s becoming \"always None\". If anything it just helps us note when it happened in the sequence of RPC versions.","commit_id":"2d1c2c83cee00fbac957c5104ea7449118c621ca"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ecb4737fba4eeb0e544bc1b041aa3b05139f8e80","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                       store_cinfo)"},{"line_number":407,"context_line":"        self.stubs.Set(self.compute.conductor_api,"},{"line_number":408,"context_line":"                       \u0027block_device_mapping_update_or_create\u0027,"},{"line_number":409,"context_line":"                       store_cinfo)"},{"line_number":410,"context_line":"        self.stubs.Set(db, \u0027block_device_mapping_create\u0027, store_cinfo)"},{"line_number":411,"context_line":"        self.stubs.Set(db, \u0027block_device_mapping_update\u0027, store_cinfo)"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_62e0cdfa","side":"PARENT","line":409,"updated":"2015-05-05 15:46:30.000000000","message":"Heh.","commit_id":"9da050abe5490898121aa155894de448abefd1d8"}]}