)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"346be33ca28410186fcb8b462e04cf0b04c9b297","unresolved":false,"context_lines":[{"line_number":10,"context_line":"justify to maintain a method get_all in every drivers of"},{"line_number":11,"context_line":"servicegroup instead we have to continue to use Service.get_all()"},{"line_number":12,"context_line":"Also this method is never used as a public and only the"},{"line_number":13,"context_line":"zk driver needs it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit removes the method get_all from the public API"},{"line_number":16,"context_line":"and rename the method to be private of the Zookeeper\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab921fb_3dba256f","line":13,"updated":"2015-04-24 16:27:59.000000000","message":"IMHO, both methods are for different usage :\n - ServiceList.get_all() is just returning back all the registered RPC services written in DB. That just means that you know that a nova-compute service has been running some day.\n - ServiceGroup.get_all() rather returns what the SG driver checks, ie. possibly not a DB thing (just because DB is *one* driver, but there are also MC and ZK)\n\nSay for example that you have a Potatoe (c) driver checking that your service still acts as a potatoe, it will count it. If someday in the future, it becomes a fry, then it won\u0027t be counted, because we know that french fries are a bad thing.\n\nEnough kidding, in other words, the semantics are *very* different. What\u0027s just awesome and under-used in Nova is that the SG.get_all() just makes sure that your service is *valid* and just not a row in a DB table...","commit_id":"54fecb0f1d953f0460f41a32c1a07f2bc27012a1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27b7b25e3118becd61bf5b7ba87b8de13d38a808","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Retrieve all services is exposed in to few circumstances to"},{"line_number":10,"context_line":"justify to maintain a method get_all in every drivers of"},{"line_number":11,"context_line":"servicegroup instead we have to continue to use Service.get_all_by_topics() (which is used by default)"},{"line_number":12,"context_line":"Also this method is never used as a public and only the"},{"line_number":13,"context_line":"zk driver needs it."},{"line_number":14,"context_line":"Finally it makes pain for some drivers like Memcached to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aca2d91_2faa30d5","line":11,"updated":"2015-05-06 21:05:57.000000000","message":"Please correct this to 80-char wrapping :)","commit_id":"4a396f65850794365e88a6e94bd8f666ead24494"}]}