)]}'
{"nova/tests/unit/virt/disk/test_api.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"836865bc317aadefa7b47d15bad0383faad90cdb","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.flags(resize_fs_using_block_device\u003dFalse)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.mox.StubOutWithMock(api, \u0027can_resize_image\u0027)"},{"line_number":153,"context_line":"        self.mox.StubOutWithMock(utils, \u0027execute\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        api.can_resize_image(imgfile, imgsize).AndReturn(True)"},{"line_number":156,"context_line":"        utils.execute(\u0027qemu-img\u0027, \u0027resize\u0027, imgfile, imgsize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_4211d2ab","line":153,"updated":"2015-04-02 08:38:58.000000000","message":"oops , realized new case need to be mock..","commit_id":"84303b99786a2159485e76489ab1aa38e87dd238"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"2c1047c28a3eff3e4c2776407ff73ce6a6e3230e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.flags(resize_fs_using_block_device\u003dFalse)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.mox.StubOutWithMock(api, \u0027can_resize_image\u0027)"},{"line_number":153,"context_line":"        self.mox.StubOutWithMock(utils, \u0027execute\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        api.can_resize_image(imgfile, imgsize).AndReturn(True)"},{"line_number":156,"context_line":"        utils.execute(\u0027qemu-img\u0027, \u0027resize\u0027, imgfile, imgsize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_e22fc69f","line":153,"in_reply_to":"baa041b7_4211d2ab","updated":"2015-04-02 08:50:09.000000000","message":"okay, I\u0027ll change it to use the mock framework","commit_id":"84303b99786a2159485e76489ab1aa38e87dd238"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"46fc0193cc65c6d6f86be02fe3b9f7fe5c6525ee","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @mock.patch.object(api, \u0027is_image_extendable\u0027)"},{"line_number":147,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":148,"context_line":"    def test_extend_qcow_no_resize(self, mock_execute, mock_extendable,"},{"line_number":149,"context_line":"            mock_can_resize_image):"},{"line_number":150,"context_line":"        imgfile \u003d tempfile.NamedTemporaryFile()"},{"line_number":151,"context_line":"        imgsize \u003d 10"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_296e7995","line":149,"updated":"2015-05-03 11:40:39.000000000","message":"this could be indented to match the same indentation as self.","commit_id":"bd5836699ada47db5a5f4b0b41dde0a092e03d2f"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"96f7e46677ad0d650d9695d5916e7219bfd568e9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @mock.patch.object(api, \u0027is_image_extendable\u0027)"},{"line_number":147,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":148,"context_line":"    def test_extend_qcow_no_resize(self, mock_execute, mock_extendable,"},{"line_number":149,"context_line":"            mock_can_resize_image):"},{"line_number":150,"context_line":"        imgfile \u003d tempfile.NamedTemporaryFile()"},{"line_number":151,"context_line":"        imgsize \u003d 10"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_e97afb76","line":149,"in_reply_to":"3acd31a7_296e7995","updated":"2015-05-26 11:44:12.000000000","message":"Done","commit_id":"bd5836699ada47db5a5f4b0b41dde0a092e03d2f"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"46fc0193cc65c6d6f86be02fe3b9f7fe5c6525ee","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        mock_can_resize_image.assert_called_once_with(imgfile, imgsize)"},{"line_number":158,"context_line":"        mock_execute.assert_called_once_with("},{"line_number":159,"context_line":"                \u0027qemu-img\u0027, \u0027resize\u0027, imgfile, imgsize)"},{"line_number":160,"context_line":"        self.assertFalse(mock_extendable.called)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_extend_raw_success(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_09697d8b","line":159,"updated":"2015-05-03 11:40:39.000000000","message":"overindented","commit_id":"bd5836699ada47db5a5f4b0b41dde0a092e03d2f"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"96f7e46677ad0d650d9695d5916e7219bfd568e9","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        mock_can_resize_image.assert_called_once_with(imgfile, imgsize)"},{"line_number":158,"context_line":"        mock_execute.assert_called_once_with("},{"line_number":159,"context_line":"                \u0027qemu-img\u0027, \u0027resize\u0027, imgfile, imgsize)"},{"line_number":160,"context_line":"        self.assertFalse(mock_extendable.called)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_extend_raw_success(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_c97f3f65","line":159,"in_reply_to":"3acd31a7_09697d8b","updated":"2015-05-26 11:44:12.000000000","message":"Done","commit_id":"bd5836699ada47db5a5f4b0b41dde0a092e03d2f"}],"nova/virt/disk/api.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d1d710a39425fc183a663c72e4b97100b426c33d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # if we can\u0027t access the filesystem, we can\u0027t do anything more"},{"line_number":186,"context_line":"    if not is_image_extendable(image, use_cow):"},{"line_number":187,"context_line":"        return"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def safe_resize2fs(dev, run_as_root\u003dFalse, finally_call\u003dlambda: None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_b5efafaf","line":186,"updated":"2015-03-30 15:57:08.000000000","message":"the logic change makes the function not called when above condition satisify compare to previous code\nguess worthy a unit test even though not a big deal","commit_id":"8a4024f7f29dcfce62b557566856fa6fd45c2efa"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"33e9ec9ef673c8a0ba60c118091af34020e9d2a5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # if we can\u0027t access the filesystem, we can\u0027t do anything more"},{"line_number":186,"context_line":"    if not is_image_extendable(image, use_cow):"},{"line_number":187,"context_line":"        return"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def safe_resize2fs(dev, run_as_root\u003dFalse, finally_call\u003dlambda: None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_021e2a0c","line":186,"in_reply_to":"da9b358b_b5efafaf","updated":"2015-04-02 08:31:17.000000000","message":"I added a testcase which checks that the function returns when COW is set and resize is disabled.\n\nThanks for reviewing!","commit_id":"8a4024f7f29dcfce62b557566856fa6fd45c2efa"}]}