)]}'
{"doc/v3/api_samples/os-fixed-ips/v2.4/fixedip-post-req.json":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3b6d162ca89c32f22e591d4287c8f566dddadb75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"reserve\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"3afb71cf_78b1f78e","line":2,"updated":"2015-06-08 11:46:55.000000000","message":"This patch just adds a new parameter to show API, I feel this file seems unnecessary.","commit_id":"8886590f30daf736ae30a95b3e4a77cb586d4f02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a2acd2a2c5ea3755f59511559346e1d69d968240","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"reserve\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"3afb71cf_4a777a3a","line":2,"in_reply_to":"3afb71cf_78b1f78e","updated":"2015-06-08 14:59:33.000000000","message":"I copied it from the v2.1 sample:\n\nhttps://github.com/openstack/nova/blob/master/doc/v3/api_samples/os-fixed-ips/fixedip-post-req.json","commit_id":"8886590f30daf736ae30a95b3e4a77cb586d4f02"}],"nova/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"54d31aaea7df3b625234775cd31ef83f7da1bede","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- **2.4**"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Exposed the \u0027reserved\u0027 attribute in os-fixed-ips."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da9b358b_a083e2cb","line":52,"updated":"2015-03-30 19:22:06.000000000","message":"maybe add more reason on why we need this expose can be helpful","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9513f1ecb1f677e4e32868f1a1397ed421a0bcba","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- **2.4**"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Exposed the \u0027reserved\u0027 attribute in os-fixed-ips."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_465586c4","line":52,"in_reply_to":"da9b358b_a083e2cb","updated":"2015-04-01 14:07:22.000000000","message":"Done","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"}],"nova/tests/functional/v3/api_samples/os-fixed-ips/v2.4/fixedip-post-req.json.tpl":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3b6d162ca89c32f22e591d4287c8f566dddadb75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"reserve\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3afb71cf_987033de","line":2,"updated":"2015-06-08 11:46:55.000000000","message":"ditto","commit_id":"8886590f30daf736ae30a95b3e4a77cb586d4f02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a2acd2a2c5ea3755f59511559346e1d69d968240","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"reserve\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3afb71cf_ea0866db","line":2,"in_reply_to":"3afb71cf_987033de","updated":"2015-06-08 14:59:33.000000000","message":"Tests fail if this doesn\u0027t exist:\n\nnova.tests.functional.v3.test_fixed_ips.FixedIpV24Test.test_fixed_ip_reserve(v2_1)\n----------------------------------------------------------------------------------\n\nCaptured stderr:\n~~~~~~~~~~~~~~~~\n    /home/mriedem/git/nova/.tox/functional/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py:22: DeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.\n      return pkg_resources.EntryPoint.parse(\"x\u003d\" + s).load(False)\n    \n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"nova/tests/functional/v3/test_fixed_ips.py\", line 104, in test_fixed_ip_reserve\n        api_version\u003dself.request_api_version)\n      File \"nova/tests/functional/api_samples_test_base.py\", line 324, in _do_post\n        body \u003d self._read_template(name) % subs\n      File \"nova/tests/functional/api_samples_test_base.py\", line 84, in _read_template\n        with open(template) as inf:\n    IOError: [Errno 2] No such file or directory: \u0027/home/mriedem/git/nova/nova/tests/functional/v3/api_samples/os-fixed-ips/v2.4/fixedip-post-req.json.tpl\u0027\n\n\nThis was copied from the original test sample for v2.1:\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/v3/api_samples/os-fixed-ips/fixedip-post-req.json.tpl","commit_id":"8886590f30daf736ae30a95b3e4a77cb586d4f02"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"161115d45242d8d29050428f5569a65afb279708","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"reserve\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3afb71cf_498410d3","line":2,"in_reply_to":"3afb71cf_ea0866db","updated":"2015-06-09 01:23:33.000000000","message":"Ah, thanks for the explanation.\nI missed it, sorry about that. now LGTM.","commit_id":"8886590f30daf736ae30a95b3e4a77cb586d4f02"}],"nova/tests/functional/v3/api_samples/os-fixed-ips/v2.4/fixedips-get-resp.json.tpl":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1cbaa06a2f3ddeb72e5f2e2e223bc2a463498964","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"hostname\": \"%(hostname)s\","},{"line_number":5,"context_line":"        \"host\": \"%(host)s\","},{"line_number":6,"context_line":"        \"address\": \"%(address)s\","},{"line_number":7,"context_line":"        \"reserved\": false"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7a016987_88fd933c","line":7,"updated":"2015-05-15 14:36:19.000000000","message":"There should be \"reserved\" %(reserved)s. As you pass \u0027reserved\u0027 in sub parameter when invoke _verify_response","commit_id":"9b4959d5363e4736f7dd1361a3f9572ae86ff56e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30d8ff47f7748b76051d3caa2b3b62270b5d9309","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"hostname\": \"%(hostname)s\","},{"line_number":5,"context_line":"        \"host\": \"%(host)s\","},{"line_number":6,"context_line":"        \"address\": \"%(address)s\","},{"line_number":7,"context_line":"        \"reserved\": false"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7a016987_dafa2abd","line":7,"in_reply_to":"7a016987_23bec0d4","updated":"2015-05-15 17:41:53.000000000","message":"Done","commit_id":"9b4959d5363e4736f7dd1361a3f9572ae86ff56e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1942ce38cc90aeb3fb6a7ed655629069aef282b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"hostname\": \"%(hostname)s\","},{"line_number":5,"context_line":"        \"host\": \"%(host)s\","},{"line_number":6,"context_line":"        \"address\": \"%(address)s\","},{"line_number":7,"context_line":"        \"reserved\": false"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7a016987_a85a8f4e","line":7,"in_reply_to":"7a016987_88fd933c","updated":"2015-05-15 14:38:10.000000000","message":"This was the only way I could get this working, which is why I pinged you previously about it.  I\u0027m not sure if that means something is wrong in my other samples, or in how the test is verifying the response, but when I had %(reserved)s it was complaining about expecting a string or buffer.","commit_id":"9b4959d5363e4736f7dd1361a3f9572ae86ff56e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"41146b42d5f079e3d8a329a506af89b9ffa4c275","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"hostname\": \"%(hostname)s\","},{"line_number":5,"context_line":"        \"host\": \"%(host)s\","},{"line_number":6,"context_line":"        \"address\": \"%(address)s\","},{"line_number":7,"context_line":"        \"reserved\": false"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7a016987_23bec0d4","line":7,"in_reply_to":"7a016987_a85a8f4e","updated":"2015-05-15 14:48:53.000000000","message":"Emm... I guess the reason is \"%(reserved)\" return string \"False\", not boolean. But let me check what happened.","commit_id":"9b4959d5363e4736f7dd1361a3f9572ae86ff56e"}],"nova/tests/unit/api/openstack/compute/contrib/test_fixed_ips.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e666593c9ff9e00e42836d09079b8f10f9e38ad9","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _get_unreserve_action(self):"},{"line_number":253,"context_line":"        return self.controller.action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class FixedIpTestV24(FixedIpTestV21):"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_1573fb81","line":254,"updated":"2015-03-30 15:50:51.000000000","message":"do we need a test here to indicate v2 don\u0027t have this ?\nmaybe v2 is doing same v21 test if we didn\u0027t specify here?","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23da0f3bafe82c094e1bb07ecdfcf6631e03732a","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _get_unreserve_action(self):"},{"line_number":253,"context_line":"        return self.controller.action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class FixedIpTestV24(FixedIpTestV21):"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_34771c3c","line":254,"in_reply_to":"da9b358b_1573fb81","updated":"2015-03-30 17:54:15.000000000","message":"I think this can be addressed when bug 1438286 is fixed - right now there is no json schema validation for os-fixed-ips in the v3 tree.  Once I add that the schema will match what\u0027s in Tempest which is the current v2.1 behavior.","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"90a92575a4bb3132ed35e820cfdb80fc632f5124","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _get_unreserve_action(self):"},{"line_number":253,"context_line":"        return self.controller.action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class FixedIpTestV24(FixedIpTestV21):"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_3494bce0","line":254,"in_reply_to":"da9b358b_34771c3c","updated":"2015-03-30 18:01:12.000000000","message":"Actually, \"maybe v2 is doing same v21 test if we didn\u0027t specify here?\" - that\u0027s what it \u0027s doing.  The v2 test extends the v21 test and gets the same testing, which would fail if \u0027reserved\u0027 came back in the response body because res_dict would be wrong.","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"54d31aaea7df3b625234775cd31ef83f7da1bede","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _get_unreserve_action(self):"},{"line_number":253,"context_line":"        return self.controller.action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class FixedIpTestV24(FixedIpTestV21):"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_60403aa6","line":254,"in_reply_to":"da9b358b_3494bce0","updated":"2015-03-30 19:22:06.000000000","message":"ok, got it, make sense","commit_id":"005e9e2695db025b7ae52aa8d9616ce829516fb0"}]}