)]}'
{"nova/tests/unit/api/openstack/compute/contrib/test_tenant_networks.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"87d35eaf9716b76ae7507d52347fe5786d8a2bfa","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"},{"line_number":160,"context_line":"        if default_net is True:"},{"line_number":161,"context_line":"            self.req.environ[\u0027nova.context\u0027].project_id \u003d DEFAULT_TENANT_ID"},{"line_number":162,"context_line":"            expected \u003d NETWORKS_WITH_DEFAULT_NET"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        res \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_6136e0e8","side":"PARENT","line":161,"updated":"2015-03-31 13:18:54.000000000","message":"You normally don\u0027t have to remove this line.\n\nThe method api_get_all will be called two times. the second time to refresh _default_networks but since we have mocked api_get_all we will get a duplicate of the elements. I believe what you need to do here is to mock the method _refresh_default_networks to return only [DEFAULT_NETWORK] and fake_network_api_get_all should return only NETWORKS","commit_id":"e9d8d933859d2cbbab0f07194ca1f114e10bf38c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1e158897cde70ff9788b533b8fdc8be788e0f39a","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"},{"line_number":160,"context_line":"        if default_net is True:"},{"line_number":161,"context_line":"            self.req.environ[\u0027nova.context\u0027].project_id \u003d DEFAULT_TENANT_ID"},{"line_number":162,"context_line":"            expected \u003d NETWORKS_WITH_DEFAULT_NET"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        res \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_a805d17a","side":"PARENT","line":161,"in_reply_to":"9aa53dc9_ebd758eb","updated":"2015-04-08 17:04:57.000000000","message":"Yes but if you want to fix the test perhaps it\u0027s better to make it testing the real behavior of the base code.","commit_id":"e9d8d933859d2cbbab0f07194ca1f114e10bf38c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b350a8873af8ebabc6927f02f89aba0cc75a0320","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"},{"line_number":160,"context_line":"        if default_net is True:"},{"line_number":161,"context_line":"            self.req.environ[\u0027nova.context\u0027].project_id \u003d DEFAULT_TENANT_ID"},{"line_number":162,"context_line":"            expected \u003d NETWORKS_WITH_DEFAULT_NET"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        res \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_613dc0ba","side":"PARENT","line":161,"in_reply_to":"da9b358b_6136e0e8","updated":"2015-03-31 13:19:50.000000000","message":"Please do not consider my first line \"You normally don\u0027t have to remove this line.\"","commit_id":"e9d8d933859d2cbbab0f07194ca1f114e10bf38c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"22824b7016aa41c0cf61a7eb6599315af8565159","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"},{"line_number":160,"context_line":"        if default_net is True:"},{"line_number":161,"context_line":"            self.req.environ[\u0027nova.context\u0027].project_id \u003d DEFAULT_TENANT_ID"},{"line_number":162,"context_line":"            expected \u003d NETWORKS_WITH_DEFAULT_NET"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        res \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_ebd758eb","side":"PARENT","line":161,"in_reply_to":"da9b358b_6136e0e8","updated":"2015-04-08 15:56:59.000000000","message":"Yes, get_all is called twice, but I don\u0027t think its necessary to mock it since it works correctly as long as the default network name is \u0027default\u0027.  \n\nPrevious to my patch, the test only worked by accident","commit_id":"e9d8d933859d2cbbab0f07194ca1f114e10bf38c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"87d35eaf9716b76ae7507d52347fe5786d8a2bfa","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        get_mock.return_value \u003d NETWORKS[0]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        res \u003d self.controller.show(self.req, 1)"},{"line_number":144,"context_line":"        self.assertEqual(NETWORKS[0], res[\u0027network\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @mock.patch(\u0027nova.network.api.API.get\u0027)"},{"line_number":147,"context_line":"    def test_network_show_not_found(self, get_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_5bf50dc9","line":144,"updated":"2015-03-31 13:18:54.000000000","message":"Even if not related that is should small enough to be considered in you clean of that test.","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1e158897cde70ff9788b533b8fdc8be788e0f39a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        get_mock.return_value \u003d NETWORKS[0]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        res \u003d self.controller.show(self.req, 1)"},{"line_number":144,"context_line":"        self.assertEqual(NETWORKS[0], res[\u0027network\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @mock.patch(\u0027nova.network.api.API.get\u0027)"},{"line_number":147,"context_line":"    def test_network_show_not_found(self, get_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_48af6594","line":144,"in_reply_to":"9aa53dc9_cb2c9404","updated":"2015-04-08 17:04:57.000000000","message":"Yes it is for me, sorry :)","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"22824b7016aa41c0cf61a7eb6599315af8565159","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        get_mock.return_value \u003d NETWORKS[0]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        res \u003d self.controller.show(self.req, 1)"},{"line_number":144,"context_line":"        self.assertEqual(NETWORKS[0], res[\u0027network\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @mock.patch(\u0027nova.network.api.API.get\u0027)"},{"line_number":147,"context_line":"    def test_network_show_not_found(self, get_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_cb2c9404","line":144,"in_reply_to":"da9b358b_5bf50dc9","updated":"2015-04-08 15:56:59.000000000","message":"Is this acceptable?  I didn\u0027t quite understand the meaning of your comment.","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"87d35eaf9716b76ae7507d52347fe5786d8a2bfa","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":155,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003dTrue):"},{"line_number":156,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", str(default_net))"},{"line_number":157,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_db859d59","line":156,"updated":"2015-03-31 13:18:54.000000000","message":"Yes the conf expect a string.","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1e158897cde70ff9788b533b8fdc8be788e0f39a","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":155,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003dTrue):"},{"line_number":156,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", str(default_net))"},{"line_number":157,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_08795d2f","line":156,"in_reply_to":"9aa53dc9_8b368c50","updated":"2015-04-08 17:04:57.000000000","message":"it\u0027s ok","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"22824b7016aa41c0cf61a7eb6599315af8565159","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":155,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003dTrue):"},{"line_number":156,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", str(default_net))"},{"line_number":157,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        expected \u003d NETWORKS"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_8b368c50","line":156,"in_reply_to":"da9b358b_db859d59","updated":"2015-04-08 15:56:59.000000000","message":"ok, no?","commit_id":"294881574429fa0b440c1d5f5233b6aae335dc3d"}]}