)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"84a826f7e216e38f2e47f76e1eecd5f08767386e","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if self._events is None:"},{"line_number":482,"context_line":"            # NOTE(danms): We really should have a more specific error"},{"line_number":483,"context_line":"            # here, but this is what we use for our default error case"},{"line_number":484,"context_line":"            raise exception.NovaException(\u0027In shutdown, no new events \u0027"},{"line_number":485,"context_line":"                                          \u0027can be scheduled\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        @utils.synchronized(self._lock_name(instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_2d110653","line":484,"range":{"start_line":484,"start_character":12,"end_line":484,"end_character":41},"updated":"2015-03-30 20:54:04.000000000","message":"Are we not adding _() because of the string freeze? probably needs a FIXME then?","commit_id":"5c9a5b20d3426e89aaf48d5e15dba07c26542e58"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fdc4d674ff5214bc778a5b6f58a5ad978e531a6c","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if self._events is None:"},{"line_number":482,"context_line":"            # NOTE(danms): We really should have a more specific error"},{"line_number":483,"context_line":"            # here, but this is what we use for our default error case"},{"line_number":484,"context_line":"            raise exception.NovaException(\u0027In shutdown, no new events \u0027"},{"line_number":485,"context_line":"                                          \u0027can be scheduled\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        @utils.synchronized(self._lock_name(instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_61f7edf5","line":484,"range":{"start_line":484,"start_character":12,"end_line":484,"end_character":41},"in_reply_to":"da9b358b_2d110653","updated":"2015-03-31 20:11:46.000000000","message":"For one thing, we don\u0027t ever let this escape, right? It\u0027s only an internal signaling mechanism, so I think it\u0027s okay to be untranslated. What do you think?","commit_id":"5c9a5b20d3426e89aaf48d5e15dba07c26542e58"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"f5875332215148d9090d70e8224af3806055d014","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if self._events is None:"},{"line_number":482,"context_line":"            # NOTE(danms): We really should have a more specific error"},{"line_number":483,"context_line":"            # here, but this is what we use for our default error case"},{"line_number":484,"context_line":"            raise exception.NovaException(\u0027In shutdown, no new events \u0027"},{"line_number":485,"context_line":"                                          \u0027can be scheduled\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        @utils.synchronized(self._lock_name(instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_a135f5f7","line":484,"range":{"start_line":484,"start_character":12,"end_line":484,"end_character":41},"in_reply_to":"da9b358b_61f7edf5","updated":"2015-03-31 20:25:30.000000000","message":"yep. am good. thanks","commit_id":"5c9a5b20d3426e89aaf48d5e15dba07c26542e58"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a48e3d82679090bac9e416c408cd9b3a365a02d","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        if self._events is None:"},{"line_number":482,"context_line":"            # NOTE(danms): We really should have a more specific error"},{"line_number":483,"context_line":"            # here, but this is what we use for our default error case"},{"line_number":484,"context_line":"            raise exception.NovaException(\u0027In shutdown, no new events \u0027"},{"line_number":485,"context_line":"                                          \u0027can be scheduled\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        @utils.synchronized(self._lock_name(instance))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_b95e4110","line":484,"updated":"2015-04-08 18:07:41.000000000","message":"Does this get back out anywhere, or get logged?  It should be translated probably, but string freeze.\n\n--\n\nNevermind, I see this is just flow control in wait_for_instance_event.","commit_id":"001ec99131f1e6c7f04d1cf83a7776f4cebeeda1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a48e3d82679090bac9e416c408cd9b3a365a02d","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        no_matching_event_sentinel \u003d object()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        @utils.synchronized(self._lock_name(instance))"},{"line_number":513,"context_line":"        def _pop_event():"},{"line_number":514,"context_line":"            events \u003d self._events.get(instance.uuid)"},{"line_number":515,"context_line":"            if not events:"},{"line_number":516,"context_line":"                return no_events_sentinel"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_99ea5d0e","line":513,"updated":"2015-04-08 18:07:41.000000000","message":"Hopefully we don\u0027t hit this in the meantime?","commit_id":"001ec99131f1e6c7f04d1cf83a7776f4cebeeda1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7addd7b88e03ce95901ac4ce35195e1601455a69","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        no_matching_event_sentinel \u003d object()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        @utils.synchronized(self._lock_name(instance))"},{"line_number":513,"context_line":"        def _pop_event():"},{"line_number":514,"context_line":"            events \u003d self._events.get(instance.uuid)"},{"line_number":515,"context_line":"            if not events:"},{"line_number":516,"context_line":"                return no_events_sentinel"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_34b478cf","line":513,"in_reply_to":"9aa53dc9_19d08d1e","updated":"2015-04-08 18:46:57.000000000","message":"You could put a check and just log.debug if we think it\u0027s something that shouldn\u0027t happen but we want to be safe.","commit_id":"001ec99131f1e6c7f04d1cf83a7776f4cebeeda1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c7e2261d9ad1672eb71904b6befed412082018b5","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        no_matching_event_sentinel \u003d object()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        @utils.synchronized(self._lock_name(instance))"},{"line_number":513,"context_line":"        def _pop_event():"},{"line_number":514,"context_line":"            events \u003d self._events.get(instance.uuid)"},{"line_number":515,"context_line":"            if not events:"},{"line_number":516,"context_line":"                return no_events_sentinel"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_f4cdf05d","line":513,"in_reply_to":"9aa53dc9_34b478cf","updated":"2015-04-08 18:47:51.000000000","message":"Okay.","commit_id":"001ec99131f1e6c7f04d1cf83a7776f4cebeeda1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1ff555a41cac6fd00881513cb014976a9386b4f5","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        no_matching_event_sentinel \u003d object()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        @utils.synchronized(self._lock_name(instance))"},{"line_number":513,"context_line":"        def _pop_event():"},{"line_number":514,"context_line":"            events \u003d self._events.get(instance.uuid)"},{"line_number":515,"context_line":"            if not events:"},{"line_number":516,"context_line":"                return no_events_sentinel"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_19d08d1e","line":513,"in_reply_to":"9aa53dc9_99ea5d0e","updated":"2015-04-08 18:13:02.000000000","message":"We can\u0027t hit this because we\u0027ve already eliminated incoming RPC at this point, and that\u0027s what does the popping.\n\nHowever, maybe that\u0027s too obscure and I should put a check and a warning here. But that\u0027d be _LW and.. string freeze :P","commit_id":"001ec99131f1e6c7f04d1cf83a7776f4cebeeda1"}]}