)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c46ab7696304f8aa97ec3f83583a31c37d913e99","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Do not delete volumes during reschedule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova delete the volumes when the instance is destroyed if the"},{"line_number":10,"context_line":"delete_on_termination flag of the voluem is set to 1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, if we failed to spawn the instance due to some reason"},{"line_number":13,"context_line":"e.g network not ready, memory not enough etc, we should keep the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_4948952d","line":10,"updated":"2015-05-03 11:35:34.000000000","message":"voluem \u003d\u003e volume","commit_id":"2a3d623dfb0d7d69736bbc97d17daf9aa66a7a98"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c46ab7696304f8aa97ec3f83583a31c37d913e99","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, if we failed to spawn the instance due to some reason"},{"line_number":13,"context_line":"e.g network not ready, memory not enough etc, we should keep the"},{"line_number":14,"context_line":"volume; Also, the volume can\u0027t be destoryed during reschedule"},{"line_number":15,"context_line":"actions because next resedule might find a valid host and"},{"line_number":16,"context_line":"do the spawn correctly, but the volume was already"},{"line_number":17,"context_line":"deleted at previous spawn attention and leads to problem."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_295799cf","line":14,"updated":"2015-05-03 11:35:34.000000000","message":"destoryed \u003d\u003e destroyed","commit_id":"2a3d623dfb0d7d69736bbc97d17daf9aa66a7a98"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c46ab7696304f8aa97ec3f83583a31c37d913e99","unresolved":false,"context_lines":[{"line_number":12,"context_line":"However, if we failed to spawn the instance due to some reason"},{"line_number":13,"context_line":"e.g network not ready, memory not enough etc, we should keep the"},{"line_number":14,"context_line":"volume; Also, the volume can\u0027t be destoryed during reschedule"},{"line_number":15,"context_line":"actions because next resedule might find a valid host and"},{"line_number":16,"context_line":"do the spawn correctly, but the volume was already"},{"line_number":17,"context_line":"deleted at previous spawn attention and leads to problem."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_09529ddd","line":15,"updated":"2015-05-03 11:35:34.000000000","message":"resedule \u003d\u003e reschedule","commit_id":"2a3d623dfb0d7d69736bbc97d17daf9aa66a7a98"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c46ab7696304f8aa97ec3f83583a31c37d913e99","unresolved":false,"context_lines":[{"line_number":14,"context_line":"volume; Also, the volume can\u0027t be destoryed during reschedule"},{"line_number":15,"context_line":"actions because next resedule might find a valid host and"},{"line_number":16,"context_line":"do the spawn correctly, but the volume was already"},{"line_number":17,"context_line":"deleted at previous spawn attention and leads to problem."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I36ebd98ceb969ee9cc9f28e5f9e79cd4e8f43609"},{"line_number":20,"context_line":"Closes-Bug: #1427179"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_e95f61e3","line":17,"updated":"2015-05-03 11:35:34.000000000","message":"attention \u003d\u003e attempt\n\nleads to problem \u003d\u003e it leads to a problem","commit_id":"2a3d623dfb0d7d69736bbc97d17daf9aa66a7a98"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"153ac30342d3046c517c846731c5f313f0b7e910","unresolved":false,"context_lines":[{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            self._shutdown_instance(context, instance,"},{"line_number":1614,"context_line":"                                    bdms, requested_networks)"},{"line_number":1615,"context_line":"            self._cleanup_volumes(context, instance.uuid, bdms)"},{"line_number":1616,"context_line":"        except Exception:"},{"line_number":1617,"context_line":"            # do not attempt retry if clean up failed:"},{"line_number":1618,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_ccaab419","side":"PARENT","line":1615,"updated":"2015-04-13 13:03:31.000000000","message":"This makes sense to remove it from here, but you should make this clean happening if we don\u0027t try to attempt a new scheduling","commit_id":"6afe84df5a4e5b7a55180231fd329e2f975cb361"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"153ac30342d3046c517c846731c5f313f0b7e910","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"                    task_state, exc_info)"},{"line_number":1630,"context_line":""},{"line_number":1631,"context_line":"        except Exception:"},{"line_number":1632,"context_line":"            rescheduled \u003d False"},{"line_number":1633,"context_line":"            LOG.exception(_LE(\"Error trying to reschedule\"),"},{"line_number":1634,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":1635,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_ec7450d0","line":1632,"updated":"2015-04-13 13:03:31.000000000","message":"We should try to remove volumes already created here","commit_id":"3881c6147f89ff5af5734707079c88b1c1819d8d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"efdf3d1e3f33ac012b6d4c92502093cd5ec242e6","unresolved":false,"context_lines":[{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            self._shutdown_instance(context, instance,"},{"line_number":1614,"context_line":"                                    bdms, requested_networks)"},{"line_number":1615,"context_line":"            self._cleanup_volumes(context, instance.uuid, bdms)"},{"line_number":1616,"context_line":"        except Exception:"},{"line_number":1617,"context_line":"            # do not attempt retry if clean up failed:"},{"line_number":1618,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_8a8ff222","side":"PARENT","line":1615,"updated":"2015-05-06 21:50:03.000000000","message":"this was added as a bug fix in Ieb6220ae66f0b97a92c50f6998f456968b516fcb\n\nAnd based on the commit message and log, I think that issue is still valid.","commit_id":"6afe84df5a4e5b7a55180231fd329e2f975cb361"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"854d5630b7d4747ef3e223ba194e7cd37fc7e5d2","unresolved":false,"context_lines":[{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            self._shutdown_instance(context, instance,"},{"line_number":1614,"context_line":"                                    bdms, requested_networks)"},{"line_number":1615,"context_line":"            self._cleanup_volumes(context, instance.uuid, bdms)"},{"line_number":1616,"context_line":"        except Exception:"},{"line_number":1617,"context_line":"            # do not attempt retry if clean up failed:"},{"line_number":1618,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_e6ee95eb","side":"PARENT","line":1615,"in_reply_to":"1aca2d91_8a8ff222","updated":"2015-05-07 08:03:21.000000000","message":"libvirt._create_domain() raise an exception\nis the root cause of the problem and he says\n\n\"If there is more than one host, the instance will be rescheduled to other host. but the resources in this host will not release forever.\"\n\nI didn\u0027t see info about volumes in the original exception log..\nthe _cleanup_volumes only delete volumes if it\u0027s needed \nthe volumes doesn\u0027t belong to any host, \nI think we should delete them at last (no other host to reschedule)\nnot every reschedule","commit_id":"6afe84df5a4e5b7a55180231fd329e2f975cb361"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"0637748e66a4b60033736d2292a8018a8bf7937a","unresolved":false,"context_lines":[{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            self._shutdown_instance(context, instance,"},{"line_number":1614,"context_line":"                                    bdms, requested_networks)"},{"line_number":1615,"context_line":"            self._cleanup_volumes(context, instance.uuid, bdms)"},{"line_number":1616,"context_line":"        except Exception:"},{"line_number":1617,"context_line":"            # do not attempt retry if clean up failed:"},{"line_number":1618,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_97f7c458","side":"PARENT","line":1615,"in_reply_to":"1aca2d91_e6ee95eb","updated":"2015-05-08 20:14:45.000000000","message":"I want to make sure that there are no edge cases where we end up calling a reschedule but the volume is in some dirty state.","commit_id":"6afe84df5a4e5b7a55180231fd329e2f975cb361"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"42fb0b5ab4387d785659d359687943a505acbee1","unresolved":false,"context_lines":[{"line_number":11036,"context_line":"        except Exception:"},{"line_number":11037,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":11038,"context_line":""},{"line_number":11039,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":11040,"context_line":"        method_args \u003d (None, None, None, None, False, {})"},{"line_number":11041,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_shutdown_instance\u0027)"},{"line_number":11042,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_4f23f505","line":11039,"updated":"2015-03-31 18:55:26.000000000","message":"You can remove this assignment, since instance_uuid is not used anymore.","commit_id":"53b87a22527c0a2b3c75d29219bb16277f4ada51"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"621b78829729f575280a50623e16758d77a26235","unresolved":false,"context_lines":[{"line_number":11036,"context_line":"        except Exception:"},{"line_number":11037,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":11038,"context_line":""},{"line_number":11039,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":11040,"context_line":"        method_args \u003d (None, None, None, None, False, {})"},{"line_number":11041,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_shutdown_instance\u0027)"},{"line_number":11042,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_666aca1c","line":11039,"in_reply_to":"da9b358b_4f23f505","updated":"2015-04-01 14:19:34.000000000","message":"Done","commit_id":"53b87a22527c0a2b3c75d29219bb16277f4ada51"},{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"42fb0b5ab4387d785659d359687943a505acbee1","unresolved":false,"context_lines":[{"line_number":11056,"context_line":""},{"line_number":11057,"context_line":"    def test_reschedule_false(self):"},{"line_number":11058,"context_line":"        # Test not-rescheduling, but no nested exception."},{"line_number":11059,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":11060,"context_line":"        method_args \u003d (None, None, None, None, False, {})"},{"line_number":11061,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_shutdown_instance\u0027)"},{"line_number":11062,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_af84c1d3","line":11059,"updated":"2015-03-31 18:55:26.000000000","message":"This one as well.","commit_id":"53b87a22527c0a2b3c75d29219bb16277f4ada51"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"621b78829729f575280a50623e16758d77a26235","unresolved":false,"context_lines":[{"line_number":11056,"context_line":""},{"line_number":11057,"context_line":"    def test_reschedule_false(self):"},{"line_number":11058,"context_line":"        # Test not-rescheduling, but no nested exception."},{"line_number":11059,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":11060,"context_line":"        method_args \u003d (None, None, None, None, False, {})"},{"line_number":11061,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_shutdown_instance\u0027)"},{"line_number":11062,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_4677c602","line":11059,"in_reply_to":"da9b358b_af84c1d3","updated":"2015-04-01 14:19:34.000000000","message":"Done","commit_id":"53b87a22527c0a2b3c75d29219bb16277f4ada51"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"97d5645bb4a1510cfa8e8ac4e91badfb769fc45b","unresolved":false,"context_lines":[{"line_number":10941,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"},{"line_number":10942,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_cleanup_volumes\u0027)"},{"line_number":10943,"context_line":""},{"line_number":10944,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":10945,"context_line":"        self.compute._shutdown_instance(mox.IgnoreArg(), self.instance,"},{"line_number":10946,"context_line":"                                        mox.IgnoreArg(),"},{"line_number":10947,"context_line":"                                        mox.IgnoreArg())"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_4f14e1e7","line":10944,"updated":"2015-05-29 13:47:00.000000000","message":"I don\u0027t see why these lines had to be moved.","commit_id":"fd0d939a0d7013ebe8be85c876018324fc315249"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"841b249686e2eb82ec08a47bda6a9ef2a0745ef7","unresolved":false,"context_lines":[{"line_number":10941,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_reschedule\u0027)"},{"line_number":10942,"context_line":"        self.mox.StubOutWithMock(self.compute, \u0027_cleanup_volumes\u0027)"},{"line_number":10943,"context_line":""},{"line_number":10944,"context_line":"        instance_uuid \u003d self.instance[\u0027uuid\u0027]"},{"line_number":10945,"context_line":"        self.compute._shutdown_instance(mox.IgnoreArg(), self.instance,"},{"line_number":10946,"context_line":"                                        mox.IgnoreArg(),"},{"line_number":10947,"context_line":"                                        mox.IgnoreArg())"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_4002ec0a","line":10944,"in_reply_to":"7a016987_4f14e1e7","updated":"2015-08-10 14:53:48.000000000","message":"correct, misopreation","commit_id":"fd0d939a0d7013ebe8be85c876018324fc315249"}]}