)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"49a635e2628fe735fc4d3f6824f8024d2b0099bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add json-schema for v2.1 fixed-ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds json-schema for v2.1 fixed-ips. The json-schame just"},{"line_number":10,"context_line":"limits the input for actions reserve/unreserve, and fixed the API sample"},{"line_number":11,"context_line":"file at sametime."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_a9b16a91","line":9,"updated":"2015-03-31 15:06:58.000000000","message":"s/schame/scheme/.","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"978b15a5c72845916c9c166967ceb0e541343241","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds json-schema for v2.1 fixed-ips. The json-schame limits"},{"line_number":10,"context_line":"the input for actions reserve/unreserve. Also fixed the API sample"},{"line_number":11,"context_line":"file at sametime and add parameter_type none."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Ken\u0027ichi Ohmichi \u003cken1ohmichi@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Id2d0416c3ccc2a50d3cb66bed8747082f98fb194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da9b358b_5b1cc476","line":11,"updated":"2015-04-01 09:48:16.000000000","message":"nit: s/sametime/same time/","commit_id":"f80beb09d9222e147e21040d88a5687d9eb7d43f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"15214af873e7fb0bd0c2851aba568e50a2aadfc7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds json-schema for v2.1 fixed-ips. The json-schame limits"},{"line_number":10,"context_line":"the input for actions reserve/unreserve. Also fixed the API sample"},{"line_number":11,"context_line":"file at sametime and add parameter_type none."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Ken\u0027ichi Ohmichi \u003cken1ohmichi@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Id2d0416c3ccc2a50d3cb66bed8747082f98fb194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da9b358b_11f61cf9","line":11,"in_reply_to":"da9b358b_5b1cc476","updated":"2015-04-01 10:33:20.000000000","message":"thanks Rui :)","commit_id":"f80beb09d9222e147e21040d88a5687d9eb7d43f"}],"nova/api/openstack/compute/schemas/v3/fixed_ips.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88c1c623d06ec2e72bb0be9074e6bf12e281eeaf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"                {"},{"line_number":28,"context_line":"                    # NOTE(alex_xu): Because since v2 API \"None\" was valid"},{"line_number":29,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":30,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":31,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_24ea2110","line":28,"updated":"2015-03-31 15:10:18.000000000","message":"Can we add a unit or negative functional test for this? I\u0027d expect to get a 400 back.","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9e727d14d3b4df47f7855bcdf06756cd0ecb9bc1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"                {"},{"line_number":28,"context_line":"                    # NOTE(alex_xu): Because since v2 API \"None\" was valid"},{"line_number":29,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":30,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":31,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_e458b9fc","line":28,"in_reply_to":"da9b358b_24ea2110","updated":"2015-03-31 15:12:14.000000000","message":"Oh wait, I guess this is just so we don\u0027t have strict validation, even though the body is not used at all in the actual API extension, correct?","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7c729ee752be59ef0b136c1804d3031fcc51ff18","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"                {"},{"line_number":28,"context_line":"                    # NOTE(alex_xu): Because since v2 API \"None\" was valid"},{"line_number":29,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":30,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":31,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_8fc8ca23","line":28,"in_reply_to":"da9b358b_e458b9fc","updated":"2015-04-01 07:39:00.000000000","message":"yes, Ideally just only support None and {}. But there are some mistake in api samples and tempest, use str \u0027None\u0027 as parameter, didn\u0027t want to break if there is any client use that wrong parameter. So keep back-compatible at here.","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5eccaeb8ce18975a9551a309a676fd16f63f226c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":30,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":31,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"},{"line_number":32,"context_line":"                }"},{"line_number":33,"context_line":"            ]"},{"line_number":34,"context_line":"        },"},{"line_number":35,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_cc19457b","line":32,"updated":"2015-04-01 01:18:19.000000000","message":"This definition(line21-32) can be changed to\n\n \u0027enum\u0027: [\u0027None\u0027, None, {}]\n\nhttps://review.openstack.org/#/c/169573 is adding this as common parameter for sharing other APIs also.\nIt is OK to just change here without any patch dependency.","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7c729ee752be59ef0b136c1804d3031fcc51ff18","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":30,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":31,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"},{"line_number":32,"context_line":"                }"},{"line_number":33,"context_line":"            ]"},{"line_number":34,"context_line":"        },"},{"line_number":35,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_4fe9a27f","line":32,"in_reply_to":"da9b358b_cc19457b","updated":"2015-04-01 07:39:00.000000000","message":"cool, so clever. I will update it. Thanks","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88c1c623d06ec2e72bb0be9074e6bf12e281eeaf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":50,"context_line":"                },"},{"line_number":51,"context_line":"                {"},{"line_number":52,"context_line":"                    # NOTE(alex_xu): Because since v2 API \"None\" was valid"},{"line_number":53,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":54,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":55,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_64e82911","line":52,"updated":"2015-03-31 15:10:18.000000000","message":"Can we add a unit or negative functional test for this? I\u0027d expect to get a 400 back.","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5eccaeb8ce18975a9551a309a676fd16f63f226c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    # value. So accepts \"None\" just for back-compatibile."},{"line_number":54,"context_line":"                    \u0027type\u0027: [\u0027string\u0027],"},{"line_number":55,"context_line":"                    \u0027enum\u0027: [\u0027None\u0027]"},{"line_number":56,"context_line":"                }"},{"line_number":57,"context_line":"            ]"},{"line_number":58,"context_line":"        },"},{"line_number":59,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_ac2721b5","line":56,"updated":"2015-04-01 01:18:19.000000000","message":"ditto","commit_id":"d5013e707c50282fa381d43ab6c8562c75f96bdf"}]}
