)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"360b50cd7f874be02854f791a47b770ab7b49121","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Calculate the numa usage"},{"line_number":279,"context_line":"        instance[\u0027numa_topology\u0027] \u003d self.instance_numa_topology"},{"line_number":280,"context_line":"        updated_numa_topology \u003d hardware.get_host_numa_usage_from_instance("},{"line_number":281,"context_line":"                self, instance)"},{"line_number":282,"context_line":"        self.numa_topology \u003d updated_numa_topology"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        vm_state \u003d instance.get(\u0027vm_state\u0027, vm_states.BUILDING)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_696579b3","side":"PARENT","line":281,"updated":"2015-04-09 07:14:51.000000000","message":"how about we catch exception.CPUPinningInvalid at here instead of running \u0027hardware.numa_fit_instance_to_host\u0027?\n\nMaybe another improvement for this is enable retry when consume resource at scheduler, instead of waiting RT trigger retry.","commit_id":"bf70df295b0529da9f4381f52fc94d328fa2fdb3"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1116104156584f97490aef0f64b11968d2641067","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Calculate the numa usage"},{"line_number":279,"context_line":"        instance[\u0027numa_topology\u0027] \u003d self.instance_numa_topology"},{"line_number":280,"context_line":"        updated_numa_topology \u003d hardware.get_host_numa_usage_from_instance("},{"line_number":281,"context_line":"                self, instance)"},{"line_number":282,"context_line":"        self.numa_topology \u003d updated_numa_topology"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        vm_state \u003d instance.get(\u0027vm_state\u0027, vm_states.BUILDING)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_6e38daef","side":"PARENT","line":281,"in_reply_to":"9aa53dc9_696579b3","updated":"2015-04-09 09:13:26.000000000","message":"That\u0027s what I did in the previous patchset, and Barton rightfully pointed out several issues with it and why this approach is better.","commit_id":"bf70df295b0529da9f4381f52fc94d328fa2fdb3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2ddd289f236dd13180d81b03e5287d7d4150ab53","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Calculate the numa usage"},{"line_number":279,"context_line":"        instance[\u0027numa_topology\u0027] \u003d self.instance_numa_topology"},{"line_number":280,"context_line":"        updated_numa_topology \u003d hardware.get_host_numa_usage_from_instance("},{"line_number":281,"context_line":"                self, instance)"},{"line_number":282,"context_line":"        self.numa_topology \u003d updated_numa_topology"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        vm_state \u003d instance.get(\u0027vm_state\u0027, vm_states.BUILDING)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_bb6055a6","side":"PARENT","line":281,"in_reply_to":"9aa53dc9_6e38daef","updated":"2015-04-09 13:49:25.000000000","message":"Thanks, I see now. Barton is right.","commit_id":"bf70df295b0529da9f4381f52fc94d328fa2fdb3"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"269020cfb8ec8d6e910bf409818ce81d9975a09b","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"        self.assertEqual(0, res.cells[0].memory_usage)"},{"line_number":1681,"context_line":"        self.assertEqual(0, res.cells[1].cpu_usage)"},{"line_number":1682,"context_line":"        self.assertEqual(0, res.cells[1].memory_usage)"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"    def test_dict_numa_topology_to_obj(self):"},{"line_number":1686,"context_line":"        fake_uuid \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_ade05ffb","line":1683,"updated":"2015-03-31 11:54:40.000000000","message":"one too many lines - maybe this is the pep8 failure","commit_id":"4cdbb3760f0f31c0ddfdb56c435738efd74dfdc2"}],"nova/virt/hardware.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"269020cfb8ec8d6e910bf409818ce81d9975a09b","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                 decreased instead."},{"line_number":1208,"context_line":"    :param never_serialize_result: if True result will always be an instance of"},{"line_number":1209,"context_line":"                                   objects.NUMATopology class."},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"    :returns: numa_usage in the format it was on the host or"},{"line_number":1212,"context_line":"              objects.NUMATopology instance if never_serialize_result was True"},{"line_number":1213,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_cdb043e0","line":1210,"updated":"2015-03-31 11:54:40.000000000","message":"please add doctring here","commit_id":"4cdbb3760f0f31c0ddfdb56c435738efd74dfdc2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"269020cfb8ec8d6e910bf409818ce81d9975a09b","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        if not ignore_errors:"},{"line_number":1227,"context_line":"            raise"},{"line_number":1228,"context_line":"        LOG.debug(\"Invalid instance NUMA topology for the host. \""},{"line_number":1229,"context_line":"                  \"Ignoring exception: %(ex)s\" % {\"ex\": e.format_message()})"},{"line_number":1230,"context_line":"        updated_numa_topology \u003d copy.deepcopy(host_numa_topology)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    if updated_numa_topology is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_cdaba388","line":1229,"updated":"2015-03-31 11:54:40.000000000","message":"minor nit - please use a , instead of %","commit_id":"4cdbb3760f0f31c0ddfdb56c435738efd74dfdc2"}]}