)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"16b7f25a31b93a643260ba2b902c5d49b0804c74","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid querying for Service in resource tracker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, resource tracker used a service query to get get compute_node"},{"line_number":10,"context_line":"information from the db, utilizing the relationship between the two tables"},{"line_number":11,"context_line":"to make the query by host. Since then the relationship has been removed,"},{"line_number":12,"context_line":"a host column has been added to compute_node, and service_id made nullable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9a41bdd9_ef78c42d","line":9,"updated":"2015-07-13 15:46:23.000000000","message":"nit: 2 get","commit_id":"37523c4bcc0f4aaaf5307500ae3d5eab4b5a427d"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"370637fd09fb40e623dfefe6d50db5f322aed3fc","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        service \u003d self._get_service(context)"},{"line_number":315,"context_line":"        if not service:"},{"line_number":316,"context_line":"            # no service record, disable resource"},{"line_number":317,"context_line":"            return"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # now try to get the compute node record from the"},{"line_number":320,"context_line":"        # database. If we get one we use resources to initialize"}],"source_content_type":"text/x-python","patch_set":14,"id":"1af86dd1_033befec","side":"PARENT","line":317,"updated":"2015-06-12 15:18:03.000000000","message":"I just have a wonder if we should remove that, because the current behaviour is just disabling the resource if there is no service.\n\nBy removing this check, we explicitely accept to have no check since we know that the service is updated each time we run nova-compute python CLI so that should not be a problem, but I\u0027m still a little concerned about that.","commit_id":"116aa07a25b21c5019895dc0d98e06af7dda2f6b"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"2f79537f6459a9a122fdb13980adb8ca3d8ad7fa","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        service \u003d self._get_service(context)"},{"line_number":315,"context_line":"        if not service:"},{"line_number":316,"context_line":"            # no service record, disable resource"},{"line_number":317,"context_line":"            return"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # now try to get the compute node record from the"},{"line_number":320,"context_line":"        # database. If we get one we use resources to initialize"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_6f0a8f28","side":"PARENT","line":317,"in_reply_to":"1af86dd1_033befec","updated":"2015-06-15 15:01:39.000000000","message":"I think this came about as a safety measure because we used to fetch the compute node by querying the service. Now that we query the compute node directly it shouldn\u0027t be needed anymore.\n\nAlso, if we get to here and have no service in the db then we have bigger issues. It would mean that either the service record was not created at service startup (I don\u0027t think this can happen) or that it was deleted from under us, in which case more than this will go bad. Luckily the scheduler will quickly discard a host that has no service record as it would be considered down, right?","commit_id":"116aa07a25b21c5019895dc0d98e06af7dda2f6b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bb78eaa45679e882c861a712defe71cd8e5e628e","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        service \u003d self._get_service(context)"},{"line_number":315,"context_line":"        if not service:"},{"line_number":316,"context_line":"            # no service record, disable resource"},{"line_number":317,"context_line":"            return"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # now try to get the compute node record from the"},{"line_number":320,"context_line":"        # database. If we get one we use resources to initialize"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_3529ea37","side":"PARENT","line":317,"in_reply_to":"fa32b979_6f0a8f28","updated":"2015-06-16 21:06:28.000000000","message":"Yup, the scheduler does that.","commit_id":"116aa07a25b21c5019895dc0d98e06af7dda2f6b"}]}