)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"f7e1cbe726def8b980cbff6ed9afee88cf9dec9b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`cmp` method was removed in Python 3 it would be nice to use __lt__,"},{"line_number":10,"context_line":"__le__, __eq__, __ne__, __gt__ and __ge__ instead, which are Py2 and Py3"},{"line_number":11,"context_line":"compatible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c89da0831b77b73f55d8681fd7d946535cc89b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa041b7_038e1a78","line":11,"updated":"2015-04-02 17:02:24.000000000","message":"We are not working on making nova py3 compatible right now.  Still waiting for a clear plan dependency wise.","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"274b5fb6d87fbf3ad07989898a638ce5deb9b0a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`cmp` method was removed in Python 3 it would be nice to use __lt__,"},{"line_number":10,"context_line":"__le__, __eq__, __ne__, __gt__ and __ge__ instead, which are Py2 and Py3"},{"line_number":11,"context_line":"compatible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c89da0831b77b73f55d8681fd7d946535cc89b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa53dc9_eecb2671","line":11,"in_reply_to":"baa041b7_038e1a78","updated":"2015-04-07 12:26:14.000000000","message":"APIVersionRequest class(see https://review.openstack.org/#/c/152569/29/novaclient/api_versions.py for more deatils) and several others can be used in another projects, for example in novaclient, so it would be nice to have same code.","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f64714aed107dd7714f9b8d9b311ba888a5e4c0c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if ((self.is_null() and other.is_null()) or"},{"line_number":124,"context_line":"                (self.is_null() and not other.is_null())):"},{"line_number":125,"context_line":"            return False"},{"line_number":126,"context_line":"        elif self.is_null() and not other.is_null():"},{"line_number":127,"context_line":"            return True"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return ((self.ver_major, self.ver_minor) \u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4dca5b1c","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":51},"updated":"2015-08-13 21:53:50.000000000","message":"Shouldn\u0027t this be:\n\n not self.is_null() and other.is_null()\n\n?","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f343d61806834c34a22b4fa77286679a93875292","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if ((self.is_null() and other.is_null()) or"},{"line_number":124,"context_line":"                (self.is_null() and not other.is_null())):"},{"line_number":125,"context_line":"            return False"},{"line_number":126,"context_line":"        elif self.is_null() and not other.is_null():"},{"line_number":127,"context_line":"            return True"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return ((self.ver_major, self.ver_minor) \u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_30d16430","line":126,"in_reply_to":"1a4dcd0f_4dca5b1c","updated":"2015-08-13 22:31:02.000000000","message":"yes, you are right.","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1db3d81d2741c913571b6c739c4c8e0e0ab62186","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def __gt__(self, other):"},{"line_number":125,"context_line":"        if not isinstance(other, APIVersionRequest):"},{"line_number":126,"context_line":"            raise TypeError(_type_error_msg % {\"other\": other,"},{"line_number":127,"context_line":"                                               \"cls\": self.__class__})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        return ((self.ver_major, self.ver_minor) \u003e"},{"line_number":130,"context_line":"                (other.ver_major, other.ver_minor))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_da027609","line":127,"updated":"2015-08-14 15:16:17.000000000","message":"those 3 TypeErrors ar identical\n\nI think it would be better to write a new function and call it so you don\u0027t need this definition at #77 , you can directly use it instead of a global def","commit_id":"d4a7bbeed5905996b8b1a8b6bdffc092d427655c"}],"nova/tests/unit/api/openstack/test_api_version_request.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8a34d912201692e46501fb0bff4c672ff548809e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.assertTrue(v1 \u003d\u003d v4)"},{"line_number":86,"context_line":"        self.assertTrue(v1 !\u003d v_null)"},{"line_number":87,"context_line":"        self.assertTrue(v_null \u003d\u003d v_null)"},{"line_number":88,"context_line":"        self.assertRaises(TypeError, v1.__le__, \"2.1\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_version_matches(self):"},{"line_number":91,"context_line":"        v1 \u003d api_version_request.APIVersionRequest(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_2d16ef58","line":88,"updated":"2015-08-13 21:57:49.000000000","message":"I think there should be cases for comparisons to null that are missing: \u003c, \u003e","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6dd4f0d6c1b497f9f21ccf07fc51758f3a7c454a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.assertTrue(v1 \u003d\u003d v4)"},{"line_number":86,"context_line":"        self.assertTrue(v1 !\u003d v_null)"},{"line_number":87,"context_line":"        self.assertTrue(v_null \u003d\u003d v_null)"},{"line_number":88,"context_line":"        self.assertRaises(TypeError, v1.__le__, \"2.1\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_version_matches(self):"},{"line_number":91,"context_line":"        v1 \u003d api_version_request.APIVersionRequest(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_40943e43","line":88,"in_reply_to":"1a4dcd0f_2d16ef58","updated":"2015-08-14 15:31:53.000000000","message":"Done","commit_id":"08cbdffd1655c8db8ca76c5ccc82b2f256575db0"}],"tox.ini":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1db3d81d2741c913571b6c739c4c8e0e0ab62186","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":38,"context_line":"  python -m subunit.run discover -t . ./nova/tests/ --list"},{"line_number":39,"context_line":"  python -m testtools.run \\"},{"line_number":40,"context_line":"    nova.tests.unit.api.openstack.test_api_version_request \\"},{"line_number":41,"context_line":"    nova.tests.unit.compute.test_keypairs \\"},{"line_number":42,"context_line":"    nova.tests.unit.db.test_db_api \\"},{"line_number":43,"context_line":"    nova.tests.unit.scheduler.filters.test_affinity_filters \\"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a4dcd0f_fa32d2f1","line":40,"updated":"2015-08-14 15:16:17.000000000","message":"this is not related ... a separate fix?","commit_id":"d4a7bbeed5905996b8b1a8b6bdffc092d427655c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"70bef5b9076782647c139196782b5c73fe157984","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":38,"context_line":"  python -m subunit.run discover -t . ./nova/tests/ --list"},{"line_number":39,"context_line":"  python -m testtools.run \\"},{"line_number":40,"context_line":"    nova.tests.unit.api.openstack.test_api_version_request \\"},{"line_number":41,"context_line":"    nova.tests.unit.compute.test_keypairs \\"},{"line_number":42,"context_line":"    nova.tests.unit.db.test_db_api \\"},{"line_number":43,"context_line":"    nova.tests.unit.scheduler.filters.test_affinity_filters \\"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a4dcd0f_3df834c4","line":40,"in_reply_to":"1a4dcd0f_daf1166c","updated":"2015-08-14 15:38:24.000000000","message":"yes, I got it , thanks","commit_id":"d4a7bbeed5905996b8b1a8b6bdffc092d427655c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"341c8b078ac979c2535380294592a4bb9d99ed99","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":38,"context_line":"  python -m subunit.run discover -t . ./nova/tests/ --list"},{"line_number":39,"context_line":"  python -m testtools.run \\"},{"line_number":40,"context_line":"    nova.tests.unit.api.openstack.test_api_version_request \\"},{"line_number":41,"context_line":"    nova.tests.unit.compute.test_keypairs \\"},{"line_number":42,"context_line":"    nova.tests.unit.db.test_db_api \\"},{"line_number":43,"context_line":"    nova.tests.unit.scheduler.filters.test_affinity_filters \\"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a4dcd0f_daf1166c","line":40,"in_reply_to":"1a4dcd0f_fa32d2f1","updated":"2015-08-14 15:31:39.000000000","message":"it relates to this patch, since __cmp__ method was a blocker to launch this tests in py3 env.","commit_id":"d4a7bbeed5905996b8b1a8b6bdffc092d427655c"}]}