)]}'
{"nova/api/openstack/compute/contrib/aggregates.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f0332da74093fff280bdd7c8a0f323e11664824e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                exception.InvalidAggregateAction):"},{"line_number":76,"context_line":"            LOG.info(_(\"Cannot create aggregate with name %(name)s and \""},{"line_number":77,"context_line":"                            \"availability zone %(avail_zone)s\") % locals())"},{"line_number":78,"context_line":"            raise"},{"line_number":79,"context_line":"        return self._marshall_aggregate(aggregate)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def show(self, req, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fwk0%3D","line":78,"updated":"2012-11-26 23:09:52.000000000","message":"But if AggregateNameExists was the exception that was raised, we now return a 500, assuming I read the inheritance tree correctly; in that case, we probably should return a 409.","commit_id":"b85b3fea44d538ae2fd7b438e9603928a2fca77a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"baa2c54ac4f6ea44c378aa86a02a09982862195a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            LOG.info(e)"},{"line_number":76,"context_line":"            raise exc.HTTPConflict"},{"line_number":77,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":78,"context_line":"            LOG.info(e)"},{"line_number":79,"context_line":"            raise"},{"line_number":80,"context_line":"        return self._marshall_aggregate(aggregate)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fwho%3D","line":78,"updated":"2012-11-26 23:31:58.000000000","message":"I have a niggling feeling in the back of my head that \"LOG.info(e)\" should be augmented to at least \"LOG.info(_(\u0027Aggregate name exists: %s\u0027) % e)\" or similar, but I can\u0027t put my finger on any specific reason it should be the latter…","commit_id":"a15abf202552df1e8c6ca9415189ff8a95a8d174"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"81946b37f8e8d52fb9f7a16c77038960627961e4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            LOG.info(e)"},{"line_number":76,"context_line":"            raise exc.HTTPConflict"},{"line_number":77,"context_line":"        except exception.InvalidAggregateAction as e:"},{"line_number":78,"context_line":"            LOG.info(e)"},{"line_number":79,"context_line":"            raise"},{"line_number":80,"context_line":"        return self._marshall_aggregate(aggregate)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fwg4%3D","line":78,"in_reply_to":"AAAAMH%2F%2Fwho%3D","updated":"2012-11-26 23:45:20.000000000","message":"The Exception message itself should be detailed enough to not need any preface.   In this case it is: \"Cannot perform action \u0027%(action)s\u0027 on aggregate %(aggregate_id)s. Reason: %(reason)s.\"","commit_id":"a15abf202552df1e8c6ca9415189ff8a95a8d174"}]}