)]}'
{"nova/virt/libvirt/rbd_utils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd7a46b0008a9ea20716e0ff3b1830e9547c1c05","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                rbd.RBD().remove(client.ioctx, volume)"},{"line_number":261,"context_line":"                raise loopingcall.LoopingCallDone(retvalue\u003dFalse)"},{"line_number":262,"context_line":"            except (rbd.ImageNotFound, rbd.ImageHasSnapshots):"},{"line_number":263,"context_line":"                LOG.warn(_LW(\u0027rbd remove %(volume)s in pool %(pool)s \u0027"},{"line_number":264,"context_line":"                             \u0027failed\u0027),"},{"line_number":265,"context_line":"                         {\u0027volume\u0027: volume, \u0027pool\u0027: self.pool})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_d5a49609","line":262,"updated":"2015-04-01 15:55:06.000000000","message":"Do you intend to keep looping if rbd.ImageHasSnapshots is raised?  Is that a case that will ever pass?  Or since it\u0027s only 3 seconds do we not care?","commit_id":"4ebfd68630f54d10339313df8f11faf4184216c8"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"8c2e37c08c7572d0cb3b35fbb2f50cd631f47cf7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                rbd.RBD().remove(client.ioctx, volume)"},{"line_number":261,"context_line":"                raise loopingcall.LoopingCallDone(retvalue\u003dFalse)"},{"line_number":262,"context_line":"            except (rbd.ImageNotFound, rbd.ImageHasSnapshots):"},{"line_number":263,"context_line":"                LOG.warn(_LW(\u0027rbd remove %(volume)s in pool %(pool)s \u0027"},{"line_number":264,"context_line":"                             \u0027failed\u0027),"},{"line_number":265,"context_line":"                         {\u0027volume\u0027: volume, \u0027pool\u0027: self.pool})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_3273b1b3","line":262,"in_reply_to":"baa041b7_d5a49609","updated":"2015-04-02 13:28:07.000000000","message":"This is a fair point Matt, though will be moot with change I6a5ca4c68a39c2abf5f3f7d2d863fa2198d3c8e9","commit_id":"4ebfd68630f54d10339313df8f11faf4184216c8"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"d4a4db92392b51a0f8c91f46ff155c6c64381b8f","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                rbd.RBD().remove(client.ioctx, volume)"},{"line_number":261,"context_line":"                raise loopingcall.LoopingCallDone(retvalue\u003dFalse)"},{"line_number":262,"context_line":"            except (rbd.ImageBusy, rbd.ImageHasSnapshots):"},{"line_number":263,"context_line":"                LOG.warn(_LW(\u0027rbd remove %(volume)s in pool %(pool)s \u0027"},{"line_number":264,"context_line":"                             \u0027failed\u0027),"},{"line_number":265,"context_line":"                         {\u0027volume\u0027: volume, \u0027pool\u0027: self.pool})"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_72a019f5","line":262,"updated":"2015-04-02 13:27:49.000000000","message":"rbd.ImageNotFound is no longer handled. Is that intentional?","commit_id":"a37bc78ed57aeabbb87b26f77fd785db3ee6a9ba"}]}