)]}'
{"nova/objects/instance_group.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6d87c23f7952330cb1c95998301331780e1ccf27","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        filter_uuids \u003d self.members"},{"line_number":221,"context_line":"        filters \u003d {\u0027uuid\u0027: filter_uuids, \u0027deleted\u0027: False}"},{"line_number":222,"context_line":"        instances \u003d objects.InstanceList.get_by_filters(self._context,"},{"line_number":223,"context_line":"                                                        filters\u003dfilters)"},{"line_number":224,"context_line":"        first_instance \u003d None"},{"line_number":225,"context_line":"        for i in instances:"},{"line_number":226,"context_line":"            if not i.host:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_3b4b6c89","line":223,"updated":"2015-04-21 16:56:27.000000000","message":"same concern as the one I raised before in https://review.openstack.org/#/c/164762/9/nova/objects/instance_group.py,cm and makes me emphasize how I think it\u0027s just adding more debt","commit_id":"ae34806b7c6282b9e16a88e6c2eee3aecd2edb0e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5acd88645345e06f34743a62cafd1587ab7b6e17","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        filter_uuids \u003d self.members"},{"line_number":221,"context_line":"        filters \u003d {\u0027uuid\u0027: filter_uuids, \u0027deleted\u0027: False}"},{"line_number":222,"context_line":"        instances \u003d objects.InstanceList.get_by_filters(self._context,"},{"line_number":223,"context_line":"                                                        filters\u003dfilters)"},{"line_number":224,"context_line":"        first_instance \u003d None"},{"line_number":225,"context_line":"        for i in instances:"},{"line_number":226,"context_line":"            if not i.host:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_2c9690f0","line":223,"in_reply_to":"dac4157f_3b4b6c89","updated":"2015-04-21 18:07:20.000000000","message":"In this case the alternative would be to have nova-compute call InstanceList.get_by_filters() to get the instances in the group, and then evaluate them locally within nova-compute.\n\nLike the other case, I had assumed that it was better to add a remotable function than to pass all the instances in the group back via RPC and process them on the compute node.\n\nIf that\u0027s not the case, then this logic could be moved to nova-compute.","commit_id":"ae34806b7c6282b9e16a88e6c2eee3aecd2edb0e"}]}