)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":20764,"name":"Sachin","email":"psachin@redhat.com","username":"psachin"},"change_message_id":"e6857cdc20563c7e66da271601ca67fa6b7d8e43","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            # Migrate the flavor from system_metadata to extra,"},{"line_number":462,"context_line":"            # if needed"},{"line_number":463,"context_line":"            instance_extra \u003d db_inst.get(\u0027extra\u0027) or {}"},{"line_number":464,"context_line":"            if instance_extra.get(\u0027flavor\u0027) is not None:"},{"line_number":465,"context_line":"                self._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])"},{"line_number":466,"context_line":"            elif \u0027instance_type_id\u0027 in self.system_metadata:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_471fe66b","line":463,"updated":"2016-03-23 12:41:00.000000000","message":"I don\u0027t see the difference in the o/p. What exactly has changed? Previous code was more concise","commit_id":"ae870634d152c3120364775b95220f07ddf3e1fb"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ea3e856e1a13fa07b88ce1ef4c7536c250e99d2c","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            # Migrate the flavor from system_metadata to extra,"},{"line_number":462,"context_line":"            # if needed"},{"line_number":463,"context_line":"            instance_extra \u003d db_inst.get(\u0027extra\u0027) or {}"},{"line_number":464,"context_line":"            if instance_extra.get(\u0027flavor\u0027) is not None:"},{"line_number":465,"context_line":"                self._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])"},{"line_number":466,"context_line":"            elif \u0027instance_type_id\u0027 in self.system_metadata:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_7f8f122a","line":463,"in_reply_to":"fa0719c6_471fe66b","updated":"2016-03-23 13:16:45.000000000","message":"The commit message explains it.\n\ndb_inst.get(\u0027extra\u0027, {}) returns {} if \u0027extra\u0027 is missing but None if db_inst[\u0027extra\u0027] is None. When it returns None the .get(\u0027flavor\u0027) fails on an AttributeError.","commit_id":"ae870634d152c3120364775b95220f07ddf3e1fb"},{"author":{"_account_id":20764,"name":"Sachin","email":"psachin@redhat.com","username":"psachin"},"change_message_id":"7dfa2faabe1514f862771df6d8b440d019f88cf6","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            # Migrate the flavor from system_metadata to extra,"},{"line_number":462,"context_line":"            # if needed"},{"line_number":463,"context_line":"            instance_extra \u003d db_inst.get(\u0027extra\u0027) or {}"},{"line_number":464,"context_line":"            if instance_extra.get(\u0027flavor\u0027) is not None:"},{"line_number":465,"context_line":"                self._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])"},{"line_number":466,"context_line":"            elif \u0027instance_type_id\u0027 in self.system_metadata:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_6cf4bf85","line":463,"in_reply_to":"fa0719c6_7f8f122a","updated":"2016-03-28 10:36:15.000000000","message":"Done","commit_id":"ae870634d152c3120364775b95220f07ddf3e1fb"}]}