)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/144_add_node_to_migrations.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0864fa878cbb3d3db8be25ae1100304ecf51febb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # index key length is too long.)"},{"line_number":99,"context_line":"        sql \u003d (\"create index migrations_by_host_nodes_and_status_idx ON \""},{"line_number":100,"context_line":"               \"migrations (deleted, source_compute(100), dest_compute(100), \""},{"line_number":101,"context_line":"               \"source_node(100), dest_node(100), status)\")"},{"line_number":102,"context_line":"        migrate_engine.execute(sql)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FvUI%3D","line":101,"updated":"2012-11-27 21:34:34.000000000","message":"that\u0027s definitely a weird index definition. I also question the value of an index that\u0027s that many columns. Do we actually need it?","commit_id":"846b6c92069cab9d4ae9b02f23f82583c0194fb3"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"74ded89b4e6b40738dc6278e0f9e1539a6afe441","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # index key length is too long.)"},{"line_number":99,"context_line":"        sql \u003d (\"create index migrations_by_host_nodes_and_status_idx ON \""},{"line_number":100,"context_line":"               \"migrations (deleted, source_compute(100), dest_compute(100), \""},{"line_number":101,"context_line":"               \"source_node(100), dest_node(100), status)\")"},{"line_number":102,"context_line":"        migrate_engine.execute(sql)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FvTU%3D","line":101,"in_reply_to":"AAAAMH%2F%2FvUI%3D","updated":"2012-11-27 21:40:07.000000000","message":"It\u0027s going to run within a periodic task and in a couple other resize.  Our migrations table at Rackspace is pretty dang big, so I\u0027d rather be safe here.","commit_id":"846b6c92069cab9d4ae9b02f23f82583c0194fb3"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3339da6af8c01bfcdaf790f294bd57268eb2dbb0","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    Skip updates for multi-node hosts.  In that case, there\u0027s no way to"},{"line_number":138,"context_line":"    determine which node on a host the record should be associated with."},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":"    q \u003d select([migrations.c.id, migrations.c.source_compute,"},{"line_number":141,"context_line":"               migrations.c.dest_compute, instances.c.uuid, instances.c.host,"},{"line_number":142,"context_line":"               instances.c.node],"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FvU4%3D","line":140,"updated":"2012-11-27 21:27:37.000000000","message":"should we skip migration entries that have finished or are in error?","commit_id":"846b6c92069cab9d4ae9b02f23f82583c0194fb3"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"be84f7a64102913252c8b54dab47d8104b77d4a6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    Skip updates for multi-node hosts.  In that case, there\u0027s no way to"},{"line_number":138,"context_line":"    determine which node on a host the record should be associated with."},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":"    q \u003d select([migrations.c.id, migrations.c.source_compute,"},{"line_number":141,"context_line":"               migrations.c.dest_compute, instances.c.uuid, instances.c.host,"},{"line_number":142,"context_line":"               instances.c.node],"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FvSA%3D","line":140,"in_reply_to":"AAAAMH%2F%2FvU4%3D","updated":"2012-11-27 21:48:50.000000000","message":"Actually, going to skip ones in \u0027error\u0027 and \u0027reverted\u0027.  Pulling the \u0027finished\u0027 ones gives an easy way to fix the associated instance[\u0027node\u0027] field that wasn\u0027t getting updated due to the bug.","commit_id":"846b6c92069cab9d4ae9b02f23f82583c0194fb3"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"74ded89b4e6b40738dc6278e0f9e1539a6afe441","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    Skip updates for multi-node hosts.  In that case, there\u0027s no way to"},{"line_number":138,"context_line":"    determine which node on a host the record should be associated with."},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":"    q \u003d select([migrations.c.id, migrations.c.source_compute,"},{"line_number":141,"context_line":"               migrations.c.dest_compute, instances.c.uuid, instances.c.host,"},{"line_number":142,"context_line":"               instances.c.node],"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FvTQ%3D","line":140,"in_reply_to":"AAAAMH%2F%2FvU4%3D","updated":"2012-11-27 21:40:07.000000000","message":"Done","commit_id":"846b6c92069cab9d4ae9b02f23f82583c0194fb3"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"27ab584b35201d48cb2c53709c4739e893b2ef36","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               whereclause\u003dand_(c_nodes.c.deleted \u003d\u003d 0,"},{"line_number":81,"context_line":"                                services.c.deleted \u003d\u003d 0),"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                from_obj\u003dc_nodes.join(services,"},{"line_number":84,"context_line":"                                      c_nodes.c.service_id \u003d\u003d services.c.id)"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FvJI%3D","line":83,"updated":"2012-11-27 23:26:45.000000000","message":"looks like this is indented 1 extra char...","commit_id":"45d27c6f23a3162a7d4ba63883c107a658e662e6"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"8b515911e1c265ae8e92e186be008b10ddf484e7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               whereclause\u003dand_(c_nodes.c.deleted \u003d\u003d 0,"},{"line_number":81,"context_line":"                                services.c.deleted \u003d\u003d 0),"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                from_obj\u003dc_nodes.join(services,"},{"line_number":84,"context_line":"                                      c_nodes.c.service_id \u003d\u003d services.c.id)"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FvBc%3D","line":83,"in_reply_to":"AAAAMH%2F%2FvJI%3D","updated":"2012-11-28 01:15:40.000000000","message":"Done","commit_id":"45d27c6f23a3162a7d4ba63883c107a658e662e6"}]}