)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ff29a77eb4ca23c598381ca6d37b74c48cbeeda9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Renaming an instance only updates the display_name while the hostname"},{"line_number":10,"context_line":"remains unchanged in the database. Due to this behavior the hostname"},{"line_number":11,"context_line":"will not be updated via rebuilding the instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The expected behavior is to update both values when renaming the"},{"line_number":14,"context_line":"instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7aaa499b_aa5a8128","line":11,"updated":"2015-04-14 11:30:39.000000000","message":"This patch changes \"update a server\" API, not \"rebuild a server\" API.\nSo I am not sure why this patch can close a bug #1068154\n\n\"update a server\" API just changes DB entry without changing an instance. Current change of display_name seems enough on the API.","commit_id":"ef224e52fbd8842b30d7aeeeb5a1125e3f4b9496"}],"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c4a0075cfb6b613671f68290691b40ba5255921e","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            name \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027display_name\u0027] \u003d name.strip()"},{"line_number":746,"context_line":"            update_dict[\u0027hostname\u0027] \u003d name.strip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        if list(self.update_extension_manager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_96882ce9","line":745,"updated":"2015-04-07 14:09:36.000000000","message":"update_dict[\u0027hostname\u0027] \u003d update_dict[\u0027display_name\u0027]","commit_id":"934d2eb255385cc1033e2a4658c897a38107ed94"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"3ca44ee06890eec2fcda0b7627c5138ca5950412","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            name \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027display_name\u0027] \u003d name.strip()"},{"line_number":746,"context_line":"            update_dict[\u0027hostname\u0027] \u003d name.strip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        if list(self.update_extension_manager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_ecbb240d","line":745,"in_reply_to":"9aa53dc9_96882ce9","updated":"2015-04-07 15:56:34.000000000","message":"Done","commit_id":"934d2eb255385cc1033e2a4658c897a38107ed94"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"abde8e8d481c3ed15d77d7b2ff523f13d5ac6b49","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_0f94fadf","line":745,"updated":"2015-04-07 16:11:52.000000000","message":"Hum so now you missed to \"strip\" the value, actually i was expected something like:\n\n  name \u003d  body[\u0027server\u0027][\u0027name\u0027].strip()\n  update_dict[\u0027display_name\u0027] \u003d name\n  update_dict[\u0027hostname\u0027] \u003d name\n\nor\n\n  update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027].strip()\n  update_dict[\u0027hostname\u0027] \u003d  update_dict[\u0027display_name\u0027] \n\nTo avoid the duplicate call of \u0027strip\u0027 but it was just a nit really. - Please if you do a change, try to make it the same in both files (servers.py and v3/serversp.py)","commit_id":"b775c3738da998f03a1c7b339ec264690e73942d"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"3ee900e01a2f19922a05392b2a4cb983ca6e6ac4","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_91aee483","line":745,"in_reply_to":"9aa53dc9_0f94fadf","updated":"2015-04-07 20:13:57.000000000","message":"Done","commit_id":"b775c3738da998f03a1c7b339ec264690e73942d"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"b566a4f152b0966df5af6ec3da04c4141e2f15e1","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_11589431","line":745,"in_reply_to":"9aa53dc9_0f94fadf","updated":"2015-04-07 20:13:31.000000000","message":"Sorry, but my previous patchset was a bit misleading.\nCalling \u0027strip\u0027 function in v3 API is not necessary as the schema validation will raise ValidationError before updating the \u0027update_dict\u0027 if the string in \u0027name\u0027 contains whitespace.\nThe following pattern is used for hostname validation: \u0027^[a-zA-Z0-9-._]*$\u0027.","commit_id":"b775c3738da998f03a1c7b339ec264690e73942d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f7b94fc253a1829abb24cc7134e37519df3a5708","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_5cae1a86","line":745,"in_reply_to":"9aa53dc9_91aee483","updated":"2015-04-08 11:03:07.000000000","message":"I see, so i guess it is good now.","commit_id":"b775c3738da998f03a1c7b339ec264690e73942d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"653bc29b13fd97b2a28d343509d1e28de0e2bda4","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_ed14e2a0","line":745,"updated":"2015-04-09 14:56:21.000000000","message":"we should call this utils.sanitize_hostname(hostname)?","commit_id":"ef224e52fbd8842b30d7aeeeb5a1125e3f4b9496"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"28d87d34d2639f1286aa47978d26139cdfe5a447","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_c389ef76","line":745,"in_reply_to":"9aa53dc9_e02e2942","updated":"2015-04-09 15:24:54.000000000","message":"@Matt, sanitize_hostname for filter out some illegal character. But I checked the json-schema will validated the name for v2.1 api. But there isn\u0027t json-schema for v2 API. So we needn\u0027t sanitize_hostname at here. But need it for v2 api. does make sense?","commit_id":"ef224e52fbd8842b30d7aeeeb5a1125e3f4b9496"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"1f68c8237e52c2dcb404b427f8ec0767fc0f9b4b","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if \u0027name\u0027 in body[\u0027server\u0027]:"},{"line_number":744,"context_line":"            update_dict[\u0027display_name\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":745,"context_line":"            update_dict[\u0027hostname\u0027] \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if list(self.update_extension_manager):"},{"line_number":748,"context_line":"            self.update_extension_manager.map(self._update_extension_point,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_e02e2942","line":745,"in_reply_to":"9aa53dc9_ed14e2a0","updated":"2015-04-09 15:08:46.000000000","message":"@Alex: Looks like sanitize_hostname is called in compute API. Doesn\u0027t look like it\u0027s necessary to call it. Please correct me if I\u0027m wrong.\n\nhttps://github.com/openstack/nova/blob/0d56069146679d244c891a63c4b454e5fe3f2bf9/nova/compute/api.py#L1290-L1311","commit_id":"ef224e52fbd8842b30d7aeeeb5a1125e3f4b9496"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c4a0075cfb6b613671f68290691b40ba5255921e","unresolved":false,"context_lines":[{"line_number":671,"context_line":"            name \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":672,"context_line":"            self._validate_server_name(name)"},{"line_number":673,"context_line":"            update_dict[\u0027display_name\u0027] \u003d name.strip()"},{"line_number":674,"context_line":"            update_dict[\u0027hostname\u0027] \u003d name.strip()"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        if \u0027accessIPv4\u0027 in body[\u0027server\u0027]:"},{"line_number":677,"context_line":"            access_ipv4 \u003d body[\u0027server\u0027][\u0027accessIPv4\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_16753cf8","line":674,"updated":"2015-04-07 14:09:36.000000000","message":"update_dict[\u0027hostname\u0027] \u003d update_dict[\u0027display_name\u0027]","commit_id":"934d2eb255385cc1033e2a4658c897a38107ed94"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"3ca44ee06890eec2fcda0b7627c5138ca5950412","unresolved":false,"context_lines":[{"line_number":671,"context_line":"            name \u003d body[\u0027server\u0027][\u0027name\u0027]"},{"line_number":672,"context_line":"            self._validate_server_name(name)"},{"line_number":673,"context_line":"            update_dict[\u0027display_name\u0027] \u003d name.strip()"},{"line_number":674,"context_line":"            update_dict[\u0027hostname\u0027] \u003d name.strip()"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        if \u0027accessIPv4\u0027 in body[\u0027server\u0027]:"},{"line_number":677,"context_line":"            access_ipv4 \u003d body[\u0027server\u0027][\u0027accessIPv4\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_2cdb4c7e","line":674,"in_reply_to":"9aa53dc9_16753cf8","updated":"2015-04-07 15:56:34.000000000","message":"Done","commit_id":"934d2eb255385cc1033e2a4658c897a38107ed94"}]}