)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b2a18ec614268a8e1a0cf92d3f81bb8ce61c1f7d","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                CONF.scheduler_available_filters)"},{"line_number":311,"context_line":"        self.filter_cls_map \u003d {cls.__name__: cls for cls in filter_classes}"},{"line_number":312,"context_line":"        self.filter_obj_map \u003d {}"},{"line_number":313,"context_line":"        self.default_filters \u003d self._choose_host_filters(self._load_filters())"},{"line_number":314,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler()"},{"line_number":315,"context_line":"        weigher_classes \u003d self.weight_handler.get_matching_classes("},{"line_number":316,"context_line":"                CONF.scheduler_weight_classes)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_fd9ba770","line":313,"updated":"2015-04-03 20:07:44.000000000","message":"Given a choice I would probably have _load_filters return self._choose_host_filters(CONF.scheduler_default_filters) and make this one method call here.  Or rename _load_filters to _filters.  But this works well enough.","commit_id":"c4dc66994c5548afa4a13b42069d77435b6df6bb"}],"nova/scheduler/ironic_host_manager.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"dcf20edc21f334a27feb15938bcc24927c4ed6f6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if CONF.scheduler_use_baremetal_filters:"},{"line_number":103,"context_line":"            baremetal_default \u003d CONF.baremetal_scheduler_default_filters"},{"line_number":104,"context_line":"            CONF.scheduler_default_filters \u003d baremetal_default"},{"line_number":105,"context_line":"        super(IronicHostManager, self).__init__()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def host_state_cls(self, host, node, **kwargs):"},{"line_number":108,"context_line":"        \"\"\"Factory function/property to create a new HostState.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_3eea4910","line":105,"updated":"2015-04-02 22:09:57.000000000","message":"Nice change.  It might be nice to have a comment here explaining that this needs to come after the CONF override so some enterprising person doesn\u0027t move this up again later.  Though the test should catch that.","commit_id":"229976defe3585c7f9de2116d9d253368b21daff"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c3a6c004723cb45904f8569a80474f1786fc9f5f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\"Ironic HostManager class.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __init__(self):"},{"line_number":102,"context_line":"        if CONF.scheduler_use_baremetal_filters:"},{"line_number":103,"context_line":"            baremetal_default \u003d CONF.baremetal_scheduler_default_filters"},{"line_number":104,"context_line":"            CONF.scheduler_default_filters \u003d baremetal_default"},{"line_number":105,"context_line":"        super(IronicHostManager, self).__init__()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_bfe8817d","line":102,"updated":"2015-04-03 14:16:24.000000000","message":"Some downstream testing has revealed that this is not safe for testing since this overrides a global setting which other tests might rely on.","commit_id":"d1d312747a8fed1de2e49d4e95a79821fc3c652b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ad02a1705b2c4a262d9c68b5f4fb55f69893c6f4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if CONF.scheduler_use_baremetal_filters:"},{"line_number":103,"context_line":"            baremetal_default \u003d CONF.baremetal_scheduler_default_filters"},{"line_number":104,"context_line":"            CONF.scheduler_default_filters \u003d baremetal_default"},{"line_number":105,"context_line":"        super(IronicHostManager, self).__init__()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def host_state_cls(self, host, node, **kwargs):"},{"line_number":108,"context_line":"        \"\"\"Factory function/property to create a new HostState.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_d9ec852b","line":105,"updated":"2015-04-03 13:12:41.000000000","message":"Still wouldn\u0027t mind a comment here if you respin this :)","commit_id":"d1d312747a8fed1de2e49d4e95a79821fc3c652b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"7cf72720e3cc9dd0b15635d46df51ec52f8eba08","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _load_filters(self):"},{"line_number":102,"context_line":"        if CONF.scheduler_use_baremetal_filters:"},{"line_number":103,"context_line":"            return CONF.baremetal_scheduler_default_filters"},{"line_number":104,"context_line":"        super(IronicHostManager, self)._load_filters()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def host_state_cls(self, host, node, **kwargs):"},{"line_number":107,"context_line":"        \"\"\"Factory function/property to create a new HostState.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_a74cf742","line":104,"updated":"2015-04-03 15:12:28.000000000","message":"Shouldn\u0027t this be a \u0027return\u0027 statement? I.e.:\n\n  return super(Ironic...)","commit_id":"66c2442f299b02dda75506b92d103b39e8f574de"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"93ce2e4f784da9336a614ba5af37652eeb0e7195","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _load_filters(self):"},{"line_number":102,"context_line":"        if CONF.scheduler_use_baremetal_filters:"},{"line_number":103,"context_line":"            return CONF.baremetal_scheduler_default_filters"},{"line_number":104,"context_line":"        super(IronicHostManager, self)._load_filters()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def host_state_cls(self, host, node, **kwargs):"},{"line_number":107,"context_line":"        \"\"\"Factory function/property to create a new HostState.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_c786dbda","line":104,"in_reply_to":"baa041b7_a74cf742","updated":"2015-04-03 15:21:09.000000000","message":"Good catch, thank you :)","commit_id":"66c2442f299b02dda75506b92d103b39e8f574de"}]}