)]}'
{"nova/virt/powervm/blockdev.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5a5657da9cb33f6fe9b72b9edb7d35b9f5d3bcc5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                raise"},{"line_number":120,"context_line":"            finally:"},{"line_number":121,"context_line":"                self.delete_volume(disk_name)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        return {\u0027device_name\u0027: disk_name}"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtQ8%3D","line":121,"updated":"2012-11-29 14:36:30.000000000","message":"Hmm, I\u0027m not sure why you\u0027re doing this try..raise..finally. Shouldn\u0027t this be log_and_reraise ?","commit_id":"e48eb304eb103e626a97a42b49545e29f6984042"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"f578314dc807d3d503e8fdaa636504bba9f8a65b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                raise"},{"line_number":120,"context_line":"            finally:"},{"line_number":121,"context_line":"                self.delete_volume(disk_name)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        return {\u0027device_name\u0027: disk_name}"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtNA%3D","line":121,"in_reply_to":"AAAAMH%2F%2FtQ8%3D","updated":"2012-11-29 15:25:44.000000000","message":"Yeah, it should... habit I picked up from other python projects, and I always forget nova has a better way of handling it.","commit_id":"e48eb304eb103e626a97a42b49545e29f6984042"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5a5657da9cb33f6fe9b72b9edb7d35b9f5d3bcc5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :returns: LPAR object"},{"line_number":341,"context_line":"        \"\"\""},{"line_number":342,"context_line":"        cmd \u003d self.command.lssyscfg(\u0027-r %s --filter \"lpar_names\u003d%s\"\u0027 %"},{"line_number":343,"context_line":"                                    (resource_type, instance_name))"},{"line_number":344,"context_line":"        output \u003d self.run_command(cmd)"},{"line_number":345,"context_line":"        if not output:"},{"line_number":346,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtQg%3D","line":343,"updated":"2012-11-29 14:36:30.000000000","message":"In general, please try to avoid random unrelated cleanups as it just makes the diff harder to read.","commit_id":"e48eb304eb103e626a97a42b49545e29f6984042"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"f578314dc807d3d503e8fdaa636504bba9f8a65b","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        :returns: LPAR object"},{"line_number":341,"context_line":"        \"\"\""},{"line_number":342,"context_line":"        cmd \u003d self.command.lssyscfg(\u0027-r %s --filter \"lpar_names\u003d%s\"\u0027 %"},{"line_number":343,"context_line":"                                    (resource_type, instance_name))"},{"line_number":344,"context_line":"        output \u003d self.run_command(cmd)"},{"line_number":345,"context_line":"        if not output:"},{"line_number":346,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtM4%3D","line":343,"in_reply_to":"AAAAMH%2F%2FtQg%3D","updated":"2012-11-29 15:25:44.000000000","message":"Right, not sure how this one snuck into my commit. Will fix","commit_id":"e48eb304eb103e626a97a42b49545e29f6984042"}]}